1 2018-03-30 Daniel Bates <dabates@apple.com>
3 ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
4 https://bugs.webkit.org/show_bug.cgi?id=184161
6 Reviewed by Per Arne Vollan.
8 * ManualTests/DragInlinePDFImageDocument.html: Added.
9 * ManualTests/resources/simple.pdf: Added.
11 2018-03-28 Tim Horton <timothy_horton@apple.com>
13 Make it possible to disable building the tools with Make
14 https://bugs.webkit.org/show_bug.cgi?id=184109
16 Reviewed by Simon Fraser.
20 2018-03-25 Carlos Garcia Campos <cgarcia@igalia.com>
22 [GTK][WPE] Add API to convert between DOM and JSCValue
23 https://bugs.webkit.org/show_bug.cgi?id=183448
25 Reviewed by Michael Catanzaro.
27 Define FORWARDING_HEADERS_WPE_DOM_DIR.
29 * Source/cmake/OptionsWPE.cmake:
31 2018-03-22 Adrian Perez de Castro <aperez@igalia.com>
33 [WPE] Enable WOFF2 support
34 https://bugs.webkit.org/show_bug.cgi?id=178158
36 Reviewed by Frédéric Wang.
38 * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
40 2018-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
42 [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
43 https://bugs.webkit.org/show_bug.cgi?id=164061
45 Reviewed by Michael Catanzaro.
47 Set global variables used by the makefiles.
49 * Source/cmake/OptionsGTK.cmake:
50 * Source/cmake/OptionsWPE.cmake:
52 2018-03-15 Ms2ger <Ms2ger@igalia.com>
54 [GTK][WPE] Enable service workers
55 https://bugs.webkit.org/show_bug.cgi?id=178576
57 Reviewed by Žan Doberšek.
59 * Source/cmake/OptionsGTK.cmake:
60 * Source/cmake/OptionsWPE.cmake:
62 2018-03-12 Yoav Weiss <yoav@yoav.ws>
64 Runtime flag for link prefetch and remove link subresource.
65 https://bugs.webkit.org/show_bug.cgi?id=183540
67 Reviewed by Chris Dumez.
69 Remove the LINK_PREFETCH build time flag.
71 * Source/cmake/OptionsWin.cmake:
72 * Source/cmake/WebKitFeatures.cmake:
73 * Source/cmake/tools/vsprops/FeatureDefines.props:
74 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
76 2018-03-12 Zan Dobersek <zdobersek@igalia.com>
78 Unreviewed. Unbreak the WPE layout testing that's been broken since
79 r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
80 HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
81 undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
82 for the WPE port as well.
84 * Source/cmake/OptionsWPE.cmake:
86 2018-03-12 Carlos Garcia Campos <cgarcia@igalia.com>
88 Unreviewed. Fix library version of JavaScriptCoreGTK.
90 * Source/cmake/OptionsGTK.cmake:
92 2018-03-09 Carlos Garcia Campos <cgarcia@igalia.com>
94 Unreviewed. Bump WebKitGTK+ version to 2.21.0.
96 * Source/cmake/OptionsGTK.cmake:
98 2018-03-08 Tim Horton <timothy_horton@apple.com>
100 Add a way to not build libwebrtc when building WebKit via Makefiles
101 https://bugs.webkit.org/show_bug.cgi?id=183437
102 <rdar://problem/38254840>
104 Reviewed by Dan Bernstein.
108 2018-03-05 Don Olmstead <don.olmstead@sony.com>
110 [CMake] Split JSC header copying into public and private targets
111 https://bugs.webkit.org/show_bug.cgi?id=183251
113 Reviewed by Konstantin Tokarev.
115 * Source/cmake/WebKitMacros.cmake:
117 2018-03-02 Don Olmstead <don.olmstead@sony.com>
119 Add clang-format configuration
120 https://bugs.webkit.org/show_bug.cgi?id=183302
122 Reviewed by Ryosuke Niwa.
124 * .clang-format: Added.
126 2018-03-01 Michael Catanzaro <mcatanzaro@igalia.com>
128 [CMake] configure failure for aarch64
129 https://bugs.webkit.org/show_bug.cgi?id=183268
131 Unreviewed build fix. This failure is caused by a simple typo.
133 * Source/cmake/OptionsCommon.cmake:
135 2018-02-26 Yousuke Kimoto <yousuke.kimoto@sony.com>
137 [WinCairo] WebKit2_C.h should be included for TestWebKit
138 https://bugs.webkit.org/show_bug.cgi?id=182682
140 Reviewed by Yusuke Suzuki.
142 Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
143 the wincairo webkit build.
145 * Source/cmake/OptionsWinCairo.cmake:
147 2018-02-26 Fujii Hironori <Hironori.Fujii@sony.com>
149 [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
150 https://bugs.webkit.org/show_bug.cgi?id=183116
152 Reviewed by Žan Doberšek.
154 OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
156 * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
158 2018-02-21 Don Olmstead <don.olmstead@sony.com>
160 [CMake] Expose HAVE macros globally
161 https://bugs.webkit.org/show_bug.cgi?id=183011
163 Reviewed by Michael Catanzaro.
165 * Source/cmake/OptionsCommon.cmake:
166 * Source/cmake/WebKitFeatures.cmake:
168 2018-02-21 Don Olmstead <don.olmstead@sony.com>
170 [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
171 https://bugs.webkit.org/show_bug.cgi?id=182883
173 Reviewed by Per Arne Vollan.
175 * Source/cmake/OptionsAppleWin.cmake:
176 * Source/cmake/OptionsWin.cmake:
177 * Source/cmake/OptionsWinCairo.cmake:
179 2018-02-21 Michael Catanzaro <mcatanzaro@igalia.com>
181 [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
182 https://bugs.webkit.org/show_bug.cgi?id=181825
184 Reviewed by Carlos Garcia Campos.
186 Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
188 * Source/cmake/FindUPowerGLib.cmake: Removed.
189 * Source/cmake/OptionsGTK.cmake:
191 2018-02-20 Adrian Perez de Castro <aperez@igalia.com>
193 [GTK][CMake] Support building with Enchant 2.x
194 https://bugs.webkit.org/show_bug.cgi?id=182933
196 Reviewed by Michael Catanzaro.
198 * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
199 pkg-config components, picking the first available for which the headers and
202 2018-02-19 Philippe Normand <pnormand@igalia.com>
204 [GStreamer] Playbin3 support
205 https://bugs.webkit.org/show_bug.cgi?id=182530
207 Reviewed by Xabier Rodriguez-Calvar.
209 * Source/cmake/GStreamerDefinitions.cmake: New
210 USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
211 very recent versions of GStreamer (1.14 at least) and is optional, for now.
213 2018-02-18 Philippe Normand <pnormand@igalia.com>
215 [GTK][WPE] Fullscreen video is broken
216 https://bugs.webkit.org/show_bug.cgi?id=182740
218 Reviewed by Michael Catanzaro.
220 * Source/cmake/WebKitFeatures.cmake: Enable the
221 VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
223 2018-02-16 Dean Jackson <dino@apple.com>
225 Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
226 https://bugs.webkit.org/show_bug.cgi?id=182894
228 Reviewed by Tim Horton.
230 Rename OPENGL_ES_2 to OPENGL_ES.
232 * Source/cmake/OptionsGTK.cmake:
233 * Source/cmake/OptionsWPE.cmake:
235 2018-02-09 Ross Kirsling <ross.kirsling@sony.com>
237 Simplify .gitignore's WebKitLibraries/win section.
238 https://bugs.webkit.org/show_bug.cgi?id=182618
240 Reviewed by Per Arne Vollan.
242 We need to update this section for WinCairoRequirements regardless, but
243 it never needed to be this longwinded in the first place.
247 2018-02-08 Fujii Hironori <Hironori.Fujii@sony.com>
249 [Meta][Win] Support ICU 59.1+
250 https://bugs.webkit.org/show_bug.cgi?id=181004
252 Reviewed by Alex Christensen.
254 ICU 59 changed the type of UChar from wchar_t to char16_t on
255 Windows. We need a lot of conversions between UChar* and wchar_t*
256 to call Windows API because it takes string as wchar_t*.
258 Fortunately, ICU is configurable to define UChar as wchar_t as
259 well as the prior ICU.
260 <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
262 * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
264 2018-02-08 Michael Catanzaro <mcatanzaro@igalia.com>
266 Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
267 https://bugs.webkit.org/show_bug.cgi?id=182400
268 <rdar://problem/37252242>
270 This is tested and works fine.
272 * Source/cmake/WebKitCompilerFlags.cmake:
274 2018-02-05 Yousuke Kimoto <yousuke.kimoto@sony.com>
276 [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
277 https://bugs.webkit.org/show_bug.cgi?id=182478
279 Reviewed by Alex Christensen.
281 * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
283 2018-02-05 Michael Catanzaro <mcatanzaro@igalia.com>
285 Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
286 https://bugs.webkit.org/show_bug.cgi?id=182400
287 <rdar://problem/37252242>
289 I failed to properly test a last-minute change.
291 * Source/cmake/WebKitCompilerFlags.cmake:
293 2018-02-05 Michael Catanzaro <mcatanzaro@igalia.com>
295 [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
296 https://bugs.webkit.org/show_bug.cgi?id=182400
298 Reviewed by Konstantin Tokarev.
300 * Source/cmake/OptionsGTK.cmake:
301 * Source/cmake/WebKitCompilerFlags.cmake:
303 2018-01-31 Michael Catanzaro <mcatanzaro@igalia.com>
306 https://bugs.webkit.org/show_bug.cgi?id=182314
308 Reviewed by Alex Christensen.
310 Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
311 build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
312 typographical adjustments.
316 2018-01-30 Sergio Villar Senin <svillar@igalia.com>
318 [WebVR][GTK][WPE] Exclude OpenVR from tarballs
319 https://bugs.webkit.org/show_bug.cgi?id=182284
321 Reviewed by Michael Catanzaro.
323 Added private build options for USE_OPENVR.
325 * Source/cmake/OptionsGTK.cmake:
326 * Source/cmake/OptionsWPE.cmake:
328 2018-01-30 Basuke Suzuki <Basuke.Suzuki@sony.com>
330 [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
331 https://bugs.webkit.org/show_bug.cgi?id=177202
333 Reviewed by Alex Christensen.
335 * Source/cmake/WebKitMacros.cmake:
337 2018-01-29 Jiewen Tan <jiewen_tan@apple.com>
339 [WebAuthN] Add a compile-time feature flag
340 https://bugs.webkit.org/show_bug.cgi?id=182211
341 <rdar://problem/36936365>
343 Reviewed by Brent Fulgham.
345 * Source/cmake/WebKitFeatures.cmake:
346 * Source/cmake/tools/vsprops/FeatureDefines.props:
347 * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
349 2018-01-18 Sergio Villar Senin <svillar@igalia.com>
351 [WebVR] Add OpenVR to the tree and to the build
352 https://bugs.webkit.org/show_bug.cgi?id=177298
354 Reviewed by Žan Doberšek.
356 * Source/CMakeLists.txt:
357 * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
358 * Source/cmake/OptionsWPE.cmake: Ditto.
360 2018-01-18 Dan Bernstein <mitz@apple.com>
362 [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
363 https://bugs.webkit.org/show_bug.cgi?id=181784
365 Reviewed by Anders Carlsson.
367 * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
368 * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
370 2018-01-17 Michael Catanzaro <mcatanzaro@igalia.com>
372 WEBKIT_FRAMEWORK should not modify file-global include directories
373 https://bugs.webkit.org/show_bug.cgi?id=181656
375 Reviewed by Konstantin Tokarev.
377 Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
379 * Source/cmake/WebKitMacros.cmake:
381 2018-01-17 Carlos Garcia Campos <cgarcia@igalia.com>
383 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
385 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
387 2018-01-15 Michael Catanzaro <mcatanzaro@igalia.com>
389 REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
390 https://bugs.webkit.org/show_bug.cgi?id=181438
391 <rdar://problem/36376724>
393 Reviewed by Carlos Garcia Campos.
395 Build JSC as a shared library.
397 Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
400 * Source/cmake/OptionsGTK.cmake:
401 * Source/cmake/WebKitCompilerFlags.cmake:
403 2018-01-11 Keith Miller <keith_miller@apple.com>
405 Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
406 https://bugs.webkit.org/show_bug.cgi?id=181573
408 Reviewed by Simon Fraser.
410 * Source/cmake/WebKitFeatures.cmake:
412 2018-01-10 Per Arne Vollan <pvollan@apple.com>
414 [Win] WebKitLegacy should be a dll, not a static library.
415 https://bugs.webkit.org/show_bug.cgi?id=181500
417 Reviewed by Alex Christensen.
419 Set WebKitLegacy library type to shared.
421 * Source/cmake/OptionsWin.cmake:
423 2018-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
425 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
427 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
429 2018-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
431 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
433 * Source/cmake/OptionsGTK.cmake: Bump version numbers.
435 2018-01-05 Fujii Hironori <Hironori.Fujii@sony.com>
437 REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
438 https://bugs.webkit.org/show_bug.cgi?id=181324
440 Reviewed by Konstantin Tokarev.
442 r226306 changed to use cmake -E copy to copy header files of
443 DerivedSources. This command copies files unconditionally, then
444 introduced unnecessary recompilations.
446 * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
448 2018-01-03 Ting-Wei Lan <lantw44@gmail.com>
450 Replace hard-coded paths in shebangs with #!/usr/bin/env
451 https://bugs.webkit.org/show_bug.cgi?id=181040
453 Reviewed by Alex Christensen.
455 * Source/cmake/tools/scripts/auto-version.pl:
456 * Source/cmake/tools/scripts/feature-defines.pl:
457 * Source/cmake/tools/scripts/version-stamp.pl:
459 == Rolled over to ChangeLog-2018-01-01 ==