Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
[WebKit-https.git] / ChangeLog
1 2018-04-12  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed, rolling out r230554.
4
5         The non-ASCII character in the filename causes issues with SVN
6
7         Reverted changeset:
8
9         "input.webkitEntries does not work as expected when folder
10         contains accented chars"
11         https://bugs.webkit.org/show_bug.cgi?id=184517
12         https://trac.webkit.org/changeset/230554
13
14 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
15
16         [WPE] Switch testing process to using WPEBackend-fdo
17         https://bugs.webkit.org/show_bug.cgi?id=184357
18
19         Reviewed by Carlos Alberto Lopez Perez.
20
21         * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake.
22
23 2018-04-11  Thibault Saunier  <tsaunier@igalia.com>
24
25         [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
26         https://bugs.webkit.org/show_bug.cgi?id=184498
27
28         Reviewed by Philippe Normand.
29
30         This is the same behaviour as with playbin itself.
31
32         Make sure to keep using "playbin" for MediaSource.
33
34         * Source/cmake/GStreamerDefinitions.cmake:
35
36 2018-04-09  Michael Catanzaro  <mcatanzaro@igalia.com>
37
38         [WPE] Use GNU install directories
39         https://bugs.webkit.org/show_bug.cgi?id=184377
40
41         Reviewed by Carlos Garcia Campos.
42
43         Notably, this means all the CMake arguments that distributors use to customize install
44         directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored.
45
46         * Source/cmake/OptionsCommon.cmake:
47         * Source/cmake/OptionsWPE.cmake:
48
49 2018-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
50
51         [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
52         https://bugs.webkit.org/show_bug.cgi?id=184127
53
54         Reviewed by Konstantin Tokarev.
55
56         Building TestWebKitLib on Windows causes a linkage error of
57         multiply defined symbols because TestWebKitLib links to
58         both WebCore and WebKit. TestWebKitLib explicitly links only with
59         WebKit, But, WebCore is propagated because WebKit links WebCore as
60         public.
61
62         * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES):
63         Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive.
64
65 2018-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
66
67         [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath()
68         https://bugs.webkit.org/show_bug.cgi?id=184381
69
70         Reviewed by Carlos Garcia Campos.
71
72         * Source/cmake/OptionsGTK.cmake:
73         * Source/cmake/OptionsWPE.cmake:
74
75 2018-04-02  Per Arne Vollan  <pvollan@apple.com>
76
77         Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
78         https://bugs.webkit.org/show_bug.cgi?id=184246
79         <rdar://problem/39116563>
80
81         Unreviewed build fix.
82
83         * Source/PlatformWin.cmake:
84
85 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
86
87         [GTK] Make libwebrtc backend buildable for GTK  port
88         https://bugs.webkit.org/show_bug.cgi?id=178860
89
90         Reviewed by Youenn Fablet.
91
92         * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
93         * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
94         allow compilation of the specific code.
95
96 2018-03-30  Daniel Bates  <dabates@apple.com>
97
98         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
99         https://bugs.webkit.org/show_bug.cgi?id=184161
100
101         Reviewed by Per Arne Vollan.
102
103         * ManualTests/DragInlinePDFImageDocument.html: Added.
104         * ManualTests/resources/simple.pdf: Added.
105
106 2018-03-28  Tim Horton  <timothy_horton@apple.com>
107
108         Make it possible to disable building the tools with Make
109         https://bugs.webkit.org/show_bug.cgi?id=184109
110
111         Reviewed by Simon Fraser.
112
113         * Makefile:
114
115 2018-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
116
117         [GTK][WPE] Add API to convert between DOM and JSCValue
118         https://bugs.webkit.org/show_bug.cgi?id=183448
119
120         Reviewed by Michael Catanzaro.
121
122         Define FORWARDING_HEADERS_WPE_DOM_DIR.
123
124         * Source/cmake/OptionsWPE.cmake:
125
126 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
127
128         [WPE] Enable WOFF2 support
129         https://bugs.webkit.org/show_bug.cgi?id=178158
130
131         Reviewed by Frédéric Wang.
132
133         * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
134
135 2018-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
136
137         [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
138         https://bugs.webkit.org/show_bug.cgi?id=164061
139
140         Reviewed by Michael Catanzaro.
141
142         Set global variables used by the makefiles.
143
144         * Source/cmake/OptionsGTK.cmake:
145         * Source/cmake/OptionsWPE.cmake:
146
147 2018-03-15  Ms2ger  <Ms2ger@igalia.com>
148
149         [GTK][WPE] Enable service workers
150         https://bugs.webkit.org/show_bug.cgi?id=178576
151
152         Reviewed by Žan Doberšek.
153
154         * Source/cmake/OptionsGTK.cmake:
155         * Source/cmake/OptionsWPE.cmake:
156
157 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
158
159         Runtime flag for link prefetch and remove link subresource.
160         https://bugs.webkit.org/show_bug.cgi?id=183540
161
162         Reviewed by Chris Dumez.
163
164         Remove the LINK_PREFETCH build time flag.
165
166         * Source/cmake/OptionsWin.cmake:
167         * Source/cmake/WebKitFeatures.cmake:
168         * Source/cmake/tools/vsprops/FeatureDefines.props:
169         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
170
171 2018-03-12  Zan Dobersek  <zdobersek@igalia.com>
172
173         Unreviewed. Unbreak the WPE layout testing that's been broken since
174         r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
175         HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
176         undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
177         for the WPE port as well.
178
179         * Source/cmake/OptionsWPE.cmake:
180
181 2018-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
182
183         Unreviewed. Fix library version of JavaScriptCoreGTK.
184
185         * Source/cmake/OptionsGTK.cmake:
186
187 2018-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
188
189         Unreviewed. Bump WebKitGTK+ version to 2.21.0.
190
191         * Source/cmake/OptionsGTK.cmake:
192
193 2018-03-08  Tim Horton  <timothy_horton@apple.com>
194
195         Add a way to not build libwebrtc when building WebKit via Makefiles
196         https://bugs.webkit.org/show_bug.cgi?id=183437
197         <rdar://problem/38254840>
198
199         Reviewed by Dan Bernstein.
200
201         * Source/Makefile:
202
203 2018-03-05  Don Olmstead  <don.olmstead@sony.com>
204
205         [CMake] Split JSC header copying into public and private targets
206         https://bugs.webkit.org/show_bug.cgi?id=183251
207
208         Reviewed by Konstantin Tokarev.
209
210         * Source/cmake/WebKitMacros.cmake:
211
212 2018-03-02  Don Olmstead  <don.olmstead@sony.com>
213
214         Add clang-format configuration
215         https://bugs.webkit.org/show_bug.cgi?id=183302
216
217         Reviewed by Ryosuke Niwa.
218
219         * .clang-format: Added.
220
221 2018-03-01  Michael Catanzaro  <mcatanzaro@igalia.com>
222
223         [CMake] configure failure for aarch64
224         https://bugs.webkit.org/show_bug.cgi?id=183268
225
226         Unreviewed build fix. This failure is caused by a simple typo.
227
228         * Source/cmake/OptionsCommon.cmake:
229
230 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
231
232         [WinCairo] WebKit2_C.h should be included for TestWebKit
233         https://bugs.webkit.org/show_bug.cgi?id=182682
234
235         Reviewed by Yusuke Suzuki.
236
237         Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
238         the wincairo webkit build.
239
240         * Source/cmake/OptionsWinCairo.cmake:
241
242 2018-02-26  Fujii Hironori  <Hironori.Fujii@sony.com>
243
244         [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
245         https://bugs.webkit.org/show_bug.cgi?id=183116
246
247         Reviewed by Žan Doberšek.
248
249         OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
250
251         * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
252
253 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
254
255         [CMake] Expose HAVE macros globally
256         https://bugs.webkit.org/show_bug.cgi?id=183011
257
258         Reviewed by Michael Catanzaro.
259
260         * Source/cmake/OptionsCommon.cmake:
261         * Source/cmake/WebKitFeatures.cmake:
262
263 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
264
265         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
266         https://bugs.webkit.org/show_bug.cgi?id=182883
267
268         Reviewed by Per Arne Vollan.
269
270         * Source/cmake/OptionsAppleWin.cmake:
271         * Source/cmake/OptionsWin.cmake:
272         * Source/cmake/OptionsWinCairo.cmake:
273
274 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
275
276         [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
277         https://bugs.webkit.org/show_bug.cgi?id=181825
278
279         Reviewed by Carlos Garcia Campos.
280
281         Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
282
283         * Source/cmake/FindUPowerGLib.cmake: Removed.
284         * Source/cmake/OptionsGTK.cmake:
285
286 2018-02-20  Adrian Perez de Castro  <aperez@igalia.com>
287
288         [GTK][CMake] Support building with Enchant 2.x
289         https://bugs.webkit.org/show_bug.cgi?id=182933
290
291         Reviewed by Michael Catanzaro.
292
293         * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
294         pkg-config components, picking the first available for which the headers and
295         library are usable.
296
297 2018-02-19  Philippe Normand  <pnormand@igalia.com>
298
299         [GStreamer] Playbin3 support
300         https://bugs.webkit.org/show_bug.cgi?id=182530
301
302         Reviewed by Xabier Rodriguez-Calvar.
303
304         * Source/cmake/GStreamerDefinitions.cmake: New
305         USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
306         very recent versions of GStreamer (1.14 at least) and is optional, for now.
307
308 2018-02-18  Philippe Normand  <pnormand@igalia.com>
309
310         [GTK][WPE] Fullscreen video is broken
311         https://bugs.webkit.org/show_bug.cgi?id=182740
312
313         Reviewed by Michael Catanzaro.
314
315         * Source/cmake/WebKitFeatures.cmake: Enable the
316         VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
317
318 2018-02-16  Dean Jackson  <dino@apple.com>
319
320         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
321         https://bugs.webkit.org/show_bug.cgi?id=182894
322
323         Reviewed by Tim Horton.
324
325         Rename OPENGL_ES_2 to OPENGL_ES.
326
327         * Source/cmake/OptionsGTK.cmake:
328         * Source/cmake/OptionsWPE.cmake:
329
330 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
331
332         Simplify .gitignore's WebKitLibraries/win section.
333         https://bugs.webkit.org/show_bug.cgi?id=182618
334
335         Reviewed by Per Arne Vollan.
336
337         We need to update this section for WinCairoRequirements regardless, but
338         it never needed to be this longwinded in the first place.
339
340         * .gitignore:
341
342 2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
343
344         [Meta][Win] Support ICU 59.1+
345         https://bugs.webkit.org/show_bug.cgi?id=181004
346
347         Reviewed by Alex Christensen.
348
349         ICU 59 changed the type of UChar from wchar_t to char16_t on
350         Windows. We need a lot of conversions between UChar* and wchar_t*
351         to call Windows API because it takes string as wchar_t*.
352
353         Fortunately, ICU is configurable to define UChar as wchar_t as
354         well as the prior ICU.
355         <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
356
357         * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
358
359 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
360
361         Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
362         https://bugs.webkit.org/show_bug.cgi?id=182400
363         <rdar://problem/37252242>
364
365         This is tested and works fine.
366
367         * Source/cmake/WebKitCompilerFlags.cmake:
368
369 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
370
371         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
372         https://bugs.webkit.org/show_bug.cgi?id=182478
373
374         Reviewed by Alex Christensen.
375
376         * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
377
378 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
379
380         Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
381         https://bugs.webkit.org/show_bug.cgi?id=182400
382         <rdar://problem/37252242>
383
384         I failed to properly test a last-minute change.
385
386         * Source/cmake/WebKitCompilerFlags.cmake:
387
388 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
389
390         [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
391         https://bugs.webkit.org/show_bug.cgi?id=182400
392
393         Reviewed by Konstantin Tokarev.
394
395         * Source/cmake/OptionsGTK.cmake:
396         * Source/cmake/WebKitCompilerFlags.cmake:
397
398 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
399
400         Update ReadMe.md
401         https://bugs.webkit.org/show_bug.cgi?id=182314
402
403         Reviewed by Alex Christensen.
404
405         Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
406         build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
407         typographical adjustments.
408
409         * ReadMe.md:
410
411 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
412
413         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
414         https://bugs.webkit.org/show_bug.cgi?id=182284
415
416         Reviewed by Michael Catanzaro.
417
418         Added private build options for USE_OPENVR.
419
420         * Source/cmake/OptionsGTK.cmake:
421         * Source/cmake/OptionsWPE.cmake:
422
423 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
424
425         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
426         https://bugs.webkit.org/show_bug.cgi?id=177202
427
428         Reviewed by Alex Christensen.
429
430         * Source/cmake/WebKitMacros.cmake:
431
432 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
433
434         [WebAuthN] Add a compile-time feature flag
435         https://bugs.webkit.org/show_bug.cgi?id=182211
436         <rdar://problem/36936365>
437
438         Reviewed by Brent Fulgham.
439
440         * Source/cmake/WebKitFeatures.cmake:
441         * Source/cmake/tools/vsprops/FeatureDefines.props:
442         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
443
444 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
445
446         [WebVR] Add OpenVR to the tree and to the build
447         https://bugs.webkit.org/show_bug.cgi?id=177298
448
449         Reviewed by Žan Doberšek.
450
451         * Source/CMakeLists.txt:
452         * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
453         * Source/cmake/OptionsWPE.cmake: Ditto.
454
455 2018-01-18  Dan Bernstein  <mitz@apple.com>
456
457         [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
458         https://bugs.webkit.org/show_bug.cgi?id=181784
459
460         Reviewed by Anders Carlsson.
461
462         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
463         * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
464
465 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
466
467         WEBKIT_FRAMEWORK should not modify file-global include directories
468         https://bugs.webkit.org/show_bug.cgi?id=181656
469
470         Reviewed by Konstantin Tokarev.
471
472         Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
473
474         * Source/cmake/WebKitMacros.cmake:
475
476 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
477
478         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
479
480         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
481
482 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
483
484         REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
485         https://bugs.webkit.org/show_bug.cgi?id=181438
486         <rdar://problem/36376724>
487
488         Reviewed by Carlos Garcia Campos.
489
490         Build JSC as a shared library.
491
492         Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
493         know how to fix.
494
495         * Source/cmake/OptionsGTK.cmake:
496         * Source/cmake/WebKitCompilerFlags.cmake:
497
498 2018-01-11  Keith Miller  <keith_miller@apple.com>
499
500         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
501         https://bugs.webkit.org/show_bug.cgi?id=181573
502
503         Reviewed by Simon Fraser.
504
505         * Source/cmake/WebKitFeatures.cmake:
506
507 2018-01-10  Per Arne Vollan  <pvollan@apple.com>
508
509         [Win] WebKitLegacy should be a dll, not a static library.
510         https://bugs.webkit.org/show_bug.cgi?id=181500
511
512         Reviewed by Alex Christensen.
513
514         Set WebKitLegacy library type to shared.
515
516         * Source/cmake/OptionsWin.cmake:
517
518 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
519
520         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
521
522         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
523
524 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
525
526         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
527
528         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
529
530 2018-01-05  Fujii Hironori  <Hironori.Fujii@sony.com>
531
532         REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
533         https://bugs.webkit.org/show_bug.cgi?id=181324
534
535         Reviewed by Konstantin Tokarev.
536
537         r226306 changed to use cmake -E copy to copy header files of
538         DerivedSources. This command copies files unconditionally, then
539         introduced unnecessary recompilations.
540
541         * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
542
543 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
544
545         Replace hard-coded paths in shebangs with #!/usr/bin/env
546         https://bugs.webkit.org/show_bug.cgi?id=181040
547
548         Reviewed by Alex Christensen.
549
550         * Source/cmake/tools/scripts/auto-version.pl:
551         * Source/cmake/tools/scripts/feature-defines.pl:
552         * Source/cmake/tools/scripts/version-stamp.pl:
553
554 == Rolled over to ChangeLog-2018-01-01 ==