REGRESSION (r230480): Cannot adjust photo position on LinkedIn's profile page
[WebKit-https.git] / ChangeLog
1 2018-06-06  Dan Bernstein  <mitz@apple.com>
2
3         [Xcode] Opt out of the New Build System
4         https://bugs.webkit.org/show_bug.cgi?id=186380
5
6         Reviewed by Alexey Proskuryakov.
7
8         * WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Use the Legacy Build System.
9
10 2018-06-06  Dan Bernstein  <mitz@apple.com>
11
12         Check in a file created by the Xcode 10 beta.
13
14         * WebKit.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist: Added.
15
16 2018-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
17
18         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.3 release.
19
20         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
21
22 2018-05-25  Adrian Perez de Castro  <aperez@igalia.com>
23
24         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.2 release.
25
26         * Source/cmake/OptionsWPE.cmake: Bump version numbers.
27
28 2018-05-22  Alberto Garcia  <berto@igalia.com>
29
30         [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
31         https://bugs.webkit.org/show_bug.cgi?id=182622
32         <rdar://problem/40292317>
33
34         Reviewed by Michael Catanzaro.
35
36         * Source/cmake/WebKitCompilerFlags.cmake:
37         Move the test to detect whether we need to link against libatomic
38         to a common CMake file so it can be used from both JavaScriptCore
39         and WebKit.
40
41 2018-05-22  Michael Catanzaro  <mcatanzaro@igalia.com>
42
43         Unreviewed, rolling out r231843.
44
45         Broke cross build
46
47         Reverted changeset:
48
49         "[CMake] Properly detect compiler flags, needed libs, and
50         fallbacks for usage of 64-bit atomic operations"
51         https://bugs.webkit.org/show_bug.cgi?id=182622
52         https://trac.webkit.org/changeset/231843
53
54 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
55
56         [WinCairo] Enable WebKit build by default
57         https://bugs.webkit.org/show_bug.cgi?id=185141
58
59         Reviewed by Per Arne Vollan.
60
61         * Source/cmake/OptionsWin.cmake: Disable
62         ENABLE_NETSCAPE_PLUGIN_API unconditionally for WinCairo port
63         because it builds both WK1 and WK2.
64         * Source/cmake/OptionsWinCairo.cmake: Turn ENABLE_WEBKIT on by default.
65         Remove BUILDING_WIN_CAIRO_WEBKIT macro.
66
67 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
68
69         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.2 release.
70
71         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
72
73 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
74
75         [WPE] Implement and enable FULLSCREEN_API
76         https://bugs.webkit.org/show_bug.cgi?id=185676
77
78         Reviewed by Žan Doberšek.
79
80         Remove the CMake option to disable this option for WPE.
81         This feature gets enabled now via Source/cmake/WebKitFeatures.cmake
82
83         * Source/cmake/OptionsWPE.cmake:
84
85 2018-05-16  Don Olmstead  <don.olmstead@sony.com>
86
87         [WinCairo] Update WinCairoRequirements
88         https://bugs.webkit.org/show_bug.cgi?id=185700
89
90         Reviewed by Per Arne Vollan.
91
92         * Source/cmake/OptionsWinCairo.cmake:
93
94 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
95
96         Add support for Intl NumberFormat formatToParts
97         https://bugs.webkit.org/show_bug.cgi?id=185375
98
99         Reviewed by Yusuke Suzuki.
100
101         Add flag for NumberFormat formatToParts.
102
103         * Source/cmake/OptionsJSCOnly.cmake:
104         * Source/cmake/WebKitFeatures.cmake:
105
106 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
107
108         [Win] Use C++17 in MSVC
109         https://bugs.webkit.org/show_bug.cgi?id=185232
110
111         Reviewed by Alex Christensen.
112
113         Use /std:c++17 option.
114
115         * Source/cmake/OptionsMSVC.cmake:
116
117 2018-05-16  Alberto Garcia  <berto@igalia.com>
118
119         [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations
120         https://bugs.webkit.org/show_bug.cgi?id=182622
121
122         Reviewed by Michael Catanzaro.
123
124         * Source/cmake/OptionsGTK.cmake:
125         * Source/cmake/OptionsJSCOnly.cmake:
126         * Source/cmake/OptionsWPE.cmake:
127         Enable THREADS_PREFER_PTHREAD_FLAG. This uses -pthread instead of
128         -lpthread, fixing the 64-bit RISC-V build of the GTK+ port due to
129         missing atomic primitives.
130
131         * Source/cmake/WebKitCompilerFlags.cmake:
132         Move the test to detect whether we need to link against libatomic
133         to a common CMake file so it can be used from both JavaScriptCore
134         and WebKit.
135
136 2018-05-14  Zan Dobersek  <zdobersek@igalia.com>
137
138         [GTK] REGRESSION(r231170) Build broken with Clang 5.0
139         https://bugs.webkit.org/show_bug.cgi?id=185198
140
141         Reviewed by Michael Catanzaro.
142
143         * Source/cmake/WebKitCompilerFlags.cmake: Fall back to the -std=c++1z
144         compiler flag if -std=c++17 is not supported. If that flag is not
145         supported either, bail with an error message.
146
147 2018-05-09  Jan Alexander Steffens  <jan.steffens@gmail.com>
148
149         [GTK] gtk-doc installation subdir duplicated
150         https://bugs.webkit.org/show_bug.cgi?id=185468
151
152         Reviewed by Carlos Garcia Campos.
153
154         The GTK docs are installed into a duplicated subdir,
155         e.g. /usr/share/doc/gtk-doc/html/webkit2gtk-4.0/webkit2gtk-4.0.
156
157         * Source/PlatformGTK.cmake:
158
159 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
160
161         Unreviewed. Bump WPE soname for good measure.
162
163         * Source/cmake/OptionsWPE.cmake:
164
165 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
166
167         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
168
169         * Source/cmake/OptionsWPE.cmake: Bump version numbers.
170
171 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
172
173         [JSC][GTK][JSCONLY] Use capstone disassembler
174         https://bugs.webkit.org/show_bug.cgi?id=185283
175
176         Reviewed by Michael Catanzaro.
177
178         * Source/CMakeLists.txt:
179         * Source/cmake/FindLLVM.cmake: Removed.
180         * Source/cmake/OptionsCommon.cmake:
181         * Source/cmake/OptionsGTK.cmake:
182         * Source/cmake/OptionsJSCOnly.cmake:
183         * Source/cmake/OptionsWPE.cmake:
184
185 2018-05-08  Valerie R Young  <valerie@bocoup.com>
186
187         test262/Runner.pm: create results dir for results of test262 run
188         https://bugs.webkit.org/show_bug.cgi?id=185392
189
190         Reviewed by Michael Saboff.
191
192         Remove reference to no longer existing files.
193
194         * .gitignore:
195
196 2018-05-07  Yusuke Suzuki  <utatane.tea@gmail.com>
197
198         [JSCOnly] Enable Intl.PluralRules
199         https://bugs.webkit.org/show_bug.cgi?id=185359
200
201         Reviewed by Daniel Bates.
202
203         Enable Intl.PluralRules because JSCOnly port enables features aggressively.
204
205         * Source/cmake/OptionsJSCOnly.cmake:
206
207 2018-05-07  Don Olmstead  <don.olmstead@sony.com>
208
209         [WinCairo] Disable plugin api when building modern WebKit
210         https://bugs.webkit.org/show_bug.cgi?id=185312
211
212         Reviewed by Michael Catanzaro.
213
214         * Source/cmake/OptionsWin.cmake:
215
216 2018-05-02  Valerie R Young  <valerie@bocoup.com>
217
218         test262/Runner.pm: save summary to file
219         https://bugs.webkit.org/show_bug.cgi?id=185200
220
221         Reviewed by Michael Saboff.
222
223         * .gitignore:
224
225 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
226
227         Auto save the results for Test262
228         https://bugs.webkit.org/show_bug.cgi?id=184926
229
230         Reviewed by Michael Saboff.
231
232 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
233
234         WebAssembly: add support for stream APIs - JavaScript API
235         https://bugs.webkit.org/show_bug.cgi?id=183442
236
237         Reviewed by Yusuke Suzuki and JF Bastien.
238
239         * Source/cmake/WebKitFeatures.cmake:
240
241 2018-04-30  JF Bastien  <jfbastien@apple.com>
242
243         Use some C++17 features
244         https://bugs.webkit.org/show_bug.cgi?id=185135
245
246         Reviewed by Alex Christensen.
247
248         As discussed here [0] let's move WebKit to a subset of C++17. We
249         now require GCC 6 [1] which means that, according to [2] we can
250         use the following C++17 language features (I removed some
251         uninteresting ones):
252
253          - New auto rules for direct-list-initialization
254          - static_assert with no message
255          - typename in a template template parameter
256          - Nested namespace definition
257          - Attributes for namespaces and enumerators
258          - u8 character literals
259          - Allow constant evaluation for all non-type template arguments
260          - Fold Expressions
261          - Unary fold expressions and empty parameter packs
262          - __has_include in preprocessor conditional
263          - Differing begin and end types in range-based for
264          - Improving std::pair and std::tuple
265
266         Consult the Tony Tables [3] to see before / after examples.
267
268         Of course we can use any library feature if we're willing to
269         import them to WTF (and they don't require language support).
270
271
272           [0]: https://lists.webkit.org/pipermail/webkit-dev/2018-March/029922.html
273           [1]: https://trac.webkit.org/changeset/231152/webkit
274           [2]: https://en.cppreference.com/w/cpp/compiler_support
275           [3]: https://github.com/tvaneerd/cpp17_in_TTs/blob/master/ALL_IN_ONE.md
276
277         * Source/cmake/WebKitCompilerFlags.cmake:
278
279 2018-04-29  Michael Catanzaro  <mcatanzaro@igalia.com>
280
281         [CMake] Require GCC 6
282         https://bugs.webkit.org/show_bug.cgi?id=184985
283
284         Reviewed by Alex Christensen.
285
286         Require it.
287
288         * CMakeLists.txt:
289
290 2018-04-26  Daniel Bates  <dabates@apple.com>
291
292         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
293         https://bugs.webkit.org/show_bug.cgi?id=184161
294         <rdar://problem/39051645>
295
296         Reviewed by Dan Bernstein.
297
298         * ManualTests/DragInlinePDFImageDocument.html: Added.
299         * ManualTests/resources/simple.pdf: Added.
300
301 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
302
303         [INTL] Implement Intl.PluralRules
304         https://bugs.webkit.org/show_bug.cgi?id=184312
305
306         Reviewed by JF Bastien.
307
308         Added Intl.PluralRules feature flag.
309
310         * Source/cmake/WebKitFeatures.cmake:
311
312 2018-04-26  Zan Dobersek  <zdobersek@igalia.com>
313
314         [GTK][WPE] Initial ASYNC_SCROLLING support
315         https://bugs.webkit.org/show_bug.cgi?id=184961
316
317         Reviewed by Carlos Garcia Campos.
318
319         * Source/cmake/OptionsGTK.cmake: Enable ASYNC_SCROLLING as a private option.
320         * Source/cmake/OptionsWPE.cmake: Ditto.
321
322 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
323
324         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
325         https://bugs.webkit.org/show_bug.cgi?id=184643
326
327         Reviewed by Žan Doberšek.
328
329         Update find modules to include the API versions.
330
331         * Source/cmake/FindWPEBackend-fdo.cmake:
332         * Source/cmake/FindWPEBackend.cmake:
333
334 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
335
336         [CMake] Some options should be marked as advanced
337         https://bugs.webkit.org/show_bug.cgi?id=184972
338
339         Reviewed by Konstantin Tokarev.
340
341         * Source/cmake/FindLibGcrypt.cmake:
342         * Source/cmake/FindWebP.cmake:
343
344 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
345
346         [GTK] Miscellaneous build cleanups
347         https://bugs.webkit.org/show_bug.cgi?id=184399
348
349         Reviewed by Žan Doberšek.
350
351         * Source/cmake/OptionsGTK.cmake:
352
353 2018-04-24  Leo Balter  <leonardo.balter@gmail.com>
354
355         Land test262 test results associated with Test262 runner
356         https://bugs.webkit.org/show_bug.cgi?id=184667
357
358         Reviewed by Michael Saboff.
359
360         * .gitignore: Ignore test262 results file.
361
362 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
363
364         [WPE] Remove libgbm dependency
365         https://bugs.webkit.org/show_bug.cgi?id=184906
366
367         Reviewed by Carlos Garcia Campos.
368
369         Remove the libgbm CMake search module. It's not necessary anymore
370         after r230562.
371
372         * Source/cmake/FindLibGBM.cmake: Removed.
373
374 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
375
376         [GTK] check target looks broken
377         https://bugs.webkit.org/show_bug.cgi?id=184407
378
379         Reviewed by Carlos Garcia Campos.
380
381         It's pretty clear that nobody has been using check for a long time.
382
383         We got rid of check-for-webkitdom-api-breaks a long time ago, when we stopped autogenerating
384         the DOM API, but it's still used in the check target. Fix this.
385
386         Also, the check target for some reason runs itself from the Source subdirectory of the
387         builddir, but the test script expects to be run from the toplevel build directory. Fix this
388         too.
389
390         Add VERBATIM for good measure.
391
392         * Source/PlatformGTK.cmake:
393
394 2018-04-20  Daniel Bates  <dabates@apple.com>
395
396         Unreviewed, rolling out r230117.
397
398         Broke find-in-page for PDFs
399
400         Reverted changeset:
401
402         "ASSERTION FAILED: ASSERT(!containsImage ||
403         MIMETypeRegistry::isSupportedImageResourceMIMEType([resource
404         MIMEType])) in -[NSPasteboard(WebExtras)
405         _web_writePromisedRTFDFromArchive:containsImage:]"
406         https://bugs.webkit.org/show_bug.cgi?id=184161
407         https://trac.webkit.org/changeset/230117
408
409 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
410
411         [GTK] Local cross references are broken in API documentation
412         https://bugs.webkit.org/show_bug.cgi?id=184771
413
414         Reviewed by Michael Catanzaro.
415
416         Update the documentation html paths and install the JSC GLib API too.
417
418         * Source/PlatformGTK.cmake:
419
420 2018-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
421
422         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.21.1 release.
423
424         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
425
426 2018-04-17  Zan Dobersek  <zdobersek@igalia.com>
427
428         [CMake] Add and enable the ENABLE_CSS_ANIMATIONS_LEVEL_2 feature define
429         https://bugs.webkit.org/show_bug.cgi?id=184681
430
431         Reviewed by Carlos Garcia Campos.
432
433         * Source/cmake/WebKitFeatures.cmake: Add the ENABLE_CSS_ANIMATIONS_LEVEL_2
434         feature define. Follow Cocoa ports and enable it by default.
435
436 2018-04-15  Michael Catanzaro  <mcatanzaro@igalia.com>
437
438         [WPE] Install files needed for WebKitWebExtensions
439         https://bugs.webkit.org/show_bug.cgi?id=179915
440
441         Reviewed by Žan Doberšek.
442
443         * Source/cmake/OptionsWPE.cmake:
444
445 2018-04-12  Ryan Haddad  <ryanhaddad@apple.com>
446
447         Unreviewed, rolling out r230554.
448
449         The non-ASCII character in the filename causes issues with SVN
450
451         Reverted changeset:
452
453         "input.webkitEntries does not work as expected when folder
454         contains accented chars"
455         https://bugs.webkit.org/show_bug.cgi?id=184517
456         https://trac.webkit.org/changeset/230554
457
458 2018-04-12  Zan Dobersek  <zdobersek@igalia.com>
459
460         [WPE] Switch testing process to using WPEBackend-fdo
461         https://bugs.webkit.org/show_bug.cgi?id=184357
462
463         Reviewed by Carlos Alberto Lopez Perez.
464
465         * Source/cmake/FindWPEBackend-fdo.cmake: Renamed from Source/cmake/FindWPEBackend-mesa.cmake.
466
467 2018-04-11  Thibault Saunier  <tsaunier@igalia.com>
468
469         [GStreamer] Use of playbin3 when USE_PLAYBIN3 environment variable is set
470         https://bugs.webkit.org/show_bug.cgi?id=184498
471
472         Reviewed by Philippe Normand.
473
474         This is the same behaviour as with playbin itself.
475
476         Make sure to keep using "playbin" for MediaSource.
477
478         * Source/cmake/GStreamerDefinitions.cmake:
479
480 2018-04-09  Michael Catanzaro  <mcatanzaro@igalia.com>
481
482         [WPE] Use GNU install directories
483         https://bugs.webkit.org/show_bug.cgi?id=184377
484
485         Reviewed by Carlos Garcia Campos.
486
487         Notably, this means all the CMake arguments that distributors use to customize install
488         directories (-DCMAKE_INSTALL_*DIR) will no longer be ignored.
489
490         * Source/cmake/OptionsCommon.cmake:
491         * Source/cmake/OptionsWPE.cmake:
492
493 2018-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
494
495         [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library
496         https://bugs.webkit.org/show_bug.cgi?id=184127
497
498         Reviewed by Konstantin Tokarev.
499
500         Building TestWebKitLib on Windows causes a linkage error of
501         multiply defined symbols because TestWebKitLib links to
502         both WebCore and WebKit. TestWebKitLib explicitly links only with
503         WebKit, But, WebCore is propagated because WebKit links WebCore as
504         public.
505
506         * Source/cmake/OptionsGTK.cmake (ADD_WHOLE_ARCHIVE_TO_LIBRARIES):
507         Do not wrap PRIVATE and PUBLIC keywords with -Wl,--whole-archive.
508
509 2018-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
510
511         [WPE][GTK] Remove applicationDirectoryPath() and sharedResourcePath()
512         https://bugs.webkit.org/show_bug.cgi?id=184381
513
514         Reviewed by Carlos Garcia Campos.
515
516         * Source/cmake/OptionsGTK.cmake:
517         * Source/cmake/OptionsWPE.cmake:
518
519 2018-04-02  Per Arne Vollan  <pvollan@apple.com>
520
521         Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
522         https://bugs.webkit.org/show_bug.cgi?id=184246
523         <rdar://problem/39116563>
524
525         Unreviewed build fix.
526
527         * Source/PlatformWin.cmake:
528
529 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
530
531         [GTK] Make libwebrtc backend buildable for GTK  port
532         https://bugs.webkit.org/show_bug.cgi?id=178860
533
534         Reviewed by Youenn Fablet.
535
536         * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
537         * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
538         allow compilation of the specific code.
539
540 2018-03-30  Daniel Bates  <dabates@apple.com>
541
542         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
543         https://bugs.webkit.org/show_bug.cgi?id=184161
544
545         Reviewed by Per Arne Vollan.
546
547         * ManualTests/DragInlinePDFImageDocument.html: Added.
548         * ManualTests/resources/simple.pdf: Added.
549
550 2018-03-28  Tim Horton  <timothy_horton@apple.com>
551
552         Make it possible to disable building the tools with Make
553         https://bugs.webkit.org/show_bug.cgi?id=184109
554
555         Reviewed by Simon Fraser.
556
557         * Makefile:
558
559 2018-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
560
561         [GTK][WPE] Add API to convert between DOM and JSCValue
562         https://bugs.webkit.org/show_bug.cgi?id=183448
563
564         Reviewed by Michael Catanzaro.
565
566         Define FORWARDING_HEADERS_WPE_DOM_DIR.
567
568         * Source/cmake/OptionsWPE.cmake:
569
570 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
571
572         [WPE] Enable WOFF2 support
573         https://bugs.webkit.org/show_bug.cgi?id=178158
574
575         Reviewed by Frédéric Wang.
576
577         * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
578
579 2018-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
580
581         [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
582         https://bugs.webkit.org/show_bug.cgi?id=164061
583
584         Reviewed by Michael Catanzaro.
585
586         Set global variables used by the makefiles.
587
588         * Source/cmake/OptionsGTK.cmake:
589         * Source/cmake/OptionsWPE.cmake:
590
591 2018-03-15  Ms2ger  <Ms2ger@igalia.com>
592
593         [GTK][WPE] Enable service workers
594         https://bugs.webkit.org/show_bug.cgi?id=178576
595
596         Reviewed by Žan Doberšek.
597
598         * Source/cmake/OptionsGTK.cmake:
599         * Source/cmake/OptionsWPE.cmake:
600
601 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
602
603         Runtime flag for link prefetch and remove link subresource.
604         https://bugs.webkit.org/show_bug.cgi?id=183540
605
606         Reviewed by Chris Dumez.
607
608         Remove the LINK_PREFETCH build time flag.
609
610         * Source/cmake/OptionsWin.cmake:
611         * Source/cmake/WebKitFeatures.cmake:
612         * Source/cmake/tools/vsprops/FeatureDefines.props:
613         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
614
615 2018-03-12  Zan Dobersek  <zdobersek@igalia.com>
616
617         Unreviewed. Unbreak the WPE layout testing that's been broken since
618         r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
619         HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
620         undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
621         for the WPE port as well.
622
623         * Source/cmake/OptionsWPE.cmake:
624
625 2018-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
626
627         Unreviewed. Fix library version of JavaScriptCoreGTK.
628
629         * Source/cmake/OptionsGTK.cmake:
630
631 2018-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
632
633         Unreviewed. Bump WebKitGTK+ version to 2.21.0.
634
635         * Source/cmake/OptionsGTK.cmake:
636
637 2018-03-08  Tim Horton  <timothy_horton@apple.com>
638
639         Add a way to not build libwebrtc when building WebKit via Makefiles
640         https://bugs.webkit.org/show_bug.cgi?id=183437
641         <rdar://problem/38254840>
642
643         Reviewed by Dan Bernstein.
644
645         * Source/Makefile:
646
647 2018-03-05  Don Olmstead  <don.olmstead@sony.com>
648
649         [CMake] Split JSC header copying into public and private targets
650         https://bugs.webkit.org/show_bug.cgi?id=183251
651
652         Reviewed by Konstantin Tokarev.
653
654         * Source/cmake/WebKitMacros.cmake:
655
656 2018-03-02  Don Olmstead  <don.olmstead@sony.com>
657
658         Add clang-format configuration
659         https://bugs.webkit.org/show_bug.cgi?id=183302
660
661         Reviewed by Ryosuke Niwa.
662
663         * .clang-format: Added.
664
665 2018-03-01  Michael Catanzaro  <mcatanzaro@igalia.com>
666
667         [CMake] configure failure for aarch64
668         https://bugs.webkit.org/show_bug.cgi?id=183268
669
670         Unreviewed build fix. This failure is caused by a simple typo.
671
672         * Source/cmake/OptionsCommon.cmake:
673
674 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
675
676         [WinCairo] WebKit2_C.h should be included for TestWebKit
677         https://bugs.webkit.org/show_bug.cgi?id=182682
678
679         Reviewed by Yusuke Suzuki.
680
681         Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
682         the wincairo webkit build.
683
684         * Source/cmake/OptionsWinCairo.cmake:
685
686 2018-02-26  Fujii Hironori  <Hironori.Fujii@sony.com>
687
688         [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
689         https://bugs.webkit.org/show_bug.cgi?id=183116
690
691         Reviewed by Žan Doberšek.
692
693         OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
694
695         * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
696
697 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
698
699         [CMake] Expose HAVE macros globally
700         https://bugs.webkit.org/show_bug.cgi?id=183011
701
702         Reviewed by Michael Catanzaro.
703
704         * Source/cmake/OptionsCommon.cmake:
705         * Source/cmake/WebKitFeatures.cmake:
706
707 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
708
709         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
710         https://bugs.webkit.org/show_bug.cgi?id=182883
711
712         Reviewed by Per Arne Vollan.
713
714         * Source/cmake/OptionsAppleWin.cmake:
715         * Source/cmake/OptionsWin.cmake:
716         * Source/cmake/OptionsWinCairo.cmake:
717
718 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
719
720         [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
721         https://bugs.webkit.org/show_bug.cgi?id=181825
722
723         Reviewed by Carlos Garcia Campos.
724
725         Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
726
727         * Source/cmake/FindUPowerGLib.cmake: Removed.
728         * Source/cmake/OptionsGTK.cmake:
729
730 2018-02-20  Adrian Perez de Castro  <aperez@igalia.com>
731
732         [GTK][CMake] Support building with Enchant 2.x
733         https://bugs.webkit.org/show_bug.cgi?id=182933
734
735         Reviewed by Michael Catanzaro.
736
737         * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
738         pkg-config components, picking the first available for which the headers and
739         library are usable.
740
741 2018-02-19  Philippe Normand  <pnormand@igalia.com>
742
743         [GStreamer] Playbin3 support
744         https://bugs.webkit.org/show_bug.cgi?id=182530
745
746         Reviewed by Xabier Rodriguez-Calvar.
747
748         * Source/cmake/GStreamerDefinitions.cmake: New
749         USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
750         very recent versions of GStreamer (1.14 at least) and is optional, for now.
751
752 2018-02-18  Philippe Normand  <pnormand@igalia.com>
753
754         [GTK][WPE] Fullscreen video is broken
755         https://bugs.webkit.org/show_bug.cgi?id=182740
756
757         Reviewed by Michael Catanzaro.
758
759         * Source/cmake/WebKitFeatures.cmake: Enable the
760         VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
761
762 2018-02-16  Dean Jackson  <dino@apple.com>
763
764         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
765         https://bugs.webkit.org/show_bug.cgi?id=182894
766
767         Reviewed by Tim Horton.
768
769         Rename OPENGL_ES_2 to OPENGL_ES.
770
771         * Source/cmake/OptionsGTK.cmake:
772         * Source/cmake/OptionsWPE.cmake:
773
774 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
775
776         Simplify .gitignore's WebKitLibraries/win section.
777         https://bugs.webkit.org/show_bug.cgi?id=182618
778
779         Reviewed by Per Arne Vollan.
780
781         We need to update this section for WinCairoRequirements regardless, but
782         it never needed to be this longwinded in the first place.
783
784         * .gitignore:
785
786 2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
787
788         [Meta][Win] Support ICU 59.1+
789         https://bugs.webkit.org/show_bug.cgi?id=181004
790
791         Reviewed by Alex Christensen.
792
793         ICU 59 changed the type of UChar from wchar_t to char16_t on
794         Windows. We need a lot of conversions between UChar* and wchar_t*
795         to call Windows API because it takes string as wchar_t*.
796
797         Fortunately, ICU is configurable to define UChar as wchar_t as
798         well as the prior ICU.
799         <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
800
801         * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
802
803 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
804
805         Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
806         https://bugs.webkit.org/show_bug.cgi?id=182400
807         <rdar://problem/37252242>
808
809         This is tested and works fine.
810
811         * Source/cmake/WebKitCompilerFlags.cmake:
812
813 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
814
815         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
816         https://bugs.webkit.org/show_bug.cgi?id=182478
817
818         Reviewed by Alex Christensen.
819
820         * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
821
822 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
823
824         Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
825         https://bugs.webkit.org/show_bug.cgi?id=182400
826         <rdar://problem/37252242>
827
828         I failed to properly test a last-minute change.
829
830         * Source/cmake/WebKitCompilerFlags.cmake:
831
832 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
833
834         [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
835         https://bugs.webkit.org/show_bug.cgi?id=182400
836
837         Reviewed by Konstantin Tokarev.
838
839         * Source/cmake/OptionsGTK.cmake:
840         * Source/cmake/WebKitCompilerFlags.cmake:
841
842 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
843
844         Update ReadMe.md
845         https://bugs.webkit.org/show_bug.cgi?id=182314
846
847         Reviewed by Alex Christensen.
848
849         Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
850         build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
851         typographical adjustments.
852
853         * ReadMe.md:
854
855 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
856
857         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
858         https://bugs.webkit.org/show_bug.cgi?id=182284
859
860         Reviewed by Michael Catanzaro.
861
862         Added private build options for USE_OPENVR.
863
864         * Source/cmake/OptionsGTK.cmake:
865         * Source/cmake/OptionsWPE.cmake:
866
867 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
868
869         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
870         https://bugs.webkit.org/show_bug.cgi?id=177202
871
872         Reviewed by Alex Christensen.
873
874         * Source/cmake/WebKitMacros.cmake:
875
876 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
877
878         [WebAuthN] Add a compile-time feature flag
879         https://bugs.webkit.org/show_bug.cgi?id=182211
880         <rdar://problem/36936365>
881
882         Reviewed by Brent Fulgham.
883
884         * Source/cmake/WebKitFeatures.cmake:
885         * Source/cmake/tools/vsprops/FeatureDefines.props:
886         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
887
888 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
889
890         [WebVR] Add OpenVR to the tree and to the build
891         https://bugs.webkit.org/show_bug.cgi?id=177298
892
893         Reviewed by Žan Doberšek.
894
895         * Source/CMakeLists.txt:
896         * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
897         * Source/cmake/OptionsWPE.cmake: Ditto.
898
899 2018-01-18  Dan Bernstein  <mitz@apple.com>
900
901         [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
902         https://bugs.webkit.org/show_bug.cgi?id=181784
903
904         Reviewed by Anders Carlsson.
905
906         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
907         * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
908
909 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
910
911         WEBKIT_FRAMEWORK should not modify file-global include directories
912         https://bugs.webkit.org/show_bug.cgi?id=181656
913
914         Reviewed by Konstantin Tokarev.
915
916         Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
917
918         * Source/cmake/WebKitMacros.cmake:
919
920 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
921
922         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
923
924         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
925
926 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
927
928         REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
929         https://bugs.webkit.org/show_bug.cgi?id=181438
930         <rdar://problem/36376724>
931
932         Reviewed by Carlos Garcia Campos.
933
934         Build JSC as a shared library.
935
936         Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
937         know how to fix.
938
939         * Source/cmake/OptionsGTK.cmake:
940         * Source/cmake/WebKitCompilerFlags.cmake:
941
942 2018-01-11  Keith Miller  <keith_miller@apple.com>
943
944         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
945         https://bugs.webkit.org/show_bug.cgi?id=181573
946
947         Reviewed by Simon Fraser.
948
949         * Source/cmake/WebKitFeatures.cmake:
950
951 2018-01-10  Per Arne Vollan  <pvollan@apple.com>
952
953         [Win] WebKitLegacy should be a dll, not a static library.
954         https://bugs.webkit.org/show_bug.cgi?id=181500
955
956         Reviewed by Alex Christensen.
957
958         Set WebKitLegacy library type to shared.
959
960         * Source/cmake/OptionsWin.cmake:
961
962 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
963
964         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
965
966         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
967
968 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
969
970         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
971
972         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
973
974 2018-01-05  Fujii Hironori  <Hironori.Fujii@sony.com>
975
976         REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
977         https://bugs.webkit.org/show_bug.cgi?id=181324
978
979         Reviewed by Konstantin Tokarev.
980
981         r226306 changed to use cmake -E copy to copy header files of
982         DerivedSources. This command copies files unconditionally, then
983         introduced unnecessary recompilations.
984
985         * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
986
987 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
988
989         Replace hard-coded paths in shebangs with #!/usr/bin/env
990         https://bugs.webkit.org/show_bug.cgi?id=181040
991
992         Reviewed by Alex Christensen.
993
994         * Source/cmake/tools/scripts/auto-version.pl:
995         * Source/cmake/tools/scripts/feature-defines.pl:
996         * Source/cmake/tools/scripts/version-stamp.pl:
997
998 == Rolled over to ChangeLog-2018-01-01 ==