[GTK][WPE] Test gardening
[WebKit-https.git] / ChangeLog
1 2017-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release.
4
5         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
6
7 2017-12-12  Don Olmstead  <don.olmstead@sony.com>
8
9         [WinCairo] Enable WebP support
10         https://bugs.webkit.org/show_bug.cgi?id=179908
11
12         Reviewed by Konstantin Tokarev.
13
14         * Source/cmake/OptionsWinCairo.cmake:
15
16 2017-12-08  Fujii Hironori  <Hironori.Fujii@sony.com>
17
18         [WinCairo][Ninja] Incremental build failure of WTF
19         https://bugs.webkit.org/show_bug.cgi?id=180521
20
21         Reviewed by Konstantin Tokarev.
22
23         WTF included its forwarding headers in Windows ports. The
24         directory DerivedSources/ForwardingHeaders shouldn't be a include
25         path for WTF.
26
27         * Source/cmake/OptionsWin.cmake:
28         Removed DerivedSources/ForwardingHeaders and DerivedSources from include paths.
29
30 2017-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
31
32         [WPE][GTK] Freeze WebKit version in user agent
33         https://bugs.webkit.org/show_bug.cgi?id=180475
34
35         Reviewed by Carlos Garcia Campos.
36
37         * Source/cmake/OptionsGTK.cmake:
38         * Source/cmake/OptionsWPE.cmake:
39
40 2017-12-05  Stephan Szabo  <stephan.szabo@sony.com>
41
42         Switch windows build to Visual Studio 2017
43         https://bugs.webkit.org/show_bug.cgi?id=172412
44
45         Reviewed by Per Arne Vollan.
46
47         * Source/cmake/OptionsMSVC.cmake:
48
49 2017-12-01  Konstantin Tokarev  <annulen@yandex.ru>
50
51         [cmake] Make description of ENABLE_DRAG_SUPPORT more informative
52         https://bugs.webkit.org/show_bug.cgi?id=180266
53
54         Reviewed by Michael Catanzaro.
55
56         When disabled, it also disables selection of text with dragging, and this
57         comes as a surprise for many people.
58
59         * Source/cmake/WebKitFeatures.cmake:
60
61 2017-12-01  Michael Catanzaro  <mcatanzaro@igalia.com>
62
63         [GStreamer] Fix USE_GSTREAMER_GL check for GStreamer 1.10
64         https://bugs.webkit.org/show_bug.cgi?id=180256
65
66         Reviewed by Carlos Alberto Lopez Perez.
67
68         It's not safe to change the value of build options after WEBKIT_OPTION_END, since it breaks
69         the option dependency checker. I don't think that actually hurts anything in this case, but
70         let's not encourage bad practice. Also, it's not good for features to be secretly disabled.
71         Nobody reads CMake output unless there is a fatal error. Failing the build at the CMake
72         stage lets distributors know that a feature will be missing. And of course, it's still
73         possible to disable USE_GSTREAMER_GL to avoid the increased GStreamer requirement.
74
75         * Source/cmake/GStreamerChecks.cmake:
76
77 2017-12-01  Michael Catanzaro  <mcatanzaro@igalia.com>
78
79         [GTK] [MSE] Turn MSE on by default
80         https://bugs.webkit.org/show_bug.cgi?id=167107
81
82         Reviewed by Carlos Alberto Lopez Perez.
83
84         Turn on the ENABLE_MEDIA_SOURCE build option. Fail the build if GStreamer 1.8 is not
85         installed and ENABLE_MEDIA_SOURCE has not been disabled.
86
87         * Source/cmake/GStreamerChecks.cmake:
88         * Source/cmake/GStreamerDefinitions.cmake:
89         * Source/cmake/OptionsGTK.cmake:
90         * Source/cmake/OptionsWPE.cmake:
91
92 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
93
94         Make LegacyCustomProtocolManager optional for network process
95         https://bugs.webkit.org/show_bug.cgi?id=176230
96
97         Reviewed by Alex Christensen.
98
99         * Source/cmake/OptionsWin.cmake:
100         * Source/cmake/WebKitFeatures.cmake:
101
102 2017-11-29  Alex Christensen  <achristensen@webkit.org>
103
104         Fix Mac CMake build.
105
106         * Source/cmake/OptionsMac.cmake:
107
108 2017-11-28  Michael Catanzaro  <mcatanzaro@igalia.com>
109
110         REGRESSION(r225098): [WPE] Some features have changed of value (70 new failures)
111         https://bugs.webkit.org/show_bug.cgi?id=180004
112
113         Reviewed by Alex Christensen.
114
115         Turn on ENABLE_ENCRYPTED_MEDIA and ENABLE_WEBGL2 when building with
116         ENABLE_EXPERIMENTAL_FEATURES. Also, let's stop turning off ENABLE_USERSELECT_ALL, as I doubt
117         there's any good reason for that.
118
119         * Source/cmake/OptionsWPE.cmake:
120
121 2017-11-27  Don Olmstead  <don.olmstead@sony.com>
122
123         [CMake][Win] Conditionally select DLL CRT or static CRT
124         https://bugs.webkit.org/show_bug.cgi?id=170594
125
126         Reviewed by Alex Christensen.
127
128         * Source/cmake/OptionsAppleWin.cmake:
129         * Source/cmake/OptionsMSVC.cmake:
130
131 2017-11-27  Adrian Perez de Castro  <aperez@igalia.com>
132
133         [CMake] Values of CMAKE_BUILD_TYPE from toolchain file are ignored
134         https://bugs.webkit.org/show_bug.cgi?id=179971
135
136         Reviewed by Carlos Alberto Lopez Perez.
137
138         * CMakeLists.txt: Call project() first, as it loads the toolchain
139         file, so that's done before checking CMAKE_BUILD_TYPE.
140
141 2017-11-22  Michael Catanzaro  <mcatanzaro@igalia.com>
142
143         Sanity-check feature defaults in WebKitFeatures.cmake
144         https://bugs.webkit.org/show_bug.cgi?id=179095
145
146         Reviewed by Konstantin Tokarev.
147
148         Change the default value of some features in WebKitFeatures.cmake to reduce the number of
149         Options*.cmake files the feature's default value must be overridden in.
150
151         Remove feature definitions where they are redundant with the definition in
152         WebKitFeatures.cmake, particluarly in OptionsMac.cmake.
153
154         This commit should not include any functional changes. It just aims to reduce the total
155         number of times we need to call WEBKIT_OPTION_DEFAULT_PORT_VALUE.
156
157         * Source/cmake/OptionsGTK.cmake:
158         * Source/cmake/OptionsJSCOnly.cmake:
159         * Source/cmake/OptionsMac.cmake:
160         * Source/cmake/OptionsWPE.cmake:
161         * Source/cmake/OptionsWin.cmake:
162         * Source/cmake/WebKitFeatures.cmake:
163
164 2017-11-22  Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
165
166         Remove build-webkit's notion of feature flags having a default value
167         https://bugs.webkit.org/show_bug.cgi?id=177338
168
169         Reviewed by Carlos Alberto Lopez Perez.
170
171         Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.
172
173         * Source/cmake/OptionsGTK.cmake:
174         * Source/cmake/WebKitFeatures.cmake:
175
176 2017-11-21  Zan Dobersek  <zdobersek@igalia.com>
177
178         Drop ENABLE_IMAGE_DECODER_DOWN_SAMPLING code
179         https://bugs.webkit.org/show_bug.cgi?id=179921
180
181         Reviewed by Carlos Garcia Campos.
182
183         * Source/cmake/WebKitFeatures.cmake: Remove the CMake option that
184         enabled IMAGE_DECODER_DOWN_SAMPLING code.
185
186 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
187
188         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.2 release.
189
190         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
191
192 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
193
194         Remove ENABLE_ALLINONE_BUILD option
195         https://bugs.webkit.org/show_bug.cgi?id=179823
196
197         Reviewed by Darin Adler.
198
199         * Source/cmake/OptionsWin.cmake:
200         * Source/cmake/WebKitFeatures.cmake:
201
202 2017-11-19  Tim Horton  <timothy_horton@apple.com>
203
204         Remove unused TOUCH_ICON_LOADING feature flag
205         https://bugs.webkit.org/show_bug.cgi?id=179873
206
207         Reviewed by Simon Fraser.
208
209         * Source/cmake/OptionsMac.cmake:
210         * Source/cmake/WebKitFeatures.cmake:
211
212 2017-11-19  Yusuke Suzuki  <utatane.tea@gmail.com>
213
214         Add CPU(UNKNOWN) to cover all the unknown CPU types
215         https://bugs.webkit.org/show_bug.cgi?id=179243
216
217         Reviewed by JF Bastien.
218
219         Drop SH4, S390, and S390X explicit support. They are handled as CPU(UNKNOWN).
220
221         * CMakeLists.txt:
222
223 2017-11-19  Tim Horton  <timothy_horton@apple.com>
224
225         Remove unused LEGACY_VENDOR_PREFIXES feature flag
226         https://bugs.webkit.org/show_bug.cgi?id=179872
227
228         Reviewed by Darin Adler.
229
230         * Source/cmake/OptionsMac.cmake:
231         * Source/cmake/OptionsWin.cmake:
232         * Source/cmake/WebKitFeatures.cmake:
233
234 2017-11-16  Don Olmstead  <don.olmstead@sony.com>
235
236         [WinCairo] Update WinCairoRequirements
237         https://bugs.webkit.org/show_bug.cgi?id=179790
238
239         Reviewed by Alex Christensen.
240
241         * Source/cmake/OptionsWinCairo.cmake:
242
243 2017-11-16  Daniel Bates  <dabates@apple.com>
244
245         Add feature define for alternative presentation button element
246         https://bugs.webkit.org/show_bug.cgi?id=179692
247         Part of <rdar://problem/34917108>
248
249         Reviewed by Andy Estes.
250
251         Only enabled on Cocoa platforms by default.
252
253         * Source/cmake/OptionsMac.cmake:
254         * Source/cmake/WebKitFeatures.cmake:
255         * Source/cmake/tools/vsprops/FeatureDefines.props:
256         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
257
258 2017-11-16  Michael Catanzaro  <mcatanzaro@igalia.com>
259
260         [WPE] Expose ENABLE_JIT and USE_SYSTEM_MALLOC options
261         https://bugs.webkit.org/show_bug.cgi?id=179730
262
263         Reviewed by Carlos Alberto Lopez Perez.
264
265         * Source/cmake/OptionsWPE.cmake:
266
267 2017-11-15  Carlos Garcia Campos  <cgarcia@igalia.com>
268
269         [WPE] Add initial support for WebDriver
270         https://bugs.webkit.org/show_bug.cgi?id=179727
271
272         Reviewed by Michael Catanzaro.
273
274         Enable WebDriver by default in WPE.
275
276         * Source/cmake/OptionsWPE.cmake:
277
278 2017-11-15  Keith Miller  <keith_miller@apple.com>
279
280         Unreviewed, sort async iteration feature.
281
282         * Source/cmake/WebKitFeatures.cmake:
283
284 2017-11-15  Keith Miller  <keith_miller@apple.com>
285
286         REGRESSION(r224787): [Linux] Introduced 144 GTK/WPE JS test failures
287         https://bugs.webkit.org/show_bug.cgi?id=179704
288
289         Reviewed by Yusuke Suzuki.
290
291         Add feature flag for Async iteration.
292
293         * Source/cmake/WebKitFeatures.cmake:
294
295 2017-11-13  Michael Catanzaro  <mcatanzaro@igalia.com>
296
297         [GTK] Require woff2 1.0.2 and drop direct brotli dependency
298         https://bugs.webkit.org/show_bug.cgi?id=179630
299
300         Reviewed by Frédéric Wang.
301
302         * Source/cmake/FindBrotliDec.cmake: Removed.
303         * Source/cmake/OptionsGTK.cmake:
304
305 2017-11-09  Michael Catanzaro  <mcatanzaro@igalia.com>
306
307         [WPE] Use linker script to control exported symbols
308         https://bugs.webkit.org/show_bug.cgi?id=179358
309
310         Reviewed by Carlos Alberto Lopez Perez.
311
312         The C API is being inadvertently exported because it's marked as WEBKIT_EXPORT in the header
313         files. But of course it should only be exported in DEVELOPER_MODE, where it's needed for
314         WebKitTestRunner. Use (almost) the same linker version script as GTK to fix this. It's
315         slightly different because WPE does not have WebKitPluginProcess.
316
317         This also reduces binary size of libWPEWebKit.so in debug mode from 615 MB down to 497 MB.
318         (Haven't checked release mode.)
319
320         * Source/cmake/OptionsWPE.cmake:
321         * Source/cmake/wpesymbols.filter: Added.
322
323 2017-11-08  Michael Catanzaro  <mcatanzaro@igalia.com>
324
325         [WPE] Turn on ENABLE_INDEXED_DATABASE_IN_WORKERS
326         https://bugs.webkit.org/show_bug.cgi?id=179094
327
328         Reviewed by Carlos Alberto Lopez Perez.
329
330         * Source/cmake/OptionsWPE.cmake:
331
332 2017-11-07  Michael Catanzaro  <mcatanzaro@igalia.com>
333
334         [WPE] Turn on ENABLE_MEDIA_SOURCE
335         https://bugs.webkit.org/show_bug.cgi?id=179093
336
337         Reviewed by Carlos Alberto Lopez Perez.
338
339         * Source/cmake/OptionsWPE.cmake:
340
341 2017-11-06  Michael Catanzaro  <mcatanzaro@igalia.com>
342
343         Unreviewed, fix WPE build after r224492
344         https://bugs.webkit.org/show_bug.cgi?id=179009
345
346         * Source/cmake/OptionsWPE.cmake:
347
348 2017-11-06  Michael Catanzaro  <mcatanzaro@igalia.com>
349
350         [WPE] Clean up OptionsWPE.cmake
351         https://bugs.webkit.org/show_bug.cgi?id=179009
352
353         Reviewed by Žan Doberšek.
354
355         * Source/cmake/OptionsWPE.cmake:
356
357 2017-11-06  Michael Catanzaro  <mcatanzaro@igalia.com>
358
359         [WPE][GTK] Always use SET_AND_EXPOSE_TO_BUILD to set build variables
360         https://bugs.webkit.org/show_bug.cgi?id=179038
361
362         Reviewed by Žan Doberšek.
363
364         * Source/cmake/OptionsGTK.cmake:
365         * Source/cmake/OptionsWPE.cmake:
366
367 2017-11-03  Michael Catanzaro  <mcatanzaro@igalia.com>
368
369         [WPE][GTK] Avoid duplicating code for dist and distcheck targets
370         https://bugs.webkit.org/show_bug.cgi?id=179154
371
372         Reviewed by Carlos Garcia Campos.
373
374         This commit just reduces some CMake code duplication between GTK and WPE.
375
376         * Source/PlatformGTK.cmake:
377         * Source/PlatformWPE.cmake:
378         * Source/cmake/WebKitDist.cmake: Added.
379
380 2017-11-02  Tim Horton  <timothy_horton@apple.com>
381
382         Reduce duplication in the toplevel Makefile
383         https://bugs.webkit.org/show_bug.cgi?id=179204
384
385         Unreviewed build fix.
386
387         * Source/Makefile:
388         Take three. An empty SDKROOT should be like Mac (and build all the things).
389
390 2017-11-02  Tim Horton  <timothy_horton@apple.com>
391
392         Reduce duplication in the toplevel Makefile
393         https://bugs.webkit.org/show_bug.cgi?id=179204
394
395         * Source/Makefile:
396         Address some post-landing review comments to keep the order of the MODULES correct.
397
398 2017-11-02  Tim Horton  <timothy_horton@apple.com>
399
400         Reduce duplication in the toplevel Makefile
401         https://bugs.webkit.org/show_bug.cgi?id=179204
402
403         Reviewed by Simon Fraser.
404
405         * Source/Makefile:
406         Make MODULES additive instead of completely repeated, and only build
407         libwebrtc where it's needed.
408
409 2017-11-02  Alberto Garcia  <berto@igalia.com>
410
411         Unreviewed, fix typos in library names for the GTK+ port.
412
413         * Source/cmake/OptionsGTK.cmake:
414
415 2017-10-31  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.1 release.
418
419         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
420
421 2017-10-31  Carlos Garcia Campos  <cgarcia@igalia.com>
422
423         Unreviewed. Fix GTK+/WPE make distcheck.
424
425         * CMakeLists.txt: Only include PerformanceTests directory to the build for GTK+ and WPE ports when developer
426         mode is enabled.
427
428 2017-10-26  Adrian Perez de Castro  <aperez@igalia.com>
429
430         [WPE] Use proper shared object versioning for libWPEWebKit.so
431         https://bugs.webkit.org/show_bug.cgi?id=178878
432
433         Reviewed by Michael Catanzaro.
434
435         Move the CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE() to a new CMake include file,
436         and use it both for the GTK+ and WPE ports. Also add a SET_PROJECT_VERSION() macro to
437         unify setting the PROJECT_VERSION* family of variables.
438
439         * Source/cmake/OptionsGTK.cmake: Use the common macros imported from VersioningUtils.cmake.
440         * Source/cmake/OptionsWPE.cmake: Properly assign a shared object version to libWPEWebKit.so,
441         using the common macros from VersioningUtils.cmake.
442         * Source/cmake/VersioningUtils.cmake: Added.
443
444 2017-10-26  Adrian Perez de Castro  <aperez@igalia.com>
445
446         [GTK] WebKit library .so version is not being set correctly
447         https://bugs.webkit.org/show_bug.cgi?id=178873
448
449         Reviewed by Michael Catanzaro.
450
451         * Source/cmake/OptionsGTK.cmake: Adjust name of the target for which the .so version gets calculated.
452
453 2017-10-24  Stephan Szabo  <stephan.szabo@sony.com>
454
455         [Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests
456         https://bugs.webkit.org/show_bug.cgi?id=177279
457
458         Reviewed by Yusuke Suzuki.
459
460         * Source/cmake/OptionsJSCOnly.cmake:
461
462 2017-10-21  Tim Horton  <timothy_horton@apple.com>
463
464         Turn on ccache for Mac cmake builds by default
465         https://bugs.webkit.org/show_bug.cgi?id=177059
466
467         Reviewed by Sam Weinig.
468
469         * Source/cmake/WebKitCCache.cmake: Added.
470         * Source/cmake/WebKitCommon.cmake:
471         Turn on ccache for Mac CMake builds (Makefile and Ninja generators only)
472         if it's installed, making use of CMake's ability to wrap the compiler invocation.
473
474 2017-10-20  Antoine Quint  <graouts@apple.com>
475
476         [Web Animations] Provide basic timeline and animation interfaces
477         https://bugs.webkit.org/show_bug.cgi?id=178526
478
479         Reviewed by Dean Jackson.
480
481         Remove the WEB_ANIMATIONS compile-time flag.
482
483         * Source/cmake/OptionsWPE.cmake:
484         * Source/cmake/OptionsWin.cmake:
485         * Source/cmake/WebKitFeatures.cmake:
486         * Source/cmake/tools/vsprops/FeatureDefines.props:
487         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
488
489 2017-10-18  Keith Miller  <keith_miller@apple.com>
490
491         Setup WebCore build to start using unified sources.
492         https://bugs.webkit.org/show_bug.cgi?id=178362
493
494         Reviewed by Tim Horton.
495
496         Pass features to the unified source bundler script.
497
498         * Source/cmake/WebKitCommon.cmake:
499         * Source/cmake/WebKitFeatures.cmake:
500         * Source/cmake/WebKitMacros.cmake:
501
502 2017-10-18  Zan Dobersek  <zdobersek@igalia.com>
503
504         Remove remnants of OpenWebRTC
505         https://bugs.webkit.org/show_bug.cgi?id=178437
506
507         Reviewed by Alejandro G. Castro.
508
509         Remove the FindOpenWebRTC.cmake file and the searches for it in both
510         OptionsGTK and OptionsWPE.
511
512         * Source/cmake/FindOpenWebRTC.cmake: Removed.
513         * Source/cmake/OptionsGTK.cmake:
514         * Source/cmake/OptionsWPE.cmake:
515
516 2017-10-10  Adrian Perez de Castro  <aperez@igalia.com>
517
518         [WPE] Remove the possibility of installing the old WebKit2 C API
519         https://bugs.webkit.org/show_bug.cgi?id=178125
520
521         Reviewed by Michael Catanzaro.
522
523         * Source/cmake/OptionsWPE.cmake: Remove definition of the EXPORT_DEPRECATED_WEBKIT2_C_API
524         build option.
525
526 2017-10-10  Michael Catanzaro  <mcatanzaro@igalia.com>
527
528         [WPE] Expose ENABLE_XSLT option
529         https://bugs.webkit.org/show_bug.cgi?id=177857
530
531         Reviewed by Carlos Alberto Lopez Perez.
532
533         * Source/cmake/OptionsWPE.cmake:
534
535 2017-10-09  Adrian Perez de Castro  <aperez@igalia.com>
536
537         [WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config
538         https://bugs.webkit.org/show_bug.cgi?id=178081
539
540         Reviewed by Carlos Alberto Lopez Perez.
541
542         * Source/cmake/FindLibEpoxy.cmake: Define the ${LIBEPOXY_DEFINITIONS} variable when libepoxy
543         is found by pkg-config. This contains the value of the "Cflags" field from "epoxy.pc".
544
545 2017-10-05  Frederic Wang  <fwang@igalia.com>
546
547         Remove WOFF2 from Source/ThirdParty.
548         https://bugs.webkit.org/show_bug.cgi?id=177862
549
550         Reviewed by Michael Catanzaro.
551
552         * Source/CMakeLists.txt: Do not build the woff2 source.
553         * Source/cmake/FindWOFF2Dec.cmake: Added. New cmake module for woff2.
554         * Source/cmake/OptionsGTK.cmake: Load the woff2 package.
555
556 2017-10-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
557
558         Generate a compile error if release is built without compiler optimizations
559         https://bugs.webkit.org/show_bug.cgi?id=177665
560
561         Reviewed by Brian Burg.
562
563         Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.
564
565         * CMakeLists.txt:
566
567 2017-10-05  Tim Horton  <timothy_horton@apple.com>
568
569         Make progress toward properly-formed XPC services in the Mac CMake build
570         https://bugs.webkit.org/show_bug.cgi?id=177918
571
572         Reviewed by Alex Christensen.
573
574         * Source/cmake/WebKitMacros.cmake:
575         Add a macro wrapper around 'ln'.
576
577 2017-10-03  Frederic Wang  <fwang@igalia.com>
578
579         Remove Brotli from Source/ThirdParty
580         https://bugs.webkit.org/show_bug.cgi?id=177804
581
582         Reviewed by Michael Catanzaro.
583
584         * Source/CMakeLists.txt: Do not build ThirdParty/brotli anymore.
585         * Source/cmake/FindBrotliDec.cmake: Added. New cmake module to find Brotli via PkgConfig.
586         * Source/cmake/OptionsGTK.cmake: Expose USE_WOFF2 as a public option and use find_package
587         to look for brotli.
588
589 2017-10-05  Yusuke Suzuki  <utatane.tea@gmail.com>
590
591         [Linux] Port MallocBench
592         https://bugs.webkit.org/show_bug.cgi?id=177856
593
594         Reviewed by Filip Pizlo.
595
596         * CMakeLists.txt:
597
598 2017-10-04  Ryan Haddad  <ryanhaddad@apple.com>
599
600         Unreviewed, rolling out r222840.
601
602         This change breaks internal builds.
603
604         Reverted changeset:
605
606         "Generate a compile error if release is built without compiler
607         optimizations"
608         https://bugs.webkit.org/show_bug.cgi?id=177665
609         http://trac.webkit.org/changeset/222840
610
611 2017-10-04  Commit Queue  <commit-queue@webkit.org>
612
613         Unreviewed, rolling out r222775.
614         https://bugs.webkit.org/show_bug.cgi?id=177890
615
616         Significantly increased the WebKit build time (Requested by
617         rniwa on #webkit).
618
619         Reverted changeset:
620
621         "Build libwebrtc unit tests executables"
622         https://bugs.webkit.org/show_bug.cgi?id=177211
623         http://trac.webkit.org/changeset/222775
624
625 2017-10-04  Miguel Gomez  <magomez@igalia.com>
626
627         Add animation support for WebP images
628         https://bugs.webkit.org/show_bug.cgi?id=113124
629
630         Reviewed by Žan Doberšek.
631
632         * Source/cmake/FindWebP.cmake:
633
634 2017-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
635
636         Generate a compile error if release is built without compiler optimizations
637         https://bugs.webkit.org/show_bug.cgi?id=177665
638
639         Reviewed by Michael Catanzaro.
640
641         Default to RelWithDebInfo if CMAKE_BUILD_TYPE is unset.
642
643         * CMakeLists.txt:
644
645 2017-10-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
646
647         [GLib] Let WebCore know of low power situations
648         https://bugs.webkit.org/show_bug.cgi?id=177810
649
650         Reviewed by Carlos Garcia Campos.
651
652         WebCore can use knowledge of low power situations to throttle timers and avoid expensive
653         checks, lowering power usage. We can use upower's warning level to let WebCore know we are
654         in such a situation.
655
656         * Source/cmake/OptionsGTK.cmake: depend on upower-glib.
657         * Source/cmake/FindUPowerGLib.cmake: Added.
658
659 2017-10-03  Youenn Fablet  <youenn@apple.com>
660
661         Build libwebrtc unit tests executables
662         https://bugs.webkit.org/show_bug.cgi?id=177211
663
664         Reviewed by Alex Christensen.
665
666         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
667
668 2017-10-02  Olivier Blin  <olivier.blin@softathome.com>
669
670         [WPE] Remove GnuTLS dependency
671         https://bugs.webkit.org/show_bug.cgi?id=177750
672
673         Reviewed by Michael Catanzaro.
674
675         libgcrypt is used by default instead of GnuTLS.
676         See bug 163125
677
678         * Source/cmake/OptionsWPE.cmake:
679
680 2017-10-02  Olivier Blin  <olivier.blin@softathome.com>
681
682         [WPE] Do not require XSLT if disabled
683         https://bugs.webkit.org/show_bug.cgi?id=177752
684
685         Reviewed by Michael Catanzaro.
686
687         * Source/cmake/OptionsWPE.cmake: libxslt is not a hard dep
688
689 2017-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
690
691         Remove ENABLE_CSS_REGIONS
692         https://bugs.webkit.org/show_bug.cgi?id=177689
693
694         Reviewed by Darin Adler.
695
696         * Source/cmake/OptionsGTK.cmake:
697         * Source/cmake/OptionsMac.cmake:
698         * Source/cmake/OptionsWPE.cmake:
699         * Source/cmake/OptionsWin.cmake:
700         * Source/cmake/WebKitFeatures.cmake:
701         * Source/cmake/tools/vsprops/FeatureDefines.props:
702         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
703
704 2017-09-29  Matt Lewis  <jlewis3@apple.com>
705
706         Unreviewed, rolling out r222652.
707
708         This broke an internal build.
709
710         Reverted changeset:
711
712         "Build libwebrtc unit tests executables"
713         https://bugs.webkit.org/show_bug.cgi?id=177211
714         http://trac.webkit.org/changeset/222652
715
716 2017-09-29  Youenn Fablet  <youenn@apple.com>
717
718         Build libwebrtc unit tests executables
719         https://bugs.webkit.org/show_bug.cgi?id=177211
720
721         Reviewed by Alex Christensen.
722
723         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
724
725 2017-09-27  Ryan Haddad  <ryanhaddad@apple.com>
726
727         Unreviewed, rolling out r222537.
728
729         This change broke internal builds.
730
731         Reverted changeset:
732
733         "Build libwebrtc unit tests executables"
734         https://bugs.webkit.org/show_bug.cgi?id=177211
735         http://trac.webkit.org/changeset/222537
736
737 2017-09-26  Youenn Fablet  <youenn@apple.com>
738
739         Build libwebrtc unit tests executables
740         https://bugs.webkit.org/show_bug.cgi?id=177211
741
742         Reviewed by Alex Christensen.
743
744         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
745
746 2017-09-26  Keith Miller  <keith_miller@apple.com>
747
748         CMake should reconfigure if the Sources.txt files are touched
749         https://bugs.webkit.org/show_bug.cgi?id=177508
750
751         Reviewed by JF Bastien.
752
753         * Source/cmake/WebKitMacros.cmake:
754
755 2017-09-24  Keith Miller  <keith_miller@apple.com>
756
757         JSC build should use unified sources for derived sources
758         https://bugs.webkit.org/show_bug.cgi?id=177421
759
760         Reviewed by JF Bastien.
761
762         * Source/cmake/WebKitMacros.cmake:
763
764 2017-09-26  Zan Dobersek  <zdobersek@igalia.com>
765
766         [CMake] Use implicit include directories for Clang as well
767         https://bugs.webkit.org/show_bug.cgi?id=177426
768
769         Reviewed by Michael Catanzaro.
770
771         In WebKitCompilerFlags.cmake, also gather and use the system
772         include directories for C and C++ build targets when compiling
773         with Clang. This fixes compilation errors when cross-building
774         WebKit with a Clang-based toolchain.
775
776         COMPILER_IS_GCC_OR_CLANG is used to check for GCC or Clang
777         compilers. That only checks for the C++ compiler, but it's not
778         reasonable to expect two widely different compilers being used
779         for C and C++ compilation.
780
781         * Source/cmake/WebKitCompilerFlags.cmake:
782
783 2017-09-25  Timothy Horton  <timothy_horton@apple.com>
784
785         Make progress on getting Mac CMake building again
786         https://bugs.webkit.org/show_bug.cgi?id=177443
787
788         Unreviewed, just "fixing" the build.
789
790         * Source/cmake/OptionsMac.cmake:
791         Turn on WEB_CRYPTO on Mac. We need to do a bigger cleanup of feature
792         defines, but this one is important because we have SUBTLE_CRYPTO on
793         and there is some amount of interdependency.
794
795 2017-09-22  Per Arne Vollan  <pvollan@apple.com>
796
797         [Win] WebKit is built as a static library, and not as a dll.
798         https://bugs.webkit.org/show_bug.cgi?id=177365
799
800         Reviewed by Brent Fulgham.
801
802         Set target type for WebKitLegacy target.
803
804         * Source/cmake/OptionsWin.cmake:
805
806 2017-09-22  Matt Lewis  <jlewis3@apple.com>
807
808         Unreviewed, rolling out r222394.
809
810         This broke the Windows Debug Build.
811
812         Reverted changeset:
813
814         "Remove build-webkit's notion of feature flags having a
815         default value"
816         https://bugs.webkit.org/show_bug.cgi?id=177338
817         http://trac.webkit.org/changeset/222394
818
819 2017-09-22  Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
820
821         Remove build-webkit's notion of feature flags having a default value
822         https://bugs.webkit.org/show_bug.cgi?id=177338
823
824         Reviewed by Alex Christensen.
825
826         Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.
827
828         * Source/cmake/OptionsGTK.cmake:
829         * Source/cmake/OptionsWPE.cmake:
830         * Source/cmake/WebKitFeatures.cmake:
831
832 2017-09-20  Keith Miller  <keith_miller@apple.com>
833
834         JSC should use unified sources for platform specific files.
835         https://bugs.webkit.org/show_bug.cgi?id=177290
836
837         Reviewed by Michael Saboff.
838
839         Change WEBKIT_COMPUTE_SOURCES CMake macro to look for platform
840         specific unified source lists. This is done in the same way that
841         we look for port specific configuration files. For example, if I
842         were building for the Mac port WEBKIT_COMPUTE_SOURCES would add
843         the Sources.txt and SourcesMac.txt source lists to the list of
844         unified sources.
845
846         * Source/cmake/WebKitMacros.cmake:
847
848 2017-09-20  Keith Miller  <keith_miller@apple.com>
849
850         JSC Xcode build should use unified sources for platform independent files
851         https://bugs.webkit.org/show_bug.cgi?id=177190
852
853         Reviewed by Saam Barati.
854
855         Add a macro for collecting the set of "header" source files and adding the bundle
856         files to the "sources" list.
857
858         * Source/cmake/WebKitMacros.cmake:
859
860 2017-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
861
862         REGRESSION(r222194) [WPE] Library and executable output names broken
863         https://bugs.webkit.org/show_bug.cgi?id=177273
864
865         Reviewed by Carlos Alberto Lopez Perez.
866
867         Move the WebKit2 output name variables from here to Source/WebKit.
868
869         * Source/cmake/OptionsWPE.cmake:
870
871 2017-09-20  Alberto Garcia  <berto@igalia.com>
872
873         Fix HPPA and Alpha builds
874         https://bugs.webkit.org/show_bug.cgi?id=177224
875
876         Reviewed by Alex Christensen.
877
878         * CMakeLists.txt:
879
880 2017-09-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
881
882         [CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
883         https://bugs.webkit.org/show_bug.cgi?id=177180
884
885         Reviewed by Michael Catanzaro.
886
887         This adds a ENABLE_WEB_CRYPTO flag and makes ENABLE_SUBTLE_CRYPTO depend on it.
888         The GTK and WPE ports enable them and set ENABLE_WEB_CRYPTO to public.
889
890         * Source/cmake/OptionsGTK.cmake: Set both features to ON and ENABLE_WEB_CRYPTO to public. No change in behaviour for GTK.
891         * Source/cmake/OptionsWPE.cmake: Do like on the GTK port. The public flag is now ENABLE_WEB_CRYPTO.
892         * Source/cmake/WebKitFeatures.cmake: Add the definition of ENABLE_WEB_CRYPTO and make ENABLE_SUBTLE_CRYPTO depend on it.
893
894 2017-09-18  Michael Catanzaro  <mcatanzaro@igalia.com>
895
896         [CMake] Rename WebKit target to WebKitLegacy and rename WebKit2 target to WebKit
897         https://bugs.webkit.org/show_bug.cgi?id=174558
898
899         Reviewed by Alex Christensen.
900
901         * CMakeLists.txt:
902         * Source/PlatformGTK.cmake:
903         * Source/cmake/OptionsGTK.cmake:
904         * Source/cmake/OptionsWPE.cmake:
905         * Source/cmake/WebKitCommon.cmake:
906         * Source/cmake/WebKitFS.cmake:
907
908 2017-09-18  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
909
910         [Win][PAL] Move WebCoreHeaderDetection.h to PAL
911         https://bugs.webkit.org/show_bug.cgi?id=176990
912
913         Reviewed by Alex Christensen.
914
915         Create DerivedSources directory for PAL if WebCore build is enabled.
916
917         * Source/cmake/WebKitCommon.cmake:
918         * Source/cmake/WebKitFS.cmake:
919
920 2017-09-15  Konstantin Tokarev  <annulen@yandex.ru>
921
922         Consider enabling -Wno-expansion-to-defined for gcc 7
923         https://bugs.webkit.org/show_bug.cgi?id=167643
924
925         Reviewed by Michael Catanzaro.
926
927         Don't disable -Wexpansion-to-defined for Clang.
928         As suggested by Nico Weber, this warning produces false positives with
929         GCC only.
930
931         * Source/cmake/WebKitCompilerFlags.cmake:
932
933 2017-09-14  Yousuke Kimoto  <yousuke.kimoto@sony.com>
934
935         [WinCairo] Add an option to build WebKitLegacy or WebKit
936         https://bugs.webkit.org/show_bug.cgi?id=176891
937
938         Added an option to build WebKitLegacy or WebKit.
939
940         Reviewed by Alex Christensen.
941
942         * Source/cmake/OptionsWin.cmake:
943
944 2017-09-13  Don Olmstead  <don.olmstead@sony.com>
945
946         [CMake] Detect harfbuzz without pkgconfig
947         https://bugs.webkit.org/show_bug.cgi?id=176886
948
949         Reviewed by Michael Catanzaro.
950
951         * Source/cmake/FindHarfBuzz.cmake:
952
953 2017-09-07  Adrian Perez de Castro  <aperez@igalia.com>
954
955         [WPE][CMake] Add "dist" and "distcheck" targets
956         https://bugs.webkit.org/show_bug.cgi?id=176448
957
958         Reviewed by Carlos Garcia Campos.
959
960         Add "dist" and "distcheck" CMake targets, which create release tarballs.
961         These are available only when configuring with -DDEVELOPER_MODE=TRUE.
962
963         * Source/PlatformWPE.cmake: Added.
964         * Source/cmake/FindXz.cmake: Added.
965
966 2017-09-05  Carlos Garcia Campos  <cgarcia@igalia.com>
967
968         [GTK] Wrong use of PLUGIN_ARCHITECTURE(X11) in several places
969         https://bugs.webkit.org/show_bug.cgi?id=176329
970
971         Reviewed by Michael Catanzaro.
972
973         Only define MOZ_X11 if X11 target is enabled and always define XP_UNIX if NETSCAPE_PLUGIN_API is enabled.
974
975         * Source/cmake/OptionsGTK.cmake:
976
977 2017-09-03  Sam Weinig  <sam@webkit.org>
978
979         Remove CanvasProxy
980         https://bugs.webkit.org/show_bug.cgi?id=176288
981
982         Reviewed by Yusuke Suzuki.
983
984         CanvasProxy does not appear to be in any current HTML spec
985         and was disabled and unimplemented in our tree. Time to 
986         get rid of it.
987
988         * Source/cmake/OptionsMac.cmake:
989         * Source/cmake/OptionsWin.cmake:
990         * Source/cmake/WebKitFeatures.cmake:
991         * Source/cmake/tools/vsprops/FeatureDefines.props:
992         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
993
994 2017-08-31  Don Olmstead  <don.olmstead@sony.com>
995
996         [CMake] Make USE_CF conditional within Windows
997         https://bugs.webkit.org/show_bug.cgi?id=176173
998
999         Reviewed by Alex Christensen.
1000
1001         * Source/cmake/OptionsAppleWin.cmake:
1002         * Source/cmake/OptionsWinCairo.cmake:
1003
1004 2017-08-30  Don Olmstead  <don.olmstead@sony.com>
1005
1006         [CMake][WinCairo] Use find_package for libpng and libjpeg
1007         https://bugs.webkit.org/show_bug.cgi?id=176113
1008
1009         Reviewed by Alex Christensen.
1010
1011         * Source/cmake/OptionsWinCairo.cmake:
1012
1013 2017-08-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1014
1015         [WPE] Enable MEMORY_SAMPLER
1016         https://bugs.webkit.org/show_bug.cgi?id=176099
1017
1018         Reviewed by Michael Catanzaro.
1019
1020         Enable the otion at build time by default on Linux (currently
1021         there are only Linux and Mac implementations of this feature).
1022
1023         * Source/cmake/OptionsWPE.cmake:
1024         * Source/cmake/OptionsGTK.cmake:
1025
1026 2017-08-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1027
1028         Unreviewed. Fix versions numbers after r221136.
1029
1030         We normally use .0 in trunk after branching, and bump to .1 when making the first unstable release. We also need
1031         to bump the library version.
1032
1033         * Source/cmake/OptionsGTK.cmake:
1034
1035 2017-08-29  Don Olmstead  <don.olmstead@sony.com>
1036
1037         [CMake] Use find_package for zlib
1038         https://bugs.webkit.org/show_bug.cgi?id=176075
1039
1040         Reviewed by Alex Christensen.
1041
1042         * Source/cmake/OptionsAppleWin.cmake:
1043         * Source/cmake/OptionsWinCairo.cmake:
1044
1045 2017-08-29  Don Olmstead  <don.olmstead@sony.com>
1046
1047         [CMake] Use find_package for libxml2 and libxstl
1048         https://bugs.webkit.org/show_bug.cgi?id=176042
1049
1050         Reviewed by Konstantin Tokarev.
1051
1052         * Source/cmake/OptionsAppleWin.cmake:
1053         * Source/cmake/OptionsWinCairo.cmake:
1054
1055 2017-08-24  Tomas Popela  <tpopela@redhat.com>
1056
1057         Bump trunk version to be 2.19.1
1058
1059         Rubber-stamped by Michael Catanzaro.
1060
1061         * Source/cmake/OptionsGTK.cmake:
1062
1063 2017-08-24  Don Olmstead  <don.olmstead@sony.com>
1064
1065         [CMake] Use find_package for SQLite
1066         https://bugs.webkit.org/show_bug.cgi?id=175803
1067
1068         Reviewed by Konstantin Tokarev.
1069
1070         * Source/cmake/OptionsAppleWin.cmake:
1071         * Source/cmake/OptionsWinCairo.cmake:
1072
1073 2017-08-23  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1074
1075         [GStreamer][GTK][WPE] Move common things to GStreamer cmake files
1076         https://bugs.webkit.org/show_bug.cgi?id=175625
1077
1078         Three files were created as kind of hooks for the GTK and WPE
1079         CMake option files. The definitions one is to enable, disable and
1080         create the common options (that can be and are actually overriden
1081         in some cases. The dependencies one adds dependencies for the
1082         option switches that are set. The checks one ensure the
1083         dependencies are met depending on the option switches.
1084
1085         Reviewed by Carlos Alberto Lopez Perez.
1086
1087         * Source/cmake/GStreamerChecks.cmake: Added.
1088         * Source/cmake/GStreamerDefinitions.cmake: Added.
1089         * Source/cmake/GStreamerDependencies.cmake: Added.
1090         * Source/cmake/OptionsGTK.cmake:
1091         * Source/cmake/OptionsWPE.cmake:
1092
1093 2017-08-22  Commit Queue  <commit-queue@webkit.org>
1094
1095         Unreviewed, rolling out r221006.
1096         https://bugs.webkit.org/show_bug.cgi?id=175821
1097
1098         generates build failures in the bots (Requested by calvaris[m]
1099         on #webkit).
1100
1101         Reverted changeset:
1102
1103         "[GStreamer][GTK][WPE] Move common things to GStreamer cmake
1104         files"
1105         https://bugs.webkit.org/show_bug.cgi?id=175625
1106         http://trac.webkit.org/changeset/221006
1107
1108 2017-08-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1109
1110         [GStreamer][GTK][WPE] Move common things to GStreamer cmake files
1111         https://bugs.webkit.org/show_bug.cgi?id=175625
1112
1113         Three files were created as kind of hooks for the GTK and WPE
1114         CMake option files. The definitions one is to enable, disable and
1115         create the common options (that can be and are actually overriden
1116         in some cases. The dependencies one adds dependencies for the
1117         option switches that are set. The checks one ensure the
1118         dependencies are met depending on the option switches.
1119
1120         Reviewed by Žan Doberšek.
1121
1122         * Source/cmake/GStreamerChecks.cmake: Added.
1123         * Source/cmake/GStreamerDefinitions.cmake: Added.
1124         * Source/cmake/GStreamerDependencies.cmake: Added.
1125         * Source/cmake/OptionsGTK.cmake:
1126         * Source/cmake/OptionsWPE.cmake:
1127
1128 2017-08-17  Andreas Kling  <akling@apple.com>
1129
1130         Disable CSS regions at compile time
1131         https://bugs.webkit.org/show_bug.cgi?id=175630
1132
1133         Reviewed by Antti Koivisto.
1134
1135         * Source/cmake/OptionsGTK.cmake:
1136         * Source/cmake/OptionsMac.cmake:
1137         * Source/cmake/OptionsWPE.cmake:
1138         * Source/cmake/OptionsWin.cmake:
1139         * Source/cmake/tools/vsprops/FeatureDefines.props:
1140         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1141
1142 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1143
1144         Remove Proximity Events and related code
1145         https://bugs.webkit.org/show_bug.cgi?id=175545
1146
1147         Reviewed by Daniel Bates.
1148
1149         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
1150         and other related code.
1151
1152         * Source/cmake/OptionsMac.cmake:
1153         * Source/cmake/OptionsWin.cmake:
1154         * Source/cmake/WebKitFeatures.cmake:
1155         * Source/cmake/tools/vsprops/FeatureDefines.props:
1156         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1157
1158 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1159
1160         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
1161         https://bugs.webkit.org/show_bug.cgi?id=175557
1162
1163         Reviewed by Jon Lee.
1164
1165         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
1166
1167         * Source/cmake/OptionsMac.cmake:
1168         * Source/cmake/OptionsWPE.cmake:
1169         * Source/cmake/OptionsWin.cmake:
1170         * Source/cmake/WebKitFeatures.cmake:
1171         * Source/cmake/tools/vsprops/FeatureDefines.props:
1172         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1173
1174 2017-08-14  Adrian Perez de Castro  <aperez@igalia.com>
1175
1176         [WPE] Implement WebCore::standardUserAgent()
1177         https://bugs.webkit.org/show_bug.cgi?id=175507
1178
1179         Reviewed by Michael Catanzaro.
1180
1181         Remove "_GLIB" from user-agent version macros.
1182
1183         * Source/cmake/OptionsGTK.cmake:
1184         * Source/cmake/OptionsWPE.cmake:
1185
1186 2017-08-13  Adrian Perez de Castro  <aperez@igalia.com>
1187
1188         [WPE] Implement WebCore::standardUserAgent()
1189         https://bugs.webkit.org/show_bug.cgi?id=175507
1190
1191         Reviewed by Carlos Alberto Lopez Perez.
1192
1193         Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.
1194
1195         * Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
1196         * Source/cmake/OptionsWPE.cmake: Add UA version macros.
1197
1198 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
1199
1200         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
1201         https://bugs.webkit.org/show_bug.cgi?id=175474
1202         <rdar://problem/33844628>
1203
1204         Reviewed by Wenson Hsieh.
1205
1206         * Source/cmake/OptionsMac.cmake:
1207         * Source/cmake/OptionsWin.cmake:
1208         * Source/cmake/WebKitFeatures.cmake:
1209         * Source/cmake/tools/vsprops/FeatureDefines.props:
1210         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1211
1212 2017-08-11  Konstantin Tokarev  <annulen@yandex.ru>
1213
1214         [CMake] Fix broken use of REQUIRED with find modules
1215         https://bugs.webkit.org/show_bug.cgi?id=175427
1216
1217         Reviewed by Michael Catanzaro.
1218
1219         Module name passed to find_package_handle_standard_args() must exactly
1220         match file name of CMake find module including letter case, e.g. "WebP"
1221         must be used in FindWebP.cmake file. Otherwise find_package() arguments
1222         (REQUIRED, QUIET, version) are not processed correctly.
1223
1224         To continue using old XXX_FOUND variables without case changes porting
1225         to new find_package_handle_standard_args syntax which has FOUND_VAR
1226         parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
1227         allowed by find_package_handle_standard_args when package name is
1228         GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).
1229
1230         * Source/cmake/FindGTKUnixPrint.cmake:
1231         * Source/cmake/FindGeoClue2.cmake:
1232         * Source/cmake/FindHyphen.cmake:
1233         * Source/cmake/FindLibEpoxy.cmake:
1234         * Source/cmake/FindLibGBM.cmake:
1235         * Source/cmake/FindLibsecret.cmake:
1236         * Source/cmake/FindLibtasn1.cmake:
1237         * Source/cmake/FindLibxkbcommon.cmake:
1238         * Source/cmake/FindOpenGL.cmake:
1239         * Source/cmake/FindOpenGLES2.cmake:
1240         * Source/cmake/FindOpenWebRTC.cmake:
1241         * Source/cmake/FindWPEBackend-mesa.cmake:
1242         * Source/cmake/FindWPEBackend.cmake:
1243         * Source/cmake/FindWayland.cmake:
1244         * Source/cmake/FindWebP.cmake:
1245         * Source/cmake/OptionsGTK.cmake:
1246
1247 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1248
1249         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
1250         https://bugs.webkit.org/show_bug.cgi?id=175426
1251
1252         Reviewed by Carlos Alberto Lopez Perez.
1253
1254         * Source/cmake/FindGeoClue2.cmake:
1255
1256 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1257
1258         Remove ENABLE_GAMEPAD_DEPRECATED
1259         https://bugs.webkit.org/show_bug.cgi?id=175361
1260
1261         Reviewed by Carlos Garcia Campos.
1262
1263         * Source/cmake/FindGUdev.cmake: Removed.
1264         * Source/cmake/OptionsGTK.cmake:
1265         * Source/cmake/OptionsMac.cmake:
1266         * Source/cmake/WebKitFeatures.cmake:
1267
1268 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1269
1270         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
1271         https://bugs.webkit.org/show_bug.cgi?id=175426
1272
1273         Reviewed by Carlos Garcia Campos.
1274
1275         Fix the pkg-config file name.
1276         We really require geoclue-2.0 and not libgeoclue-2.0.
1277
1278         * Source/cmake/FindGeoClue2.cmake:
1279
1280 2017-08-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1281
1282         [GTK] Remove support for geoclue1
1283         https://bugs.webkit.org/show_bug.cgi?id=164205
1284
1285         Reviewed by Carlos Garcia Campos.
1286
1287         * Source/cmake/FindGeoClue.cmake: Removed.
1288         * Source/cmake/OptionsGTK.cmake:
1289
1290 2017-08-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1291
1292         [CMake] Remove unused find modules
1293         https://bugs.webkit.org/show_bug.cgi?id=175363
1294
1295         Reviewed by Carlos Alberto Lopez Perez.
1296
1297         * Source/cmake/FindCFLite.cmake: Removed.
1298         * Source/cmake/FindClang.cmake: Removed.
1299         * Source/cmake/FindDBus.cmake: Removed.
1300         * Source/cmake/FindDirectX.cmake: Removed.
1301         * Source/cmake/FindEspeak.cmake: Removed.
1302         * Source/cmake/FindQuickTimeSDK.cmake: Removed.
1303
1304 2017-08-09  Zan Dobersek  <zdobersek@igalia.com>
1305
1306         [WPE] Enable SUBTLE_CRYPTO in release builds
1307         https://bugs.webkit.org/show_bug.cgi?id=175371
1308
1309         Reviewed by Carlos Garcia Campos.
1310
1311         * Source/cmake/OptionsWPE.cmake:
1312         Use ON as the default port value for ENABLE_SUBTLE_CRYPTO in WPE.
1313
1314 2017-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1315
1316         [GTK] Enable SUBTLE_CRYPTO in GTK+ releases
1317         https://bugs.webkit.org/show_bug.cgi?id=172758
1318
1319         Reviewed by Žan Doberšek.
1320
1321         Add ENABLE_WEB_CRYPTO public option and make ENABLE_SUBTLE_CRYPTO depend on it.
1322
1323         * Source/cmake/OptionsGTK.cmake:
1324
1325 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1326
1327         [CMake] Properly test if compiler supports compiler flags
1328         https://bugs.webkit.org/show_bug.cgi?id=174490
1329
1330         Reviewed by Konstantin Tokarev.
1331
1332         This turned out to be a massive pain. I didn't want to merely check options before using
1333         them: I also wanted to organize the code to avoid setting similar flags in different places.
1334         Right now we set a bunch of global flags in OptionsCommon.cmake, and a bunch more flags in
1335         WEBKIT_SET_EXTRA_COMPILER_FLAGS on a per-target basis.
1336
1337         Setting flags per-target seems better in general, e.g. because it makes it very easy to
1338         disable warnings for particular ThirdParty targets. But it turns out that all the flags set
1339         on a per-target basis get passed to both the C compiler and the C++ compiler, so it's
1340         impossible to pass C++-only flags there. That's terrible. It's possible to make the flags
1341         language-conditional using generator expressions, but that doesn't work for the Visual
1342         Studio backend, so we would have to drop support for that (not going to happen). The CMake
1343         documentation suggests that C and C++ files ought to be built in separate targets to avoid
1344         this. It's a mess, basically.
1345
1346         So I've wound up removing WEBKIT_SET_EXTRA_COMPILER_FLAGS and adding most of those flags to
1347         CMAKE_C_FLAGS and CMAKE_CXX_FLAGS instead. Really the only disadvantage of this is we now
1348         have to suppress individual warnings when building ANGLESupport in WebCore. That's not the
1349         end of the world. The only remaining useful feature of WEBKIT_SET_EXTRA_COMPILER_FLAGS was
1350         to add -fPIC to static library targets, but turns out CMake does that for us if we just set
1351         the variable CMAKE_POSITION_INDEPENDENT_CODE, so we can get rid of it completely.
1352
1353         Of course there are also macros for setting target-specific compiler flags, which we
1354         frequently need in order to suppress specific warnings, particularly warnings coming from
1355         third-party libraries like ANGLE and gtest. But remember the footgun: these macros will test
1356         the flag against only one compiler, but must work with both C and C++ compilers unless the
1357         build target exclusively contains targets built with just one of those compilers. Yuck.
1358
1359         * CMakeLists.txt:
1360         * Source/CMakeLists.txt:
1361         * Source/PlatformGTK.cmake:
1362         * Source/cmake/OptionsCommon.cmake:
1363         * Source/cmake/WebKitCommon.cmake:
1364         * Source/cmake/WebKitCompilerFlags.cmake: Added.
1365         * Source/cmake/WebKitMacros.cmake:
1366
1367 2017-08-07  Brian Burg  <bburg@apple.com>
1368
1369         Remove CANVAS_PATH compilation guard
1370         https://bugs.webkit.org/show_bug.cgi?id=175207
1371
1372         Reviewed by Sam Weinig.
1373
1374         * Source/cmake/OptionsGTK.cmake:
1375         * Source/cmake/OptionsMac.cmake:
1376         * Source/cmake/OptionsWin.cmake:
1377         * Source/cmake/WebKitFeatures.cmake:
1378         * Source/cmake/tools/vsprops/FeatureDefines.props:
1379         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1380
1381 2017-08-03  Brian Burg  <bburg@apple.com>
1382
1383         Remove ENABLE(WEB_SOCKET) guards
1384         https://bugs.webkit.org/show_bug.cgi?id=167044
1385
1386         Reviewed by Joseph Pecoraro.
1387
1388         * Source/cmake/OptionsMac.cmake:
1389         * Source/cmake/OptionsWin.cmake:
1390         * Source/cmake/WebKitFeatures.cmake:
1391         * Source/cmake/tools/vsprops/FeatureDefines.props:
1392         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1393
1394 2017-08-03  Brady Eidson  <beidson@apple.com>
1395
1396         Add SW IDLs and stub out basic functionality.
1397         https://bugs.webkit.org/show_bug.cgi?id=175115
1398
1399         Reviewed by Chris Dumez.
1400
1401         * Source/cmake/WebKitFeatures.cmake:
1402         * Source/cmake/tools/vsprops/FeatureDefines.props:
1403         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1404
1405 2017-08-01  Brady Eidson  <beidson@apple.com>
1406
1407         Part 1 of: Rename DatabaseProcess to StorageProcess.
1408         https://bugs.webkit.org/show_bug.cgi?id=174879
1409
1410         Reviewed by Andy Estes.
1411
1412         * Source/cmake/OptionsWPE.cmake:
1413         * Source/cmake/gtksymbols.filter:
1414
1415 2017-08-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1416
1417         [CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later
1418         https://bugs.webkit.org/show_bug.cgi?id=174855
1419
1420         Reviewed by Carlos Garcia Campos.
1421
1422         Create derived sources directories in WebKitCommon.cmake instead of WebKitFS.cmake, which is
1423         too soon. I tried changing the include order, but other stuff in WebKitFS.cmake really is
1424         needed before including the port options file.
1425
1426         * Source/cmake/WebKitCommon.cmake:
1427         * Source/cmake/WebKitFS.cmake:
1428
1429 2017-07-29  Yusuke Suzuki  <utatane.tea@gmail.com>
1430
1431         Unreviewed, build fix for GTK and WPE about StorageProcess renaming
1432
1433         * Source/cmake/OptionsWPE.cmake:
1434
1435 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1436
1437         Unreviewed, rolling out r219986.
1438         https://bugs.webkit.org/show_bug.cgi?id=174962
1439
1440         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1441         estes on #webkit).
1442
1443         Reverted changeset:
1444
1445         "Part 1 of: Rename DatabaseProcess to StorageProcess."
1446         https://bugs.webkit.org/show_bug.cgi?id=174879
1447         http://trac.webkit.org/changeset/219986
1448
1449 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
1450
1451         [GTK] Building with ENABLE_VIDEO=OFF fails
1452         https://bugs.webkit.org/show_bug.cgi?id=174940
1453
1454         Reviewed by Alex Christensen.
1455
1456         Code guarded by ENABLE(MEDIA_STREAM) requires the definition of HTMLVideoElement to
1457         be available, which in turn is guarded by ENABLE(VIDEO).
1458
1459         * Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_STREAM depend on ENABLE_VIDEO.
1460
1461 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
1462
1463         [WPE] Implement EventSenderProxy in WTR
1464         https://bugs.webkit.org/show_bug.cgi?id=173419
1465
1466         Reviewed by Žan Doberšek.
1467
1468         Add the implementation of EventSenderProxy to the WTR. This
1469         allows us to extend the coverage of the test suite in WKWPE.
1470
1471         * Source/cmake/FindLibxkbcommon.cmake: Added.
1472
1473 2017-07-28  Zan Dobersek  <zdobersek@igalia.com>
1474
1475         Unreviewed. Bumping the patch version for WPEWebKit library to 20170728.
1476
1477         * Source/cmake/OptionsWPE.cmake:
1478
1479 2017-07-27  Brady Eidson  <beidson@apple.com>
1480
1481         Part 1 of: Rename DatabaseProcess to StorageProcess.
1482         https://bugs.webkit.org/show_bug.cgi?id=174879
1483
1484         Reviewed by Andy Estes.
1485
1486         * Source/cmake/OptionsWPE.cmake:
1487         * Source/cmake/gtksymbols.filter:
1488
1489
1490 2017-07-26  Brady Eidson  <beidson@apple.com>
1491
1492         Remove DATABASE_PROCESS build flag.
1493         https://bugs.webkit.org/show_bug.cgi?id=174868
1494
1495         Reviewed by Andy Estes.
1496
1497         * Source/cmake/OptionsGTK.cmake:
1498         * Source/cmake/OptionsMac.cmake:
1499         * Source/cmake/OptionsWPE.cmake:
1500         * Source/cmake/WebKitFeatures.cmake:
1501
1502 2017-07-26  Brian Burg  <bburg@apple.com>
1503
1504         Remove WEB_TIMING feature flag
1505         https://bugs.webkit.org/show_bug.cgi?id=174795
1506
1507         Reviewed by Alex Christensen.
1508
1509         * Source/cmake/OptionsWPE.cmake:
1510         * Source/cmake/OptionsWin.cmake:
1511         * Source/cmake/WebKitFeatures.cmake:
1512         * Source/cmake/tools/vsprops/FeatureDefines.props:
1513         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
1514
1515 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1516
1517         Unreviewed. Fix WebKit2 derived sources directory creation after r219488.
1518
1519         The variable is still DERIVED_SOURCES_WEBKIT2_DIR, not DERIVED_SOURCES_WEBKIT_DIR. Build was not really affected
1520         because WebKit2 makefile creates the directory too.
1521
1522         * Source/cmake/WebKitFS.cmake:
1523
1524 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1525
1526         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.5 release.
1527
1528         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
1529
1530 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1531
1532         Unreviewed. Fix GTK+ WebKit2 library soname after r219488.
1533
1534         The WebKit2 -> WebKit rename shouldn't affect the GTK+ library that is still called libwebkit2gtk, so keep using
1535         WEBKIT2 as the library name in CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE, since that's also what the WebKit
1536         makefile passes to WEBKIT_POPULATE_LIBRARY_VERSION.
1537
1538         * Source/cmake/OptionsGTK.cmake:
1539
1540 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1541
1542         [WPE] Add libepoxy to the Jhbuild moduleset
1543         https://bugs.webkit.org/show_bug.cgi?id=174711
1544
1545         Reviewed by Carlos Alberto Lopez Perez.
1546
1547         libepoxy 1.3.1 that's widely available in current stable distributions (Debian stable,
1548         Ubuntu LTS) does suffice our needs, but also contains a bug that incorrectly determines
1549         the current EGL context and the API version of OpenGL that's bound to that context.
1550         Focusing on experiences on Debian systems, while the current stable Debian release has
1551         this bug patched, the package for the testing distribution of Debian removed that same
1552         patch for whatever reason, despite using the 1.3.1 version as the package basis.
1553
1554         To avoid this, libepoxy 1.4.3 is now added to WPE's Jhbuild moduleset. The WPE port
1555         also now demands at least the 1.4.0 version to be available when configuring.
1556
1557         We should revisit the minimum version for libepoxy in the future if the 1.3 release
1558         branch gets updated with the proper fix.
1559
1560         * Source/cmake/FindLibEpoxy.cmake:
1561         * Source/cmake/OptionsWPE.cmake:
1562
1563 2017-07-21  Konstantin Tokarev  <annulen@yandex.ru>
1564
1565        [cmake] Unreviewed, add definitions necessary to use ICU shipped with macOS
1566
1567        macOS system ICU libraries are built with U_DISABLE_RENAMING=1 and
1568        U_SHOW_CPLUSPLUS_API=0. After r219155 we have to pass this definitons
1569        explicitly, because ICU headers in the tree are not modified anymore.
1570
1571         * Source/cmake/OptionsJSCOnly.cmake:
1572         * Source/cmake/OptionsMac.cmake:
1573
1574 2017-07-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1575
1576         Add initial implementation of WebDriver process to run the HTTP server
1577         https://bugs.webkit.org/show_bug.cgi?id=166682
1578
1579         Reviewed by Brian Burg.
1580
1581         Enable WebDriver in the GTK port by default.
1582
1583         * Source/CMakeLists.txt:
1584         * Source/cmake/OptionsGTK.cmake:
1585         * Source/cmake/WebKitFS.cmake:
1586         * Source/cmake/WebKitFeatures.cmake:
1587
1588 2017-07-17  Konstantin Tokarev  <annulen@yandex.ru>
1589
1590         [cmake] Set library types before their targets are created
1591         https://bugs.webkit.org/show_bug.cgi?id=174600
1592
1593         Reviewed by Michael Catanzaro.
1594
1595         Since r219560 library targets are created before PlatformXXX.cmake
1596         files are processed, however library type must be passed in
1597         add_library() call and cannot be changed afterwards. Set these
1598         variables in OptionsXXX.cmake.
1599
1600         * CMakeLists.txt:
1601         * Source/cmake/OptionsMac.cmake:
1602         * Source/cmake/OptionsWPE.cmake:
1603         * Source/cmake/OptionsWin.cmake:
1604
1605 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1606
1607         [CMake] Include most CMake modules from WebKitCommon.cmake
1608         https://bugs.webkit.org/show_bug.cgi?id=174546
1609
1610         Reviewed by Konstantin Tokarev.
1611
1612         * CMakeLists.txt:
1613         * Source/cmake/OptionsCommon.cmake:
1614         * Source/cmake/WebKitCommon.cmake:
1615         * Source/cmake/WebKitMacros.cmake:
1616
1617 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1618
1619         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1620         https://bugs.webkit.org/show_bug.cgi?id=174547
1621
1622         Reviewed by Alex Christensen.
1623
1624         * Source/cmake/WebKitMacros.cmake:
1625
1626 2017-07-17  Konstantin Tokarev  <annulen@yandex.ru>
1627
1628         [CMake] Create targets before WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS is called
1629         https://bugs.webkit.org/show_bug.cgi?id=174557
1630
1631         Reviewed by Michael Catanzaro.
1632
1633         * Source/cmake/WebKitMacros.cmake:
1634
1635 2017-07-16  Michael Catanzaro  <mcatanzaro@igalia.com>
1636
1637         [CMake] Raise minimum CMake requirement
1638         https://bugs.webkit.org/show_bug.cgi?id=174545
1639
1640         Reviewed by Konstantin Tokarev.
1641
1642         * CMakeLists.txt:
1643         * Source/cmake/OptionsCommon.cmake:
1644         * Source/cmake/OptionsGTK.cmake:
1645         * Source/cmake/OptionsJSCOnly.cmake:
1646
1647 2017-07-14  Michael Catanzaro  <mcatanzaro@igalia.com>
1648
1649         [CMake] Unclear distinction between WebKitHelpers and WebKitMacros
1650         https://bugs.webkit.org/show_bug.cgi?id=153189
1651
1652         Reviewed by Antonio Gomes.
1653
1654         Merge WebKitHelpers.cmake into WebKitMacros.cmake, since there is no meaningful distinction
1655         between the macros that belong in each file. Then, move the macros that are only needed by
1656         one project into project-specific CMake files. Retain here only the macros that are needed
1657         in multiple places.
1658
1659         * Source/cmake/OptionsCommon.cmake: Update a comment.
1660         * Source/cmake/OptionsGTK.cmake: New location for libtool macro, exclusively needed here.
1661         * Source/cmake/WebKitCommon.cmake: Do not include WebKitHelpers.cmake.
1662         * Source/cmake/WebKitHelpers.cmake: Removed.
1663         * Source/cmake/WebKitMacros.cmake:
1664
1665 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1666
1667         [GTK][WPE] Avoid setting settings that are set by default
1668
1669         Unreviewed.
1670
1671         * Source/cmake/OptionsGTK.cmake:
1672         * Source/cmake/OptionsWPE.cmake:
1673
1674 2017-07-13  Konstantin Tokarev  <annulen@ynadex.ru>
1675
1676         Unreviewed, Windows ports should enable WebKitLegacy and disable
1677         WebKit.
1678
1679         * Source/cmake/OptionsWin.cmake:
1680
1681 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1682
1683         Fix the Mac CMake build.
1684
1685         Unreviewed build fix.
1686
1687         Fix the Mac CMake build after r219488 broke it. r219488 erroneously updated
1688         the variable name DERIVED_SOURCES_WEBKITLEGACY_DIR to DERIVED_SOURCES_WEBKIT_LEGACY_DIR
1689         without updating subsequent users of that variable.
1690
1691         * Source/cmake/WebKitFS.cmake:
1692         Rename DERIVED_SOURCES_WEBKIT_LEGACY_DIR back to DERIVED_SOURCES_WEBKITLEGACY_DIR.
1693
1694 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1695
1696         Fix the cMake builds (GTK and WPE.)
1697         https://bugs.webkit.org/show_bug.cgi?id=174164
1698         rdar://problem/33137595
1699
1700         Reviewed by Dan Bernstein.
1701
1702         * Source/CMakeLists.txt:
1703         * Source/cmake/OptionsGTK.cmake:
1704         * Source/cmake/OptionsJSCOnly.cmake:
1705         * Source/cmake/OptionsMac.cmake:
1706         * Source/cmake/OptionsWPE.cmake:
1707         * Source/cmake/WebKitFS.cmake:
1708         * Source/cmake/WebKitPackaging.cmake:
1709
1710 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1711
1712         Rename WebKit2.xcodeproj to WebKit.xcodeproj.
1713         https://bugs.webkit.org/show_bug.cgi?id=174164
1714         rdar://problem/33137595
1715
1716         Reviewed by Dan Bernstein.
1717
1718         * WebKit.xcworkspace/contents.xcworkspacedata:
1719         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1720
1721 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1722
1723         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1724         https://bugs.webkit.org/show_bug.cgi?id=174164
1725         rdar://problem/33137595
1726
1727         Reviewed by Dan Bernstein.
1728
1729         * Source/Makefile:
1730         * Source/PlatformGTK.cmake:
1731         * Source/cmake/OptionsGTK.cmake:
1732         * Source/cmake/WebKitFS.cmake:
1733         * Source/cmake/WebKitPackaging.cmake:
1734         * WebKit.xcworkspace/contents.xcworkspacedata:
1735         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1736
1737 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1738
1739         Update the Xcode project name from WebKit to WebKitLegacy.
1740         https://bugs.webkit.org/show_bug.cgi?id=174162
1741         rdar://problem/33137594
1742
1743         Reviewed by Dan Bernstein.
1744
1745         Rename WebKit to WebKitLegacy.
1746
1747         * WebKit.xcworkspace/contents.xcworkspacedata:
1748         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1749
1750 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1751
1752         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1753         https://bugs.webkit.org/show_bug.cgi?id=174162
1754         rdar://problem/33137594
1755
1756         Reviewed by Dan Bernstein.
1757
1758         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource cmake files
1759         and Xcode project files.
1760
1761         * Source/cmake/OptionsGTK.cmake:
1762         * Source/cmake/WebKitFS.cmake:
1763         * WebKit.xcworkspace/contents.xcworkspacedata:
1764         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1765
1766 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1767
1768         Fix compiler warnings when building with GCC 7
1769         https://bugs.webkit.org/show_bug.cgi?id=174463
1770
1771         Reviewed by Darin Adler.
1772
1773         * Source/cmake/OptionsCommon.cmake:
1774
1775 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1776
1777         Unreviewed, rolling out r219401.
1778
1779         This revision rolled out the previous patch, but after talking
1780         with reviewer, a rebaseline is what was needed.Rolling back in
1781         before rebaseline.
1782
1783         Reverted changeset:
1784
1785         "Unreviewed, rolling out r219379."
1786         https://bugs.webkit.org/show_bug.cgi?id=174400
1787         http://trac.webkit.org/changeset/219401
1788
1789 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1790
1791         Unreviewed, rolling out r219379.
1792
1793         This revision caused a consistent failure in the test
1794         fast/dom/Window/property-access-on-cached-window-after-frame-
1795         removed.html.
1796
1797         Reverted changeset:
1798
1799         "Remove NAVIGATOR_HWCONCURRENCY"
1800         https://bugs.webkit.org/show_bug.cgi?id=174400
1801         http://trac.webkit.org/changeset/219379
1802
1803 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
1804
1805         [WPE] Use libepoxy
1806         https://bugs.webkit.org/show_bug.cgi?id=172104
1807
1808         Reviewed by Michael Catanzaro.
1809
1810         * Source/cmake/FindLibEpoxy.cmake: Added.
1811         * Source/cmake/OptionsWPE.cmake: Find libepoxy, don't search for
1812         EGL or OpenGL ES anymore, and enable USE_LIBEPOXY by default.
1813
1814 2017-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1815
1816         [GTK][WPE] Enable FILE_LOCK and implement lockFile and unlockFile
1817         https://bugs.webkit.org/show_bug.cgi?id=174357
1818
1819         Reviewed by Michael Catanzaro.
1820
1821         * Source/cmake/OptionsGTK.cmake: Use gio-unix unconditionally.
1822
1823 2017-07-11  Dean Jackson  <dino@apple.com>
1824
1825         Remove NAVIGATOR_HWCONCURRENCY
1826         https://bugs.webkit.org/show_bug.cgi?id=174400
1827
1828         Reviewed by Sam Weinig.
1829
1830         * Source/cmake/OptionsMac.cmake:
1831         * Source/cmake/WebKitFeatures.cmake:
1832
1833 2017-07-11  Dean Jackson  <dino@apple.com>
1834
1835         Rolling out r219372.
1836
1837         * Source/cmake/OptionsMac.cmake:
1838         * Source/cmake/WebKitFeatures.cmake:
1839
1840 2017-07-11  Dean Jackson  <dino@apple.com>
1841
1842         Remove NAVIGATOR_HWCONCURRENCY
1843         https://bugs.webkit.org/show_bug.cgi?id=174400
1844
1845         Reviewed by Sam Weinig.
1846
1847         * Source/cmake/OptionsMac.cmake:
1848         * Source/cmake/WebKitFeatures.cmake:
1849
1850 2017-07-03  Brian Burg  <bburg@apple.com>
1851
1852         Web Replay: remove some unused code
1853         https://bugs.webkit.org/show_bug.cgi?id=173903
1854
1855         Rubber-stamped by Joseph Pecoraro.
1856
1857         * ManualTests/inspector/replay-keyboard-events.html: Removed.
1858         * ManualTests/inspector/replay-mouse-events.html: Removed.
1859         * ManualTests/inspector/replay-wheel-events.html: Removed.
1860         * ManualTests/inspector/replay-window-navigator-basic.html: Removed.
1861         * ManualTests/inspector/replay-window-screen.html: Removed.
1862         * Source/cmake/OptionsMac.cmake:
1863         * Source/cmake/WebKitFeatures.cmake:
1864
1865 2017-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1866
1867         Move make-js-file-arrays.py from WebCore to JavaScriptCore
1868         https://bugs.webkit.org/show_bug.cgi?id=174024
1869
1870         Reviewed by Michael Catanzaro.
1871
1872         Make MAKE_JS_FILE_ARRAYS independent of WebCore and update it to use make-js-file-arrays.py from
1873         JavaScriptCore. It's no longer needed to set PYTHON_PATH to find jsmin.py.
1874
1875         * Source/cmake/WebKitMacros.cmake:
1876
1877 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1878
1879         Drop NOSNIFF compile flag
1880         https://bugs.webkit.org/show_bug.cgi?id=174289
1881
1882         Reviewed by Michael Catanzaro.
1883
1884         * Source/cmake/WebKitFeatures.cmake:
1885
1886 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1887
1888         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1889         https://bugs.webkit.org/show_bug.cgi?id=174250
1890
1891         Reviewed by Carlos Alberto Lopez Perez.
1892
1893         Make nosniff enabled by default in all the ports.
1894
1895         * Source/cmake/OptionsMac.cmake:
1896         * Source/cmake/OptionsWin.cmake:
1897         * Source/cmake/WebKitFeatures.cmake:
1898
1899 2017-07-06  Stephan Szabo  <stephan.szabo@sony.com>
1900
1901         [Win] Build precompiled header successfully with clang-cl
1902         https://bugs.webkit.org/show_bug.cgi?id=174221
1903
1904         Reviewed by Alex Christensen.
1905
1906         * Source/cmake/WebKitMacros.cmake:
1907
1908 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1909
1910         Upgrade GCC baseline
1911         https://bugs.webkit.org/show_bug.cgi?id=174155
1912
1913         Reviewed by Michael Catanzaro.
1914
1915         This patch bumps the version of GCC from 4.9.0 to 5.0.0,
1916         which is shipped with Ubuntu 16.04 LTS. And the latest
1917         Debian stable (stretch) already ships newer GCC (6.3.0).
1918         Remove workaround for old GCC. And move GCC version check
1919         to the top-level CMakeLists.txt.
1920
1921         * CMakeLists.txt:
1922         * Source/cmake/OptionsGTK.cmake:
1923         * Source/cmake/WebKitHelpers.cmake:
1924
1925 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1926
1927         [WinCairo] Consolidate CMake code related to CURL
1928         https://bugs.webkit.org/show_bug.cgi?id=170860
1929
1930         Reviewed by Alex Christensen.
1931
1932         * Source/cmake/OptionsWinCairo.cmake:
1933
1934 2017-06-28  Stephan Szabo  <stephan.szabo@am.sony.com>
1935
1936         [Win] Build JSCOnly on Windows with clang-cl
1937         https://bugs.webkit.org/show_bug.cgi?id=173889
1938
1939         Reviewed by Konstantin Tokarev.
1940
1941         * CMakeLists.txt:
1942         * Source/cmake/OptionsCommon.cmake:
1943         * Source/cmake/OptionsMSVC.cmake:
1944
1945 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1946
1947         [WPE] User script messages don't work
1948         https://bugs.webkit.org/show_bug.cgi?id=173712
1949
1950         Reviewed by Žan Doberšek.
1951
1952         Enable user script messages.
1953
1954         * Source/cmake/OptionsWPE.cmake:
1955
1956 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1957
1958         [WPE] Enable PUBLIC_SUFFIX_LIST
1959         https://bugs.webkit.org/show_bug.cgi?id=173758
1960
1961         Reviewed by Žan Doberšek.
1962
1963         WebsiteDataStore needs it when fetching data.
1964
1965         Fixes: /wpe/WebKitCookieManager/accept-policy
1966                /wpe/WebKitCookieManager/delete-cookies
1967                /wpe/WebKitCookieManager/cookies-changed
1968                /wpe/WebKitCookieManager/persistent-storage
1969                /wpe/WebKitCookieManager/ephemeral
1970                /wpe/WebKitWebsiteData/ephemeral
1971                /wpe/WebKitWebsiteData/cache
1972                /wpe/WebKitWebsiteData/storage
1973                /wpe/WebKitWebsiteData/databases
1974                /wpe/WebKitWebsiteData/appcache
1975                /wpe/WebKitWebsiteData/cookies
1976
1977         * Source/cmake/OptionsWPE.cmake:
1978
1979 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1980
1981         [WPE] Add initial web extensions API
1982         https://bugs.webkit.org/show_bug.cgi?id=173640
1983
1984         Reviewed by Žan Doberšek.
1985
1986         * Source/cmake/OptionsWPE.cmake:
1987
1988 2017-06-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1989
1990         [MSVC] Fix compilation in CP932 (Shift_JIS) environment
1991         https://bugs.webkit.org/show_bug.cgi?id=173638
1992
1993         Reviewed by Alex Christensen.
1994
1995         Give "/utf-8 /validate-charset" options to the MSVC compiler
1996         to specify the source code encoding.
1997
1998         * Source/cmake/OptionsMSVC.cmake:
1999
2000 2017-06-21  Miguel Gomez  <magomez@igalia.com>
2001
2002         [GTK] Fix the condition to enable/disable GSTREAMER_GL
2003         https://bugs.webkit.org/show_bug.cgi?id=173650
2004
2005         Reviewed by Carlos Garcia Campos.
2006
2007         If GSTREAMER_GL is enabled, check for the GStreamer version. If the version is < 1.10, disable
2008         GSTREAMER_GL and continue. If the version is >= 1.10 but there's no gstreamer-gl package available
2009         then fail.
2010
2011         * Source/cmake/FindGStreamer.cmake:
2012         * Source/cmake/OptionsGTK.cmake:
2013
2014 2017-06-21  Miguel Gomez  <magomez@igalia.com>
2015
2016         [GTK] Enable GStreamer GL by default on production builds
2017         https://bugs.webkit.org/show_bug.cgi?id=173406
2018
2019         Reviewed by Carlos Garcia Campos.
2020
2021         Enable GStreamer GL by default when the GStreamer version >= 1.10.
2022
2023         * Source/cmake/OptionsGTK.cmake:
2024
2025 2017-06-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2026
2027         [GTK] Move WebGtkExtensionManager and WebGtkInjectedBundleMain to glib API dir
2028         https://bugs.webkit.org/show_bug.cgi?id=173606
2029
2030         Reviewed by Žan Doberšek.
2031
2032         Update public symbols that were renamed.
2033
2034         * Source/cmake/gtksymbols.filter:
2035
2036 2017-06-20  Zan Dobersek  <zdobersek@igalia.com>
2037
2038         [GCrypt] Implement CryptoKeyEC SPKI imports
2039         https://bugs.webkit.org/show_bug.cgi?id=172927
2040
2041         Reviewed by Jiewen Tan, Michael Catanzaro and Carlos Garcia Campos.
2042
2043         * Source/cmake/FindLibtasn1.cmake: Added.
2044         * Source/cmake/OptionsGTK.cmake: Require libtasn1 when SUBTLE_CRYPTO is enabled.
2045         * Source/cmake/OptionsWPE.cmake: Ditto.
2046
2047 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2048
2049         [WPE] Add initial implementation of glib API
2050         https://bugs.webkit.org/show_bug.cgi?id=173546
2051
2052         Reviewed by Žan Doberšek.
2053
2054         Add some definitions required to build WPE glib API.
2055
2056         * Source/cmake/OptionsWPE.cmake:
2057
2058 2017-06-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2059
2060         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.4 release.
2061
2062         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2063
2064 2017-06-16  Alex Christensen  <achristensen@webkit.org>
2065
2066         Fix Mac CMake build.
2067
2068         * Source/cmake/WebKitFS.cmake:
2069         Add new DerivedSources/WTF directory.
2070
2071 2017-06-15  Konstantin Tokarev  <annulen@yandex.ru>
2072
2073         [cmake] ADD_PRECOMPILED_HEADER should append OBJECT_DEPENDS, not overwrite it
2074         https://bugs.webkit.org/show_bug.cgi?id=173428
2075
2076         Reviewed by Michael Catanzaro.
2077
2078         Right now, if any of source files that are passed to
2079         ADD_PRECOMPILED_HEADER have non-empty OBJECT_DEPENDS property (e.g.
2080         changed with ADD_SOURCE_DEPENDENCIES call), its value is lost.
2081
2082         * Source/cmake/WebKitMacros.cmake:
2083
2084 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2085
2086         [GTK] Do not use the C API in WebGtkExtensionManager
2087         https://bugs.webkit.org/show_bug.cgi?id=173408
2088
2089         Reviewed by Michael Catanzaro.
2090
2091         Update exported symbol signature.
2092
2093         * Source/cmake/gtksymbols.filter:
2094
2095 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2096
2097         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2098         https://bugs.webkit.org/show_bug.cgi?id=173103
2099
2100         Reviewed by Xabier Rodriguez-Calvar.
2101
2102         * Source/cmake/OptionsWPE.cmake: Expose the ENABLE_ENCRYPTED_MEDIA
2103         configuration option, keeping it disabled by default.
2104
2105 2017-06-09  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2106
2107         [GStreamer][EME] Remove the legacy code that was not even official and is deprecated
2108         https://bugs.webkit.org/show_bug.cgi?id=173096
2109
2110         Reviewed by Žan Doberšek.
2111
2112         * Source/cmake/OptionsWPE.cmake: Remove LEGACY_ENCRYPTED_MEDIA support
2113
2114 2017-06-07  Ryosuke Niwa  <rniwa@webkit.org>
2115
2116         IsInShadowTreeFlag does not get updated for a non-container node
2117         https://bugs.webkit.org/show_bug.cgi?id=173084
2118
2119         Reviewed by Antti Koivisto.
2120
2121         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2122
2123 2017-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2124
2125         [WPE] Enable resource usage
2126         https://bugs.webkit.org/show_bug.cgi?id=173054
2127
2128         Reviewed by Žan Doberšek.
2129
2130         Add private option for resource usage enabled by default.
2131
2132         * Source/cmake/OptionsWPE.cmake:
2133
2134 2017-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2135
2136         Remove legacy INSPECTOR_SERVER implementation
2137         https://bugs.webkit.org/show_bug.cgi?id=172966
2138
2139         Reviewed by Žan Doberšek.
2140
2141         * Source/PlatformWin.cmake:
2142
2143 2017-06-07  Loïc Yhuel  <loic.yhuel@softathome.com>
2144
2145         [CMake] Only force response files for Ninja with CMake < 3.2 on Linux
2146         https://bugs.webkit.org/show_bug.cgi?id=173066
2147
2148         Reviewed by Michael Catanzaro.
2149
2150         CMake automatically uses response files when needed, but the limit was
2151         wrong on Linux before 3.2.
2152
2153         * Source/cmake/OptionsCommon.cmake:
2154
2155 2017-06-07  Zan Dobersek  <zdobersek@igalia.com>
2156
2157         [GCrypt] RSA-PSS support
2158         https://bugs.webkit.org/show_bug.cgi?id=172856
2159
2160         Reviewed by Jiewen Tan.
2161
2162         * Source/cmake/OptionsGTK.cmake: Set and expose the USE_GCRYPT preprocessor macro when
2163         SUBTLE_CRYPTO is enabled.
2164         * Source/cmake/OptionsWPE.cmake: Match the GTK+ port in demanding at least version 1.7.0
2165         of libgcrypt. Also set and expose the USE_GCRYPT preprocessor macro.
2166
2167 2017-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2168
2169         [WPE] Enable remote inspector
2170         https://bugs.webkit.org/show_bug.cgi?id=172971
2171
2172         Reviewed by Žan Doberšek.
2173
2174         Add private option for remote inspector enabled by default.
2175
2176         * Source/cmake/OptionsWPE.cmake:
2177
2178 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2179
2180         [JSCOnly] Build static jsc.exe on Windows
2181         https://bugs.webkit.org/show_bug.cgi?id=172833
2182
2183         Reviewed by Konstantin Tokarev.
2184
2185         * Source/cmake/OptionsJSCOnly.cmake:
2186
2187 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
2188
2189         [CMake] Do not pass -Wno-expansion-to-defined to Clang <4.0.0
2190         https://bugs.webkit.org/show_bug.cgi?id=172750
2191
2192         Reviewed by Michael Catanzaro.
2193
2194         * Source/cmake/OptionsCommon.cmake:
2195
2196 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
2197
2198         Consider enabling -Wno-expansion-to-defined for gcc 7
2199         https://bugs.webkit.org/show_bug.cgi?id=167643
2200
2201         Reviewed by Žan Doberšek.
2202
2203         * Source/cmake/OptionsCommon.cmake: Pass -Wno-expansion-to-defined to
2204         GCC, the flag is supported all the way back to version 4.9, which is
2205         the oldest we support
2206
2207 2017-05-26  Don Olmstead  <don.olmstead@am.sony.com>
2208
2209         [CMake] Wrap CODE_GENERATOR_PREPROCESSOR_EXECUTABLE on Windows hosts
2210         https://bugs.webkit.org/show_bug.cgi?id=172553
2211
2212         Reviewed by Brent Fulgham.
2213
2214         * Source/cmake/OptionsCommon.cmake:
2215
2216 2017-05-26  Adrian Perez de Castro  <aperez@igalia.com>
2217
2218         [CMake] Pass -fdiagnostics-color=always to GCC when building with Ninja
2219         https://bugs.webkit.org/show_bug.cgi?id=172638
2220
2221         Reviewed by Yusuke Suzuki.
2222
2223         The oldest version of GCC supported for building WebKit is 4.9, which already accepts
2224         -fdiagnostics-color=, therefore it is not needed to check the compiler version.
2225
2226         * Source/cmake/OptionsCommon.cmake:
2227
2228 2017-05-25  Don Olmstead  <don.olmstead@am.sony.com>
2229
2230         [CMake][Win] Use WTF_CPU not MSCV_CXX_ARCHITECTURE_ID when determining lib directories
2231         https://bugs.webkit.org/show_bug.cgi?id=172570
2232
2233         Reviewed by Per Arne Vollan.
2234
2235         * Source/cmake/OptionsWin.cmake:
2236
2237 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
2238
2239         [CMake] Consolidate CMake code related to Cairo
2240         https://bugs.webkit.org/show_bug.cgi?id=172568
2241
2242         Reviewed by Alex Christensen.
2243
2244         * Source/cmake/OptionsGTK.cmake:
2245         * Source/cmake/OptionsWPE.cmake:
2246         * Source/cmake/OptionsWinCairo.cmake:
2247
2248 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
2249
2250         Remove dead ENABLE(FONT_LOAD_EVENTS) code
2251         https://bugs.webkit.org/show_bug.cgi?id=172517
2252
2253         Rubber-stamped by Simon Fraser.
2254
2255         * Source/cmake/OptionsMac.cmake:
2256         * Source/cmake/WebKitFeatures.cmake:
2257
2258 2017-05-22  Gwang Yoon Hwang  <yoon@igalia.com>
2259
2260         [CMake] Do not use a --no-keep-memory linker flag in 64bit system
2261         https://bugs.webkit.org/show_bug.cgi?id=172429
2262
2263         Reviewed by Michael Catanzaro.
2264
2265         * Source/cmake/OptionsCommon.cmake:
2266         In x86_64, cmake accidentally applies --no-keep-memory since MATCHES
2267         uses the given value as a regex. It reduces linking performance
2268         due to the frequent disk operations in x86_64.
2269
2270 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2271
2272         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.3 release.
2273
2274         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2275
2276 2017-05-22  Don Olmstead  <don.olmstead@am.sony.com>
2277
2278         [Win][CMake] Move MSVC compiler options to a common location
2279         https://bugs.webkit.org/show_bug.cgi?id=172230
2280
2281         Reviewed by Yusuke Suzuki.
2282
2283         * Source/cmake/OptionsMSVC.cmake: Added.
2284         * Source/cmake/OptionsWin.cmake:
2285
2286 2017-05-19  Don Olmstead  <don.olmstead@am.sony.com>
2287
2288         [CMake] Add HAVE check for __int128_t
2289         https://bugs.webkit.org/show_bug.cgi?id=172317
2290
2291         Reviewed by Yusuke Suzuki.
2292
2293         * Source/cmake/OptionsCommon.cmake:
2294
2295 2017-05-16  Zan Dobersek  <zdobersek@igalia.com>
2296
2297         [WPE] Set and expose ENABLE_DEVELOPER_MODE in build when DEVELOPER_MODE is enabled
2298         https://bugs.webkit.org/show_bug.cgi?id=172159
2299
2300         Reviewed by Carlos Garcia Campos.
2301
2302         * Source/cmake/OptionsWPE.cmake: Expose the ENABLE_DEVELOPER_MODE macro
2303         when the DEVELOPER_MODE configuration options is enabled.
2304
2305 2017-05-11  Don Olmstead  <don.olmstead@am.sony.com>
2306
2307         [CMake] Add HAVE check for regex.h
2308         https://bugs.webkit.org/show_bug.cgi?id=171950
2309
2310         Reviewed by Michael Catanzaro.
2311
2312         * Source/cmake/OptionsCommon.cmake:
2313
2314 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
2315
2316         Remove Vibration API
2317         https://bugs.webkit.org/show_bug.cgi?id=171766
2318
2319         Rubber-stamped by Alexey Proskuryakov.
2320
2321         * Source/cmake/WebKitFeatures.cmake:
2322
2323 2017-05-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2324
2325         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.2 release.
2326
2327         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2328
2329 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
2330
2331         [Win] Specify source file type when preprocessing IDL files
2332         https://bugs.webkit.org/show_bug.cgi?id=171864
2333
2334         Reviewed by Alex Christensen.
2335
2336         * Source/cmake/OptionsCommon.cmake:
2337
2338 2017-05-10  Adrian Perez de Castro  <aperez@igalia.com>
2339
2340         Remove some last remnants of the EFL port
2341         https://bugs.webkit.org/show_bug.cgi?id=171922
2342
2343         Reviewed by Antonio Gomes.
2344
2345         The EFL port is no more.
2346
2347         * Source/PlatformEfl.cmake: Removed.
2348
2349 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
2350
2351         Enable FTL JIT by default on AArch64
2352         https://bugs.webkit.org/show_bug.cgi?id=144039
2353
2354         Reviewed by Yusuke Suzuki.
2355
2356         * Source/cmake/OptionsWPE.cmake:
2357         * Source/cmake/WebKitFeatures.cmake: Set FTL as enabled by default
2358         when targeting either WTF_CPU_X86_64 or WTF_CPU_ARM64.
2359
2360 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
2361
2362         Upstream the WPE port
2363         https://bugs.webkit.org/show_bug.cgi?id=171110
2364
2365         Reviewed by Alex Christensen.
2366
2367         webkit-dev thread:
2368         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
2369
2370         * CMakeLists.txt: Add the WPE port identifier.
2371         * Source/cmake/FindLibGBM.cmake: Added.
2372         * Source/cmake/FindWPEBackend-mesa.cmake: Added.
2373         * Source/cmake/FindWPEBackend.cmake: Added.
2374         * Source/cmake/OptionsWPE.cmake: Added.
2375
2376 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2377
2378         Unreviewed, rolling out r216206.
2379         https://bugs.webkit.org/show_bug.cgi?id=171714
2380
2381         Multiple LayoutTests crashing in Document::page() (Requested
2382         by ap on #webkit).
2383
2384         Reverted changeset:
2385
2386         "Remove support for legacy Notifications"
2387         https://bugs.webkit.org/show_bug.cgi?id=171487
2388         http://trac.webkit.org/changeset/216206
2389
2390 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
2391
2392         [Win] Remove redundant macros that are set in the CMake config
2393         https://bugs.webkit.org/show_bug.cgi?id=171571
2394
2395         Reviewed by Brent Fulgham.
2396
2397         * Source/cmake/OptionsWin.cmake:
2398
2399 2017-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2400
2401         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.1 release.
2402
2403         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2404
2405 2017-05-01  Aakash Jain  <aakash_jain@apple.com>
2406
2407         fix check-webkit-style errors in webkitpy about two blank lines before class definitions
2408         https://bugs.webkit.org/show_bug.cgi?id=171509
2409
2410         Reviewed by Alexey Proskuryakov.
2411
2412         * Scripts/webkitpy/common/config/committers.py: Added two blank lines before class definition.
2413         * Scripts/webkitpy/layout_tests/models/test_run_results.py: Ditto.
2414         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Ditto.
2415         * Scripts/webkitpy/port/base_unittest.py: Ditto.
2416         * Scripts/webkitpy/port/device.py: Ditto.
2417         * Scripts/webkitpy/port/linux_get_crash_log.py: Ditto.
2418         * Scripts/webkitpy/style/checkers/featuredefines.py: Ditto.
2419         * Scripts/webkitpy/style/checkers/jsonchecker.py: Ditto.
2420         * Scripts/webkitpy/tool/bot/patchanalysistask.py: Ditto.
2421         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Ditto.
2422         (ManagerTest.test_uses_custom_device.MockCustomDevicePort): Added blank line before method.
2423         (ManagerTest.test_uses_custom_device): Removed extra blank line at end of file.
2424
2425 2017-04-25  Daniel Bates  <dabates@apple.com>
2426
2427         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
2428         https://bugs.webkit.org/show_bug.cgi?id=136452
2429         <rdar://problem/23412620>
2430
2431         Reviewed by Brent Fulgham.
2432
2433         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
2434
2435         * Source/cmake/OptionsMac.cmake:
2436         * Source/cmake/OptionsWin.cmake:
2437
2438 2017-04-24  Zan Dobersek  <zdobersek@igalia.com>
2439
2440         Unreviewed follow-up to r215681.
2441
2442         * Source/cmake/OptionsGTK.cmake: Don't re-define the ENABLE_SUBTLE_CRYPTO
2443         macro, that's already done by the option macro.
2444
2445 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2446
2447         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
2448         https://bugs.webkit.org/show_bug.cgi?id=166680
2449
2450         Reviewed by Michael Catanzaro.
2451
2452         Add private option for ENABLE_REMOTE_INSPECTOR and enabled it by default.
2453
2454         * Source/cmake/OptionsGTK.cmake:
2455
2456 2017-04-24  Zan Dobersek  <zdobersek@igalia.com>
2457
2458         [GTK] Make the ENABLE_SUBTLE_CRYPTO option depend on libgcrypt 1.7.0
2459         https://bugs.webkit.org/show_bug.cgi?id=171112
2460
2461         Reviewed by Michael Catanzaro.
2462
2463         * Source/cmake/OptionsGTK.cmake: When ENABLE_SUBTLE_CRYPTO feature is enabled,
2464         the detected libgcrypt library version should be at least 1.7.0 since we'll be
2465         relying on API that was introduced in that version.
2466
2467 2017-04-21  Konstantin Tokarev  <annulen@yandex.ru>
2468
2469         [cmake] WTF target should not have wtf and subdirectries in public interface
2470         https://bugs.webkit.org/show_bug.cgi?id=171115
2471
2472         Reviewed by Michael Catanzaro.
2473
2474         In r209665 WEBCORE_FRAMEWORK macro started to export INCLUDE_DIRECTORIES of
2475         targets as their public interface, so that linked targets can use them
2476         implicitly without copying directory lists around. This matches existing
2477         practice for all targets except WTF, headers from which are always included
2478         with full path starting from "<wtf/...".
2479
2480         Since r209665 it became possible to include headers from wtf or its
2481         subdirectories in CMake builds without using "<wtf/..." path. It should
2482         not be allowed.
2483
2484         * Source/cmake/WebKitMacros.cmake: Support xxx_PRIVATE_HEADERS
2485         CMake variables.
2486
2487 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
2488
2489         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
2490         https://bugs.webkit.org/show_bug.cgi?id=171071
2491
2492         Reviewed by Michael Catanzaro.
2493
2494         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
2495         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
2496         be available for all ports.
2497
2498         * Source/cmake/OptionsGTK.cmake:
2499         * Source/cmake/WebKitFS.cmake:
2500         * Source/cmake/WebKitMacros.cmake:
2501
2502 2017-04-17  Yusuke Suzuki  <utatane.tea@gmail.com>
2503
2504         [JSCOnly] Fix build failures in macOS
2505         https://bugs.webkit.org/show_bug.cgi?id=170887
2506
2507         Reviewed by Alex Christensen.
2508
2509         Align ICU header configuration to MacCMake port.
2510
2511         * Source/cmake/OptionsJSCOnly.cmake:
2512
2513 2017-04-16  Sam Weinig  <sam@webkit.org>
2514
2515         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
2516         https://bugs.webkit.org/show_bug.cgi?id=170843
2517
2518         Reviewed by Chris Dumez.
2519
2520         * Source/cmake/WebKitMacros.cmake:
2521         Update extension of IDLAttributes to .json
2522
2523 2017-04-13  Don Olmstead  <don.olmstead@am.sony.com>
2524
2525         [WinCairo] Assign WEBKIT_LIBRARIES_DIR to CMAKE_PREFIX_PATH
2526         https://bugs.webkit.org/show_bug.cgi?id=170797
2527
2528         Reviewed by Alex Christensen.
2529
2530         * Source/cmake/FindCairo.cmake:
2531         * Source/cmake/OptionsWin.cmake:
2532
2533 2017-04-11  Zan Dobersek  <zdobersek@igalia.com>
2534
2535         [CMake] OpenWebRTC libraries path isn't properly deduced
2536         https://bugs.webkit.org/show_bug.cgi?id=170670
2537
2538         Reviewed by Carlos Garcia Campos.
2539
2540         When using OpenWebRTC installation that's outside of the usual Jhbuild
2541         installation directories, the library paths are ignored because the
2542         dependency libraries are simply gathered from the pkg-config file.
2543
2544         Instead, the pkg-config data should be used to search for the correct
2545         paths to the header and library locations. Both libopenwebrtc and
2546         libopenwebrtc_gst libraries are needed, so the two library paths are
2547         concatenated into the OPENWEBRTC_LIBRARIES variable.
2548
2549         * Source/cmake/FindOpenWebRTC.cmake:
2550
2551 2017-04-08  Ting-Wei Lan  <lantw44@gmail.com>
2552
2553         Elftoolchain ar doesn't support response files
2554         https://bugs.webkit.org/show_bug.cgi?id=170105
2555
2556         Reviewed by Michael Catanzaro.
2557
2558         WebKit enables the use of response files when cmake and ninja is used.
2559         However, the default implementation of ar command used in FreeBSD, which
2560         is part of elftoolchain project, doesn't support reading arguments from
2561         response files. To avoid causing undefined reference error on FreeBSD,
2562         we disable the use of response files when elftoolchain ar is detected.
2563
2564         * Source/cmake/OptionsCommon.cmake:
2565
2566 2017-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2567
2568         Unreviewed, rolling out r215150.
2569
2570         Broke buildbot
2571
2572         Reverted changeset:
2573
2574         "[CMake] Don't force-enable response files when using Ninja
2575         generator"
2576         https://bugs.webkit.org/show_bug.cgi?id=170105
2577         http://trac.webkit.org/changeset/215150
2578
2579 2017-04-08  Ting-Wei Lan  <lantw44@gmail.com>
2580
2581         [CMake] Don't force-enable response files when using Ninja generator
2582         https://bugs.webkit.org/show_bug.cgi?id=170105
2583
2584         Reviewed by Michael Catanzaro.
2585
2586         Not all platforms support response files, and unconditionally enabling
2587         response files is known to cause build failure for some platforms.
2588         Since WebKit builds fine on many platforms without force-enabling
2589         response files and bug 129771 didn't mention which platform required
2590         it, we remove it instead of adding more platform checks.
2591
2592         * Source/cmake/OptionsCommon.cmake:
2593
2594 2017-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2595
2596         [GTK] Various build errors when plugin support is disabled
2597         https://bugs.webkit.org/show_bug.cgi?id=170015
2598
2599         Reviewed by Carlos Garcia Campos.
2600
2601         Allow building with ENABLE_NETSCAPE_PLUGIN_API=ON and ENABLE_X11_TARGET=OFF. This should be
2602         possible as Carlos worked to ensure windowless plugins work properly outside X11. The GTK2
2603         plugin process still depends on ENABLE_X11_TARGET because a plugin that uses GTK+ surely
2604         wants to display a window, and is not going to work outside X11. (If the plugin links to
2605         GTK+ but does not display a window, it's dumb and deserves to be broken.)
2606
2607         Also, make ENABLE_PLUGIN_PROCESS conditional on ENABLE_NETSCAPE_PLUGIN_API, not
2608         ENABLE_X11_TARGET.
2609
2610         * Source/cmake/OptionsGTK.cmake:
2611
2612 2017-04-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2613
2614         [CMake][Windows] WebKitGUID.lib should be built with the release CRT
2615         https://bugs.webkit.org/show_bug.cgi?id=170593
2616
2617         Reviewed by Brent Fulgham.
2618
2619         Source/cmake/OptionsWin.cmake has a trick to force using the
2620         release CRT even for debug build configuration. But, this works
2621         only for C++, but for C. As the result, WebKitGUID.lib is built
2622         with the debug CRT in debug build configuration because it has C
2623         source files.
2624
2625         * Source/cmake/OptionsWin.cmake: Process CMAKE_C_FLAGS_* as well as CMAKE_CXX_FLAGS_*.
2626
2627 2017-04-06  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
2628
2629         [GTK] Build fails when using icecream, ccache and cmake 3.6
2630         https://bugs.webkit.org/show_bug.cgi?id=170498
2631
2632         Reviewed by Michael Catanzaro.
2633
2634         Disable ninja response file when using icecream, ccache and cmake > 3.5.
2635
2636         * Source/cmake/OptionsCommon.cmake:
2637
2638 2017-04-04  Ross Kirsling  <ross.kirsling@sony.com>
2639
2640         [CMake] Enforce Python 2
2641         https://bugs.webkit.org/show_bug.cgi?id=170439
2642
2643         Reviewed by Brent Fulgham.
2644
2645         * Source/cmake/WebKitCommon.cmake: Fail build immediately if Python 3 is detected.
2646
2647 2017-03-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2648
2649         [GTK] Add MIMETypeRegistry implementation using xdgmime and remove the GTK+ one
2650         https://bugs.webkit.org/show_bug.cgi?id=170001
2651
2652         Reviewed by Michael Catanzaro.
2653
2654         * Source/CMakeLists.txt: Compile xdgmime if USE_XDGMIME is ON.
2655         * Source/cmake/OptionsGTK.cmake: Set USE_XDGMIME to ON.
2656
2657 2017-03-10  Per Arne Vollan  <pvollan@apple.com>
2658
2659         Unreviewed Win64 build fix. FTL is not ready to be turned on yet.
2660
2661         * Source/cmake/OptionsWin.cmake:
2662
2663 2017-03-10  Alex Christensen  <achristensen@webkit.org>
2664
2665         Win64 build fix.
2666
2667         * Source/cmake/OptionsWin.cmake:
2668         WASM got turned on on Win64.  Judging by the state of WasmMemory.cpp, I'm going to
2669         assume this was a mistake and turn it off until someone writes a version that uses
2670         VirtualAlloc/VirtualFree instead of mmap.
2671         The FTL seems a bit unstable, though.  This fixes the build, but more fixes are necessary.
2672
2673 2017-03-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2674
2675         Unreviewed, fix AppleWin build
2676         https://bugs.webkit.org/show_bug.cgi?id=164032
2677
2678         * Source/cmake/WebKitFeatures.cmake:
2679
2680 2017-03-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2681
2682         [GTK][JSCOnly] Enable WebAssembly on Linux environment
2683         https://bugs.webkit.org/show_bug.cgi?id=164032
2684
2685         Reviewed by Michael Catanzaro.
2686
2687         * Source/cmake/OptionsGTK.cmake:
2688         * Source/cmake/OptionsJSCOnly.cmake:
2689         * Source/cmake/OptionsMac.cmake:
2690         * Source/cmake/WebKitFeatures.cmake:
2691
2692 2017-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2693
2694         Unreviewed, remove stray period from readme
2695
2696         * ReadMe.md:
2697
2698 2017-03-03  Dean Jackson  <dino@apple.com>
2699
2700         Add WebGPU compile flag and experimental feature flag
2701         https://bugs.webkit.org/show_bug.cgi?id=169161
2702         <rdar://problem/30846689>
2703
2704         Reviewed by Tim Horton.
2705
2706         Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
2707         and an InternalSetting.
2708
2709         * Source/cmake/OptionsMac.cmake:
2710         * Source/cmake/WebKitFeatures.cmake:
2711         * Source/cmake/tools/vsprops/FeatureDefines.props:
2712         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2713
2714 2017-03-01  Andy Estes  <aestes@apple.com>
2715
2716         Build libwebrtc as part of the All Source scheme in WebKit.xcworkspace.
2717
2718         Rubber-stamped by Tim Horton.
2719
2720         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
2721
2722 2017-02-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2723
2724         Unreviewed. Bump GTK+ versions numbers.
2725
2726         * Source/cmake/OptionsGTK.cmake:
2727
2728 2017-02-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2729
2730         Unreviewed, rolling out r213024.
2731
2732         Wrong version numbers
2733
2734         Reverted changeset:
2735
2736         "[GTK] Unreviewed, bump GTK version numbers also on trunk"
2737         http://trac.webkit.org/changeset/213024
2738
2739 2017-02-26  Michael Catanzaro  <mcatanzaro@igalia.com>
2740
2741         [GTK] Unreviewed, bump GTK version numbers also on trunk
2742
2743         * Source/cmake/OptionsGTK.cmake:
2744
2745 2017-02-23  Tomas Popela  <tpopela@redhat.com>
2746
2747         [GTK] Compilation fails if using ninja together with icecream and cmake > 3.5
2748         https://bugs.webkit.org/show_bug.cgi?id=168770
2749
2750         Reviewed by Carlos Garcia Campos.
2751
2752         If using cmake >= 3.6 together with ninja generator and icecream, the
2753         build will fail as icecream does not correctly handle the response
2754         files and it's not passing compiler flags from there to the compiler
2755         itself (in our case it's not passing -fPIC which leads to the
2756         failure while linking). Don't enable the ninja's response files
2757         support if we fulfill the preconditions.
2758
2759         * Source/cmake/OptionsCommon.cmake:
2760
2761 2017-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2762
2763         Add GTK+ build instruction to ReadMe.md
2764         https://bugs.webkit.org/show_bug.cgi?id=168745
2765
2766         Reviewed by Michael Catanzaro.
2767
2768         Add instructions to build GTK+ port.
2769
2770         Removed the instruction to set the default configuration since that didn't seem important.
2771
2772         * ReadMe.md:
2773
2774 2017-02-22  Alberto Garcia  <berto@igalia.com>
2775
2776         [GTK] [2.15.90] Disable RESOURCE_USAGE on non-Linux systems
2777         https://bugs.webkit.org/show_bug.cgi?id=168714
2778
2779         Reviewed by Carlos Garcia Campos.
2780
2781         * Source/cmake/OptionsGTK.cmake:
2782
2783 2017-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2784
2785         Remove the extra `'s errornously added during the final editing.
2786
2787         * ReadMe.md:
2788
2789 2017-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2790
2791         Add ReadMe.md to WebKit
2792         https://bugs.webkit.org/show_bug.cgi?id=168413
2793
2794         Reviewed by Chris Dumez.
2795
2796         Add a ReadMe.md to be read on https://github.com/WebKit/webkit based on webkit.org content.
2797
2798         * ReadMe.md: Added.
2799
2800 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2801
2802         Remove ENABLE_THREADED_COMPOSITOR build option
2803         https://bugs.webkit.org/show_bug.cgi?id=168606
2804
2805         Reviewed by Michael Catanzaro.
2806
2807         * Source/cmake/OptionsGTK.cmake:
2808         * Source/cmake/WebKitFeatures.cmake:
2809
2810 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
2811
2812         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
2813         https://bugs.webkit.org/show_bug.cgi?id=167693
2814
2815         Reviewed by Sergio Villar Senin.
2816
2817         CSS Grid Layout has been enabled by default in r211415,
2818         and Safari 10.1 is shipping it.
2819         It seems like a good moment to remove the compilation flag.
2820
2821         * Source/cmake/OptionsMac.cmake:
2822         * Source/cmake/OptionsWin.cmake:
2823         * Source/cmake/WebKitFeatures.cmake:
2824         * Source/cmake/tools/vsprops/FeatureDefines.props:
2825         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2826
2827 2017-02-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2828
2829         Remove EFL from Source/cmake
2830         https://bugs.webkit.org/show_bug.cgi?id=168512
2831
2832         Reviewed by Carlos Garcia Campos.
2833
2834         * Source/cmake/OptionsEfl.cmake: Removed.
2835         * Source/cmake/WebKitPackaging.cmake:
2836         * Source/cmake/eflsymbols.filter: Removed.
2837
2838 2017-02-16  Konstantin Tokarev  <annulen@yandex.ru>
2839
2840         [cmake] Use env command to set PYTHONPATH if cmake is new enough
2841         https://bugs.webkit.org/show_bug.cgi?id=156833
2842
2843         Reviewed by Alex Christensen.
2844
2845         This change fixes 2 issues when CMake >= 3.1 is used:
2846         - When PYTHONPATH contains special characters, CMake adds quotes around
2847         "PYTHONPATH=..." and produces broken build command in non-WIN32 case.
2848         - On WIN32, unix-like shell can be used instead of cmd.exe, but this case
2849         cannot be easily detected in cmake.
2850
2851         * Source/cmake/WebKitMacros.cmake:
2852
2853 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2854
2855         Unreviewed. Add ENABLE_INTERSECTION_OBSERVER option to CMake.
2856
2857         It's now a runtime enabled feature so we should always build it.
2858
2859         Fixes: intersection-observer/intersection-observer-entry-interface.html
2860                intersection-observer/intersection-observer-interface.html
2861
2862         * Source/cmake/WebKitFeatures.cmake:
2863
2864 2017-02-10  Brian Burg  <bburg@apple.com>
2865
2866         Add basic debugging macros for CMake
2867         https://bugs.webkit.org/show_bug.cgi?id=161538
2868
2869         Reviewed by Michael Catanzaro.
2870
2871         It's useful to be able to dump the state of everything when debugging
2872         CMake build problems, especially when they happen on EWS (but not locally).
2873
2874         Start with macros for:
2875             - dumping out all CMake variables
2876             - dumping all executed commands (by turning off pretty-printing)
2877
2878         * Source/cmake/WebKitMacros.cmake:
2879
2880 2017-02-09  Alex Christensen  <achristensen@webkit.org>
2881
2882         Build libwebrtc on bots without using it yet
2883         https://bugs.webkit.org/show_bug.cgi?id=168062
2884
2885         Reviewed by Brent Fulgham.
2886
2887         * Source/Makefile:
2888
2889 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
2890
2891         [GTK][Efl] Do not require LibXslt if XSLT is disabled
2892         https://bugs.webkit.org/show_bug.cgi?id=167931
2893
2894         This fixes build with --no-xslt, when the libxslt dev files are not installed.
2895
2896         Reviewed by Michael Catanzaro.
2897
2898         * Source/cmake/OptionsEfl.cmake:
2899         * Source/cmake/OptionsGTK.cmake:
2900
2901 2017-02-03  Konstantin Tokarev  <annulen@yandex.ru>
2902
2903         [CMake] RelWithDebInfo builds are super broken at runtime
2904         https://bugs.webkit.org/show_bug.cgi?id=163897
2905
2906         Reviewed by Michael Catanzaro.
2907
2908         * Source/cmake/OptionsCommon.cmake: Apply -fno-strict-aliasing,
2909         -fno-exceptions, and -fno-rtti flags to all configurations,
2910         instead of only "Release".
2911
2912 2017-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2913
2914         [GTK] Add initial implementation of resource usage overlay
2915         https://bugs.webkit.org/show_bug.cgi?id=167731
2916
2917         Reviewed by Michael Catanzaro.
2918
2919         Enable RESOURCE_USAGE.
2920
2921         * Source/cmake/OptionsGTK.cmake:
2922
2923 2017-02-02  Alex Christensen  <achristensen@webkit.org>
2924
2925         Build fix after r211602
2926         https://bugs.webkit.org/show_bug.cgi?id=167758
2927
2928         * Source/Makefile:
2929         Don't build libwebrtc by default.  It's not used yet anyway.
2930
2931 2017-02-02  David Kilzer  <ddkilzer@apple.com>
2932
2933         Make the Makefile great again after r211570, r211572
2934
2935         * Makefile: Restore tabs and ending newline.
2936
2937 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
2938
2939         Unreviewed build fix after r211570
2940
2941         * Makefile: Placed back.
2942
2943 2017-02-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2944
2945         Propagate networking errors correctly for import() operator
2946         https://bugs.webkit.org/show_bug.cgi?id=167501
2947
2948         Reviewed by Ryosuke Niwa.
2949
2950         * Source/ModuleFetchFailureKind.h: Added.
2951
2952 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2953
2954         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.4 release.
2955
2956         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
2957
2958 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2959
2960         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2961         https://bugs.webkit.org/show_bug.cgi?id=167394
2962
2963         Reviewed by Ryosuke Niwa.
2964
2965         * Source/cmake/OptionsEfl.cmake:
2966         * Source/cmake/OptionsWin.cmake:
2967         * Source/cmake/WebKitFeatures.cmake:
2968         * Source/cmake/tools/vsprops/FeatureDefines.props:
2969         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2970
2971 2017-01-22  Don Olmstead <don.olmstead@am.sony.com> and Myles C. Maxfield <mmaxfield@apple.com>
2972
2973         Introducing the Platform Abstraction Layer (PAL)
2974         https://bugs.webkit.org/show_bug.cgi?id=143358
2975
2976         Reviewed by Alex Christensen.
2977
2978         * CMakeLists.txt:
2979         * Source/CMakeLists.txt:
2980         * Source/cmake/WebKitFS.cmake:
2981
2982 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2983
2984         Remove outdated ENABLE(CSP_NEXT) build flag
2985         https://bugs.webkit.org/show_bug.cgi?id=167252
2986
2987         Reviewed by Brent Fulgham.
2988
2989         * Source/cmake/OptionsMac.cmake:
2990         * Source/cmake/OptionsWin.cmake:
2991         * Source/cmake/WebKitFeatures.cmake:
2992         * Source/cmake/tools/vsprops/FeatureDefines.props:
2993         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
2994
2995 2017-01-20  Youenn Fablet  <youenn@apple.com>
2996
2997         [WebRTC] Add libwebrtc build infrastructure
2998         https://bugs.webkit.org/show_bug.cgi?id=167207
2999
3000         Reviewed by Alex Christensen.
3001
3002         * WebKit.xcworkspace/contents.xcworkspacedata:
3003
3004 2017-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3005
3006         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.3 release.
3007
3008         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3009
3010 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3011
3012         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3013         https://bugs.webkit.org/show_bug.cgi?id=116551
3014         <rdar://problem/13949830>
3015
3016         Reviewed by Alex Christensen.
3017
3018         * Source/cmake/OptionsEfl.cmake:
3019         * Source/cmake/OptionsWin.cmake:
3020         * Source/cmake/WebKitFeatures.cmake:
3021         * Source/cmake/tools/vsprops/FeatureDefines.props:
3022         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3023
3024 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3025
3026         Remove the REQUEST_ANIMATION_FRAME flag
3027         https://bugs.webkit.org/show_bug.cgi?id=156980
3028         <rdar://problem/25906849>
3029
3030         Reviewed by Simon Fraser.
3031
3032         * Source/cmake/OptionsEfl.cmake:
3033         * Source/cmake/OptionsWin.cmake:
3034         * Source/cmake/WebKitFeatures.cmake:
3035         * Source/cmake/tools/vsprops/FeatureDefines.props:
3036         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3037
3038 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3039
3040         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3041         https://bugs.webkit.org/show_bug.cgi?id=167043
3042
3043         Reviewed by Darin Adler.
3044
3045         * Source/cmake/tools/vsprops/FeatureDefines.props:
3046         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3047
3048 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3049
3050         Remove ENABLE(DETAILS_ELEMENT) guards
3051         https://bugs.webkit.org/show_bug.cgi?id=167042
3052
3053         Reviewed by Alex Christensen.
3054
3055         * Source/cmake/OptionsMac.cmake:
3056         * Source/cmake/OptionsWin.cmake:
3057         * Source/cmake/WebKitFeatures.cmake:
3058         * Source/cmake/tools/vsprops/FeatureDefines.props:
3059         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3060
3061 2017-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3062
3063         [CMake] Clean up SHARED_CORE option
3064         https://bugs.webkit.org/show_bug.cgi?id=167004
3065
3066         Reviewed by Alex Christensen.
3067
3068         * CMakeLists.txt:
3069
3070 2016-12-21  Konstantin Tokarev  <annulen@yandex.ru>
3071
3072         set PYTHONPATH in separate COMMAND doesn't work with all CMake generators
3073         https://bugs.webkit.org/show_bug.cgi?id=164997
3074
3075         Reviewed by Alex Christensen.
3076
3077         Fix for r201413.
3078
3079         * Source/cmake/WebKitMacros.cmake:
3080
3081 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3082
3083         [EFL] bump EFL version to 1.18.4
3084         https://bugs.webkit.org/show_bug.cgi?id=166004
3085
3086         Reviewed by Gyuyoung Kim.
3087
3088         * Source/cmake/OptionsEfl.cmake: Use efl-1.18.4 instead of 1.18.1.
3089
3090 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3091
3092         Remove flex and bison build dependencies; commit generated XPath parser
3093         https://bugs.webkit.org/show_bug.cgi?id=165783
3094
3095         Reviewed by Brent Fulgham.
3096
3097         * Source/cmake/WebKitCommon.cmake:
3098         * Source/cmake/WebKitMacros.cmake:
3099
3100 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3101
3102         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3103         https://bugs.webkit.org/show_bug.cgi?id=165686
3104
3105         Reviewed by Michael Catanzaro.
3106
3107         This change reduces duplication of include path lists between modules,
3108         and reduces future need for fixes like r209605 (broken build because of
3109         WebCore header suddenly becoming used in WebKit2).
3110
3111         * Source/cmake/WebKitMacros.cmake:
3112
3113 2016-11-30  Brent Fulgham  <bfulgham@apple.com>
3114
3115         [Win] Apple build is using incorrect ICU library (if present)
3116         https://bugs.webkit.org/show_bug.cgi?id=164934
3117         <rdar://problem/29329654>
3118
3119         Reviewed by Alex Christensen.
3120
3121         Move the 'icuuc.lib' and 'icuin.lib' library names to the end of the set of choices when searching for ICU.
3122         so that we preferentially select the 'new' version of these libraries if they are available.
3123
3124         * Source/cmake/FindICU.cmake:
3125
3126 2016-11-23  Zan Dobersek  <zdobersek@igalia.com>
3127
3128         Remove ENABLE_ASSEMBLER_WX_EXCLUSIVE code
3129         https://bugs.webkit.org/show_bug.cgi?id=165027
3130
3131         Reviewed by Darin Adler.
3132
3133         * Source/cmake/WebKitFeatures.cmake: Remove the ENABLE_ASSEMBLER_WX_EXCLUSIVE option.
3134
3135 2016-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3136
3137         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.2 release.
3138
3139         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3140
3141 2016-11-17  Saam Barati  <sbarati@apple.com>
3142
3143         Remove async/await compile time flag and enable tests
3144         https://bugs.webkit.org/show_bug.cgi?id=164828
3145         <rdar://problem/28639334>
3146
3147         Reviewed by Yusuke Suzuki.
3148
3149         * Source/cmake/WebKitFeatures.cmake:
3150
3151 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3152
3153         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
3154         https://bugs.webkit.org/show_bug.cgi?id=164827
3155
3156         Reviewed by Ryosuke Niwa.
3157
3158         * Source/cmake/OptionsWin.cmake:
3159         * Source/cmake/WebKitFeatures.cmake:
3160         * Source/cmake/tools/vsprops/FeatureDefines.props:
3161         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3162
3163 2016-11-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3164
3165         Unreviewed, rolling out r207872.
3166         https://bugs.webkit.org/show_bug.cgi?id=162623
3167
3168         Did not disable anything, just made them public
3169
3170         Reverted changeset:
3171
3172         "[GTK][GStreamer] Disable MEDIA_SOURCE and ENCRYPTED_MEDIA_V2 by default"
3173         https://bugs.webkit.org/show_bug.cgi?id=162623
3174         http://trac.webkit.org/changeset/207872
3175
3176 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3177
3178         [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
3179         https://bugs.webkit.org/show_bug.cgi?id=164461
3180
3181         Reviewed by Michael Catanzaro.
3182
3183         * Source/cmake/OptionsEfl.cmake: Find LibGcrypt package instead of GnuTLS.
3184
3185 2016-11-05  Konstantin Tokarev  <annulen@yandex.ru>
3186
3187         [MinGW] Fixed C99/C++11 format attributes in printf-like functions
3188         https://bugs.webkit.org/show_bug.cgi?id=164448
3189
3190         Reviewed by Michael Catanzaro.
3191
3192         By default MinGW uses printf-like function provided in msvcrt.dll,
3193         however they miss support for C99/C++11 format attributes. Use MinGW
3194         implementations instead.
3195
3196         * Source/cmake/OptionsCommon.cmake: Define __USE_MINGW_ANSI_STDIO
3197
3198 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
3199
3200         Fixes to build JSCOnly on macOS
3201         https://bugs.webkit.org/show_bug.cgi?id=164379
3202
3203         Reviewed by Michael Catanzaro.
3204
3205         * Source/cmake/OptionsJSCOnly.cmake: Define BUILDING_JSCONLY__, use
3206         system ICU libraries on macOS
3207         * Source/cmake/WebKitMacros.cmake: Fixed WEBKIT_FRAMEWORK macro for
3208         static JSC
3209
3210 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
3211
3212         [cmake][MinGW] Don't use MS bitfield layout to reduce sizes of data structures
3213         https://bugs.webkit.org/show_bug.cgi?id=164026
3214
3215         Reviewed by Michael Catanzaro.
3216
3217         With MS bitfileds RegisterAtOffset becomes wider than ptrdiff_t because of
3218         different alignment requirements, invoking static_assert. Instead of
3219         muting assert for MinGW like it's done for MSVC, it's a better choice to
3220         use more dense layout, as bitfields are not used in public APIs.
3221
3222         Also, suppress MinGW warnings from "#pragma warning" which it doesn't
3223         understand.
3224
3225         * Source/cmake/OptionsCommon.cmake:
3226
3227 2016-11-02  Alex Christensen  <achristensen@webkit.org>
3228
3229         Remove Battery Status API from the tree
3230         https://bugs.webkit.org/show_bug.cgi?id=164213
3231
3232         Reviewed by Sam Weinig.
3233
3234         * Source/cmake/OptionsEfl.cmake:
3235         * Source/cmake/WebKitFeatures.cmake:
3236
3237 2016-11-02  Olivier Blin  <olivier.blin@softathome.com>
3238
3239         [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
3240         https://bugs.webkit.org/show_bug.cgi?id=163125
3241
3242         Reviewed by Michael Catanzaro.
3243
3244         * Source/cmake/OptionsGTK.cmake: Updated to use libgcrypt files instead of gnutls.
3245         At least version 1.6.0 is needed for the HMAC APIs.
3246         libgcrypt is now needed unconditionally for CryptoDigest, used by CSP.
3247
3248 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
3249
3250         [Readable Streams API] Enable creation of ReadableByteStreamController
3251         https://bugs.webkit.org/show_bug.cgi?id=164014
3252
3253         Reviewed by Youenn Fablet.
3254
3255         Added flag for the byte stream part of Readable Streams API.
3256
3257         * Source/cmake/WebKitFeatures.cmake:
3258
3259 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
3260
3261         Remove CUSTOM_ELEMENTS build flag
3262         https://bugs.webkit.org/show_bug.cgi?id=164267
3263
3264         Reviewed by Antti Koivisto.
3265
3266         Removed the build flag.
3267
3268         * Source/cmake/OptionsEfl.cmake:
3269         * Source/cmake/OptionsWin.cmake:
3270         * Source/cmake/WebKitFeatures.cmake:
3271
3272 2016-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
3273
3274         [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
3275         https://bugs.webkit.org/show_bug.cgi?id=163868
3276
3277         Reviewed by Michael Catanzaro.
3278
3279         It takes long time for generate-bindings-all.pl to generate all
3280         bindings.  So, it shows the progress while running and
3281         USES_TERMINAL option of add_custom_target have been used to invoke
3282         the command.  However, USES_TERMINAL leaves a noisy line in
3283         Ninja's neat build log of interactive build.
3284
3285         A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
3286         stop using USES_TERMINAL only in case of interactive Ninja build.
3287
3288         * Source/cmake/WebKitMacros.cmake: Added a new option
3289         SHOW_BINDINGS_GENERATION_PROGRESS.  Apended --showProgress switch
3290         of generate-bindings-all.pl and used USES_TERMINAL only if
3291         SHOW_BINDINGS_GENERATION_PROGRESS is enabled.
3292
3293 2016-10-31  Ryosuke Niwa  <rniwa@webkit.org>
3294
3295         Enable custom elements by default everywhere
3296         https://bugs.webkit.org/show_bug.cgi?id=164242
3297
3298         Reviewed by Michael Catanzaro.
3299
3300         Enable the Custom Elements API in CMake builds.
3301
3302         * Source/cmake/WebKitFeatures.cmake:
3303
3304 2016-10-30  Frederic Wang  <fwang@igalia.com>
3305
3306         Use HarfBuzz ot-math API to parse the OpenType MATH table
3307         https://bugs.webkit.org/show_bug.cgi?id=162671
3308
3309         Reviewed by Michael Catanzaro.
3310
3311         * Source/cmake/OptionsGTK.cmake: Enable internal OpenType MATH parsing for HarfBuzz < 1.3.3.
3312
3313 2016-10-30  Hyowon Kim  <hw1008.kim@samsung.com>
3314
3315         [GTK] Build break by missing geoclue-2.0.
3316         https://bugs.webkit.org/show_bug.cgi?id=164170
3317
3318         Reviewed by Michael Catanzaro.
3319
3320         Revise the module name for pkg_check_modules() in FindGeoClue2.cmake.
3321
3322         * Source/cmake/FindGeoClue2.cmake: replace geoclue-2.0 with libgeoclue-2.0.
3323
3324 2016-10-29  Fujii Hironori  <Hironori.Fujii@sony.com>
3325
3326         [CMake][Win] Visual Studio invokes make_settings.pl twice
3327         https://bugs.webkit.org/show_bug.cgi?id=163774
3328
3329         Reviewed by Michael Catanzaro.
3330
3331         build-webkit recompiles some files just after finishing
3332         build-webkit in case of using CMake VisualStudio generator because
3333         both WebCoreDerivedSources.vcxproj and WebCoreTestSupport.vcxproj
3334         triggers make_settings.pl.
3335
3336         make_settings.pl generates four files
3337         InternalSettingsGenerated.{h,cpp,idl} and SettingsMacros.h.
3338         WebCoreDerivedSources depends on SettingsMacros.h, and
3339         WebCoreTestSupport depends on InternalSettingsGenerated.cpp.
3340
3341         This problem is described in CMake documentation:
3342         <https://cmake.org/cmake/help/v3.0/command/add_custom_command.html>
3343
3344         > Do not list the output in more than one independent target that may
3345         > build in parallel or the two instances of the rule may conflict
3346
3347         To solve this problem, only SettingsMacros.h is specified as
3348         OUTPUT of add_custom_command, and other generated files are marked
3349         as BYPRODUCTS.  As the result, only WebCoreDerivedSources target
3350         triggers make_settings.pl. And other targets already have a
3351         dependency to WebCoreDerivedSources target.
3352
3353         To support earlier versions than CMake 3.2, it uses GENERATED
3354         source file property instead of BYPRODUCTS option.
3355
3356         * Source/cmake/WebKitMacros.cmake(GENERATE_SETTINGS_MACROS):
3357         Removed extra output files from OUTPUT of add_custom_command and
3358         added BYPRODUCTS option.
3359
3360 2016-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3361
3362         [CMake] Changing enabled features should trigger recompiling all IDL
3363         https://bugs.webkit.org/show_bug.cgi?id=164121
3364
3365         Reviewed by Michael Catanzaro.
3366
3367         Changing enabled features should trigger recompiling all IDL
3368         because some of them use #if.  generate-bindings-all.pl was
3369         introduced in <http://trac.webkit.org/changeset/207617>.  Before
3370         this change, updating supplemental_dependency.tmp triggered
3371         recompiling all IDL. Changing enabled features usually involves
3372         adding or removing IDL files. As the result, all IDL would be
3373         recompiled.  After the change, adding or removing IDL does not
3374         trigger recompiling all IDL. So, we need to explicitly trigger
3375         recompiling all IDL if enabled features are changed.
3376
3377         * Source/cmake/WebKitMacros.cmake(GENERATE_BINDINGS): Added
3378         cmakeconfig.h to extra dependencies.
3379
3380 2016-10-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3381
3382         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.15.1 release.
3383
3384         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
3385
3386 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
3387
3388         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
3389         https://bugs.webkit.org/show_bug.cgi?id=162928
3390
3391         Reviewed by Xabier Rodriguez-Calvar.
3392
3393         Consolidate all the source file tree changes after refactoring.
3394
3395         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
3396
3397         * Source/cmake/FindLibGcrypt.cmake: Added.
3398         * Source/cmake/OptionsGTK.cmake:
3399
3400 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
3401
3402         [GTK][GStreamer] Disable MEDIA_SOURCE and ENCRYPTED_MEDIA_V2 by default
3403         https://bugs.webkit.org/show_bug.cgi?id=162623
3404
3405         Reviewed by Xabier Rodriguez-Calvar.
3406
3407         * Source/cmake/OptionsGTK.cmake:
3408
3409 2016-10-25  Konstantin Tokarev  <annulen@yandex.ru>
3410
3411         [cmake] Don't enable ld.gold by default on non-ELF platforms
3412         https://bugs.webkit.org/show_bug.cgi?id=163946
3413
3414         Reviewed by Alex Christensen.
3415
3416         For example, MinGW toolchain may be shipped with gold, but it fails to link
3417         WebKit.
3418
3419         * Source/cmake/OptionsCommon.cmake:
3420
3421 2016-10-25  Konstantin Tokarev  <annulen@yandex.ru>
3422
3423         [cmake] Don't add -fPIC flag when on Windows (MinGW)
3424         https://bugs.webkit.org/show_bug.cgi?id=163949
3425
3426         Reviewed by Michael Catanzaro.
3427
3428         -fPIC flag does not do anything on Windows and produces warning noise
3429         with MinGW. There is no position independent code in Unix sense on
3430         32-bit Windows, and 64-bit Windows code is always relocatable.
3431
3432         For reference see
3433         https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00836.html
3434
3435         * Source/cmake/WebKitHelpers.cmake:
3436
3437 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
3438
3439         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
3440         https://bugs.webkit.org/show_bug.cgi?id=163733
3441
3442         Reviewed by Gyuyoung Kim.
3443
3444         * Source/cmake/OptionsEfl.cmake: Expose USE_GEOCLUE2 to the build properly.
3445
3446 2016-10-21  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3447
3448         WebRTC: [GTK] Add MediaEndpointOwr - an OpenWebRTC WebRTC backend
3449         https://bugs.webkit.org/show_bug.cgi?id=163327
3450
3451         Reviewed by Philippe Normand.
3452
3453         Add manual WebRTC test. Test features:
3454         - Two RTCPeerConnection instances communicate in a single browser tab.
3455         - Supports setting up bidirectional media with a single SDP dialog, as
3456           well as one direction at a time.
3457         - Strips vendor prefixes (runs in Chrome and Firefox as well)
3458         - Supports modern as well as legacy APIs (mainly to make the test run
3459           in Chrome)
3460
3461         * ManualTests/webrtc-one-tab-p2p.html: Added.
3462
3463 2016-10-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3464
3465         [GTK] Configures but fails to link with ENABLE_OPENGL=OFF
3466         https://bugs.webkit.org/show_bug.cgi?id=163449
3467
3468         Reviewed by Michael Catanzaro.
3469
3470         Remove wrong dependency of Wayland on OpenGL introduced in r190615, it should be possible to build for Wayland
3471         without GL.
3472
3473         * Source/cmake/OptionsGTK.cmake:
3474
3475 2016-10-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3476
3477         [CMake] CMake does not support the dep files for implicit dependency
3478         https://bugs.webkit.org/show_bug.cgi?id=161433
3479
3480         Reviewed by Brent Fulgham.
3481
3482         Created a Perl script to generate all IDL bindings for CMake.
3483         This script can regenerate outdated bindings by based on the
3484         supplemental dependency and dep files created by
3485         '--write-dependencies' switch of generate-bindings.pl.
3486
3487         add_custom_target is used to invoke the script instead of
3488         add_custom_command because Ninja deletes all output files before
3489         executing the command in case of add_custom_command.
3490
3491         USES_TERMINAL option of add_custom_target has two effects:
3492         1) Not buffering output of the command
3493         2) Invoking the command in the special Ninja pool which inhibits parallel build
3494         One needs to use CMake 3.2 or later to enable this feature.
3495
3496         * Source/cmake/WebKitMacros.cmake (GENERATE_BINDINGS): Included
3497         ProcessorCount.  Added a new argument 'target'.  Use
3498         add_custom_target instead of add_custom_command.  Invoke the new
3499         script.
3500
3501 2016-10-19  Alex Christensen  <achristensen@webkit.org>
3502
3503         Revert r207151
3504         https://bugs.webkit.org/show_bug.cgi?id=163675
3505
3506         Reviewed by Brent Fulgham.
3507
3508         * Source/cmake/OptionsAppleWin.cmake:
3509
3510 2016-10-18  Dean Jackson  <dino@apple.com>
3511
3512         Remove CSS_SHAPES feature definition. This should always be on.
3513         https://bugs.webkit.org/show_bug.cgi?id=163628
3514         <rdar://problem/28834613>
3515
3516         Reviewed by Tim Horton.
3517
3518         * Source/cmake/OptionsMac.cmake:
3519         * Source/cmake/OptionsWin.cmake:
3520         * Source/cmake/WebKitFeatures.cmake:
3521         * Source/cmake/tools/vsprops/FeatureDefines.props:
3522         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3523
3524 2016-10-14  Michael Catanzaro  <mcatanzaro@igalia.com>
3525
3526         [CMake] Private/unsupported build options should be marked as advanced
3527         https://bugs.webkit.org/show_bug.cgi?id=163451
3528
3529         Reviewed by Carlos Garcia Campos.
3530
3531         When checking to decide whether to mark an option as advanced, the conditional checks
3532         whether _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name} is defined. It is always defined. We
3533         need to check its value instead.
3534
3535         * Source/cmake/WebKitFeatures.cmake:
3536
3537 2016-10-13  Brian Burg  <bburg@apple.com>
3538
3539         [CMake] Split the definition of CODE_GENERATOR_PREPROCESSOR so it can be used in a custom command
3540         https://bugs.webkit.org/show_bug.cgi?id=163401
3541
3542         Reviewed by Michael Catanzaro.
3543
3544         In another patch, we need to use CODE_GENERATOR_PREPROCESSOR as the COMMAND argument
3545         when defining an add_custom_command. Previously, it has only been used as a quoted argument
3546         to various Perl code generation scripts.
3547
3548         To support both use cases, we need to be able to provide the executable and its arguments as
3549         an unbroken quoted string, and as a CMake list suitable for passing as an argument to COMMAND.
3550
3551         * Source/cmake/OptionsCommon.cmake:
3552         Split out the executable and argument string into separate variables that can be used elsewhere.
3553         Compute the final unbroken quoted string using the two separate variables to arrive at the same result.
3554
3555         * Source/cmake/WebKitMacros.cmake:
3556         Drive-by cleanup to add quotes around the use of CODE_GENERATOR_PREPROCESSOR so it matches other uses.
3557
3558 2016-10-12  Chris Dumez  <cdumez@apple.com>
3559
3560         [Web IDL] Drop support for legacy [ConstructorConditional=*]
3561         https://bugs.webkit.org/show_bug.cgi?id=163368
3562
3563         Reviewed by Ryosuke Niwa.
3564
3565         Drop ENABLE_DOM4_EVENTS_CONSTRUCTOR compiler flag.
3566
3567         * Source/cmake/OptionsEfl.cmake:
3568         * Source/cmake/OptionsMac.cmake:
3569         * Source/cmake/OptionsWin.cmake:
3570         * Source/cmake/WebKitFeatures.cmake:
3571         * Source/cmake/tools/vsprops/FeatureDefines.props:
3572         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3573
3574 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3575
3576         Remove dead networking code
3577         https://bugs.webkit.org/show_bug.cgi?id=163263
3578
3579         Reviewed by Daniel Bates.
3580
3581         * Source/cmake/OptionsAppleWin.cmake:
3582
3583 2016-10-11  Konstantin Tokarev  <annulen@yandex.ru>
3584
3585         [cmake] Make INDEXED_DATABASE_IN_WORKERS depending on INDEXED_DATABASE
3586         https://bugs.webkit.org/show_bug.cgi?id=163280
3587
3588         Reviewed by Csaba Osztrogonác.
3589
3590         * Source/cmake/WebKitFeatures.cmake:
3591
3592 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
3593
3594         [Win][Direct2D] Compile fix.
3595         https://bugs.webkit.org/show_bug.cgi?id=163273
3596
3597         Reviewed by Brent Fulgham.
3598
3599         Define USE_DIRECT2D.
3600
3601         * Source/cmake/OptionsAppleWin.cmake:
3602
3603 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
3604
3605         Add ENABLE_ENCRYPTED_MEDIA configuration option
3606         https://bugs.webkit.org/show_bug.cgi?id=163219
3607
3608         Reviewed by Darin Adler.
3609
3610         Add the ENABLE_ENCRYPTED_MEDIA configuration option to the
3611         CMake and MSVC build systems. It will be used to enable or
3612         disable the new EME implementation at build-time.
3613
3614         * Source/cmake/WebKitFeatures.cmake:
3615         * Source/cmake/tools/vsprops/FeatureDefines.props:
3616         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3617
3618 2016-10-10  Commit Queue  <commit-queue@webkit.org>
3619
3620         Unreviewed, rolling out r206972.
3621         https://bugs.webkit.org/show_bug.cgi?id=163227
3622
3623         Making EWS flaky (Requested by bfulgham_ on #webkit).
3624
3625         Reverted changeset:
3626
3627         "[CMake] CMake does not support the dep files for implicit
3628         dependency"
3629         https://bugs.webkit.org/show_bug.cgi?id=161433
3630         http://trac.webkit.org/changeset/206972
3631
3632 2016-10-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3633
3634         [CMake] CMake does not support the dep files for implicit dependency
3635         https://bugs.webkit.org/show_bug.cgi?id=161433
3636
3637         Reviewed by Brent Fulgham.
3638
3639         Created a Perl script to generate all IDL bindings for CMake.
3640         This script can regenerate outdated bindings by based on the
3641         supplemental dependency and dep files created by
3642         '--write-dependencies' switch of generate-bindings.pl.
3643
3644         add_custom_target is used to invoke the script instead of
3645         add_custom_command because Ninja deletes all output files before
3646         executing the command in case of add_custom_command.
3647
3648         USES_TERMINAL option of add_custom_target has two effects:
3649         1) Not buffering output of the command
3650         2) Invoking the command in the special Ninja pool which inhibits parallel build
3651         One needs to use CMake 3.2 or later to enable this feature.
3652
3653         * Source/cmake/WebKitMacros.cmake (GENERATE_BINDINGS): Included
3654         ProcessorCount.  Added a new argument 'target'.  Use
3655         add_custom_target instead of add_custom_command.  Invoke the new
3656         script.
3657
3658 2016-10-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3659
3660         Use 'use lib $FindBin::Bin' to append Perl module include path
3661         https://bugs.webkit.org/show_bug.cgi?id=162256
3662
3663         Reviewed by Carlos Garcia Campos.
3664
3665         * Source/cmake/WebKitMacros.cmake: Removed '-I' options from
3666         invocation of Perl.
3667
3668 2016-10-06  Brent Fulgham  <bfulgham@apple.com>
3669
3670         [Win][Direct2D] Add Direct2D CMake rules
3671         https://bugs.webkit.org/show_bug.cgi?id=162925
3672
3673         Reviewed by Brent Fulgham.
3674
3675         * Source/cmake/OptionsAppleWin.cmake: Add a new 'USE_DIRECT2D' option
3676         flag for the build. Currently this is commented out and is unused.
3677
3678 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
3679
3680         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
3681         https://bugs.webkit.org/show_bug.cgi?id=162903
3682
3683         Reviewed by Alex Christensen.
3684
3685         Rename build guards for the remaining implementation of the legacy EME API
3686         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
3687         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
3688
3689         * Source/cmake/OptionsEfl.cmake:
3690         * Source/cmake/OptionsMac.cmake:
3691         * Source/cmake/OptionsWin.cmake:
3692         * Source/cmake/WebKitFeatures.cmake:
3693         * Source/cmake/tools/vsprops/FeatureDefines.props:
3694         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3695
3696 2016-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3697
3698         [SOUP] Cleanup persistent credential storage code
3699         https://bugs.webkit.org/show_bug.cgi?id=162777
3700
3701         Reviewed by Alex Christensen.
3702
3703         Remove ENABLE(CREDENTIAL_STORAGE) build flag and replace it by USE(LIBSECRET).
3704
3705         * Source/cmake/OptionsGTK.cmake:
3706         * Source/cmake/WebKitFeatures.cmake:
3707
3708 2016-09-29  Aaron Chu  <aaron_chu@apple.com>
3709
3710         Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
3711         https://bugs.webkit.org/show_bug.cgi?id=130600
3712         <rdar://problem/16391333>
3713
3714         Reviewed by Brian Burg.
3715
3716         Added a manual test to test the node links in the Accessibility Inspector
3717         https://bugs.webkit.org/show_bug.cgi?id=130600
3718
3719         * ManualTests/accessibility/delinkified-non-navigable-links.html: Added.
3720
3721 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3722
3723         [GTK] Remove obsolete comment from OptionsGTK.cmake
3724         https://bugs.webkit.org/show_bug.cgi?id=162622
3725
3726         Reviewed by Alex Christensen.
3727
3728         * Source/cmake/OptionsGTK.cmake:
3729
3730 2016-09-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3731
3732         Unreviewed, build fix for several CMake ports after r206440
3733
3734         * Source/cmake/OptionsEfl.cmake:
3735         * Source/cmake/OptionsMac.cmake:
3736         * Source/cmake/WebKitFeatures.cmake:
3737
3738 2016-09-27  Don Olmstead  <don.olmstead@am.sony.com>
3739
3740         [CMake] Add HAVE_LOCALTIME_R definition
3741         https://bugs.webkit.org/show_bug.cgi?id=162636
3742
3743         Reviewed by Alex Christensen.
3744
3745         * Source/cmake/OptionsCommon.cmake:
3746
3747 2016-09-27  Don Olmstead  <don.olmstead@am.sony.com>
3748
3749         [CMake] Use CMake to determine HAVE_* defines
3750         https://bugs.webkit.org/show_bug.cgi?id=162368
3751
3752         Reviewed by Alex Christensen.
3753
3754         * Source/cmake/OptionsCommon.cmake:
3755
3756 2016-09-27  Konstantin Tokarev  <annulen@yandex.ru>
3757
3758         [cmake] Simplify Clang checks and prepare for compiler ID split
3759         https://bugs.webkit.org/show_bug.cgi?id=162609
3760
3761         Reviewed by Michael Catanzaro.
3762
3763         CMake 3.x introduces separate compiler id for AppleClang, making condition
3764         (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang") inappropriate as check for
3765         any clang version. Introduce COMPILER_IS_CLANG instead, which is also
3766         shorter that CMAKE_CXX_COMPILER_ID comparison.
3767
3768         * CMakeLists.txt:
3769         * Source/cmake/OptionsCommon.cmake:
3770         * Source/cmake/WebKitHelpers.cmake:
3771         * Source/cmake/OptionsEfl.cmake: Use CMAKE_COMPILER_IS_GNUCXX instead of
3772         !Clang check because this is what was really meant here.
3773
3774 2016-09-27  Konstantin Tokarev  <annulen@yandex.ru>
3775
3776         [cmake] Added COMPILER_IS_GCC_OR_CLANG variable to simplify conditions.
3777         https://bugs.webkit.org/show_bug.cgi?id=162605
3778
3779         Reviewed by Michael Catanzaro.
3780
3781         * CMakeLists.txt:
3782         * Source/cmake/OptionsCommon.cmake:
3783         * Source/cmake/WebKitHelpers.cmake:
3784
3785 2016-09-26  Daniel Bates  <dabates@apple.com>
3786
3787         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
3788         https://bugs.webkit.org/show_bug.cgi?id=162365
3789
3790         Reviewed by Simon Fraser.
3791
3792         * Source/cmake/OptionsMac.cmake:
3793         * Source/cmake/WebKitFeatures.cmake: Substitute ENABLE_TEXT_AUTOSIZING for ENABLE_IOS_TEXT_AUTOSIZING,
3794         update the description of this feature to better describe what it does and re-order the define in the
3795         list of defines such that it is in sorted order.
3796
3797 2016-09-26  Konstantin Tokarev  <annulen@yandex.ru>
3798
3799         [cmake] Added an option to disable thin archives when they are undesirable.
3800         https://bugs.webkit.org/show_bug.cgi?id=162561
3801
3802         Reviewed by Michael Catanzaro.
3803
3804         * Source/cmake/OptionsCommon.cmake: Added USE_THIN_ARCHIVES option.
3805
3806 2016-09-23  Caitlin Potter  <caitp@igalia.com>
3807
3808         [JSC] Implement parsing of Async Functions
3809         https://bugs.webkit.org/show_bug.cgi?id=161409
3810
3811         Reviewed by Yusuke Suzuki.
3812
3813         * Source/cmake/WebKitFeatures.cmake:
3814
3815 2016-09-22  Daniel Bates  <dabates@apple.com>
3816
3817         Remove more ENABLE(TEXT_AUTOSIZING) code
3818         https://bugs.webkit.org/show_bug.cgi?id=162456
3819
3820         Reviewed by Simon Fraser.
3821
3822         * Source/cmake/tools/vsprops/FeatureDefines.props:
3823         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
3824
3825 2016-09-20  Don Olmstead  <don.olmstead@am.sony.com>
3826
3827         [WinCairo] Use find_package cairo in build
3828         https://bugs.webkit.org/show_bug.cgi?id=162239
3829
3830         Reviewed by Alex Christensen.
3831
3832         * Source/cmake/FindCairo.cmake:
3833         * Source/cmake/OptionsWinCairo.cmake:
3834
3835 2016-09-19  Daniel Bates  <dabates@apple.com>
3836
3837         Remove ENABLE(TEXT_AUTOSIZING) automatic text size adjustment code
3838         https://bugs.webkit.org/show_bug.cgi?id=162167
3839
3840         Reviewed by Simon Fraser.
3841
3842         * Source/cmake/OptionsMac.cmake:
3843         * Source/cmake/OptionsWin.cmake:
3844         * Source/cmake/WebKitFeatures.cmake:
3845
3846 2016-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3847
3848         [GTK] Make ENABLE_THREADED_COMPOSITOR a public option
3849         https://bugs.webkit.org/show_bug.cgi?id=162148
3850
3851         Reviewed by Carlos Garcia Campos.
3852
3853         * Source/cmake/OptionsGTK.cmake:
3854
3855 2016-09-18  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
3856
3857         [EFL] Bump efl library to 1.18.1
3858         https://bugs.webkit.org/show_bug.cgi?id=162120
3859
3860         Reviewed by Michael Catanzaro.
3861
3862         * Source/cmake/OptionsEfl.cmake: Use efl-1.18.1 instead of 1.18.
3863
3864 2016-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3865
3866         [CMake] Build broken with current debian testing
3867         https://bugs.webkit.org/show_bug.cgi?id=162054
3868
3869         Reviewed by Žan Doberšek.
3870
3871         Building WTR bindings is broken now in