Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
[WebKit-https.git] / ChangeLog
1 2018-04-02  Per Arne Vollan  <pvollan@apple.com>
2
3         Remove references to internal version of WebKitQuartzCoreAdditions in CMake files.
4         https://bugs.webkit.org/show_bug.cgi?id=184246
5         <rdar://problem/39116563>
6
7         Unreviewed build fix.
8
9         * Source/PlatformWin.cmake:
10
11 2018-04-02  Alejandro G. Castro  <alex@igalia.com>
12
13         [GTK] Make libwebrtc backend buildable for GTK  port
14         https://bugs.webkit.org/show_bug.cgi?id=178860
15
16         Reviewed by Youenn Fablet.
17
18         * Source/CMakeLists.txt: Add the libwebrtc directory to the compilation.
19         * Source/cmake/OptionsGTK.cmake: Add the USE_LIBWEBRTC option to
20         allow compilation of the specific code.
21
22 2018-03-30  Daniel Bates  <dabates@apple.com>
23
24         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
25         https://bugs.webkit.org/show_bug.cgi?id=184161
26
27         Reviewed by Per Arne Vollan.
28
29         * ManualTests/DragInlinePDFImageDocument.html: Added.
30         * ManualTests/resources/simple.pdf: Added.
31
32 2018-03-28  Tim Horton  <timothy_horton@apple.com>
33
34         Make it possible to disable building the tools with Make
35         https://bugs.webkit.org/show_bug.cgi?id=184109
36
37         Reviewed by Simon Fraser.
38
39         * Makefile:
40
41 2018-03-25  Carlos Garcia Campos  <cgarcia@igalia.com>
42
43         [GTK][WPE] Add API to convert between DOM and JSCValue
44         https://bugs.webkit.org/show_bug.cgi?id=183448
45
46         Reviewed by Michael Catanzaro.
47
48         Define FORWARDING_HEADERS_WPE_DOM_DIR.
49
50         * Source/cmake/OptionsWPE.cmake:
51
52 2018-03-22  Adrian Perez de Castro  <aperez@igalia.com>
53
54         [WPE] Enable WOFF2 support
55         https://bugs.webkit.org/show_bug.cgi?id=178158
56
57         Reviewed by Frédéric Wang.
58
59         * Source/cmake/OptionsWPE.cmake: Add needed logic to detect the Brotli and WOFF2 libraries.
60
61 2018-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
62
63         [GTK][WPE] Initial implementation of JavaScriptCore glib bindings
64         https://bugs.webkit.org/show_bug.cgi?id=164061
65
66         Reviewed by Michael Catanzaro.
67
68         Set global variables used by the makefiles.
69
70         * Source/cmake/OptionsGTK.cmake:
71         * Source/cmake/OptionsWPE.cmake:
72
73 2018-03-15  Ms2ger  <Ms2ger@igalia.com>
74
75         [GTK][WPE] Enable service workers
76         https://bugs.webkit.org/show_bug.cgi?id=178576
77
78         Reviewed by Žan Doberšek.
79
80         * Source/cmake/OptionsGTK.cmake:
81         * Source/cmake/OptionsWPE.cmake:
82
83 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
84
85         Runtime flag for link prefetch and remove link subresource.
86         https://bugs.webkit.org/show_bug.cgi?id=183540
87
88         Reviewed by Chris Dumez.
89
90         Remove the LINK_PREFETCH build time flag.
91
92         * Source/cmake/OptionsWin.cmake:
93         * Source/cmake/WebKitFeatures.cmake:
94         * Source/cmake/tools/vsprops/FeatureDefines.props:
95         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
96
97 2018-03-12  Zan Dobersek  <zdobersek@igalia.com>
98
99         Unreviewed. Unbreak the WPE layout testing that's been broken since
100         r229470. Due to disassociation between ENABLE(ACCESSIBILITY) and
101         HAVE(ACCESSIBILITY), the injected bundle for the WPE port was left with
102         undefined symbols. This is fixed with ENABLE_ACCESSIBILITY being enabled
103         for the WPE port as well.
104
105         * Source/cmake/OptionsWPE.cmake:
106
107 2018-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
108
109         Unreviewed. Fix library version of JavaScriptCoreGTK.
110
111         * Source/cmake/OptionsGTK.cmake:
112
113 2018-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
114
115         Unreviewed. Bump WebKitGTK+ version to 2.21.0.
116
117         * Source/cmake/OptionsGTK.cmake:
118
119 2018-03-08  Tim Horton  <timothy_horton@apple.com>
120
121         Add a way to not build libwebrtc when building WebKit via Makefiles
122         https://bugs.webkit.org/show_bug.cgi?id=183437
123         <rdar://problem/38254840>
124
125         Reviewed by Dan Bernstein.
126
127         * Source/Makefile:
128
129 2018-03-05  Don Olmstead  <don.olmstead@sony.com>
130
131         [CMake] Split JSC header copying into public and private targets
132         https://bugs.webkit.org/show_bug.cgi?id=183251
133
134         Reviewed by Konstantin Tokarev.
135
136         * Source/cmake/WebKitMacros.cmake:
137
138 2018-03-02  Don Olmstead  <don.olmstead@sony.com>
139
140         Add clang-format configuration
141         https://bugs.webkit.org/show_bug.cgi?id=183302
142
143         Reviewed by Ryosuke Niwa.
144
145         * .clang-format: Added.
146
147 2018-03-01  Michael Catanzaro  <mcatanzaro@igalia.com>
148
149         [CMake] configure failure for aarch64
150         https://bugs.webkit.org/show_bug.cgi?id=183268
151
152         Unreviewed build fix. This failure is caused by a simple typo.
153
154         * Source/cmake/OptionsCommon.cmake:
155
156 2018-02-26  Yousuke Kimoto  <yousuke.kimoto@sony.com>
157
158         [WinCairo] WebKit2_C.h should be included for TestWebKit
159         https://bugs.webkit.org/show_bug.cgi?id=182682
160
161         Reviewed by Yusuke Suzuki.
162
163         Added a new definition "BUILDING_WIN_CAIRO_WEBKIT" to specify
164         the wincairo webkit build.
165
166         * Source/cmake/OptionsWinCairo.cmake:
167
168 2018-02-26  Fujii Hironori  <Hironori.Fujii@sony.com>
169
170         [CMake][OpenVR] Linkage errors happen because only OpenVR is compiled with -stdlib=libc++ if Clang is used
171         https://bugs.webkit.org/show_bug.cgi?id=183116
172
173         Reviewed by Žan Doberšek.
174
175         OpenVR has a option USE_LIBCXX to enable/disable that behavior. Let's disable it.
176
177         * Source/CMakeLists.txt: Added a option command for USE_LIBCXX to set OFF as default.
178
179 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
180
181         [CMake] Expose HAVE macros globally
182         https://bugs.webkit.org/show_bug.cgi?id=183011
183
184         Reviewed by Michael Catanzaro.
185
186         * Source/cmake/OptionsCommon.cmake:
187         * Source/cmake/WebKitFeatures.cmake:
188
189 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
190
191         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
192         https://bugs.webkit.org/show_bug.cgi?id=182883
193
194         Reviewed by Per Arne Vollan.
195
196         * Source/cmake/OptionsAppleWin.cmake:
197         * Source/cmake/OptionsWin.cmake:
198         * Source/cmake/OptionsWinCairo.cmake:
199
200 2018-02-21  Michael Catanzaro  <mcatanzaro@igalia.com>
201
202         [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower
203         https://bugs.webkit.org/show_bug.cgi?id=181825
204
205         Reviewed by Carlos Garcia Campos.
206
207         Get rid of the upower-glib dependency. We will use upower's D-Bus API instead.
208
209         * Source/cmake/FindUPowerGLib.cmake: Removed.
210         * Source/cmake/OptionsGTK.cmake:
211
212 2018-02-20  Adrian Perez de Castro  <aperez@igalia.com>
213
214         [GTK][CMake] Support building with Enchant 2.x
215         https://bugs.webkit.org/show_bug.cgi?id=182933
216
217         Reviewed by Michael Catanzaro.
218
219         * Source/cmake/FindEnchant.cmake: Check for both the "enchant" and "enchant-2"
220         pkg-config components, picking the first available for which the headers and
221         library are usable.
222
223 2018-02-19  Philippe Normand  <pnormand@igalia.com>
224
225         [GStreamer] Playbin3 support
226         https://bugs.webkit.org/show_bug.cgi?id=182530
227
228         Reviewed by Xabier Rodriguez-Calvar.
229
230         * Source/cmake/GStreamerDefinitions.cmake: New
231         USE(GSTREAMER_PLAYBIN3) feature. This should be enabled only for
232         very recent versions of GStreamer (1.14 at least) and is optional, for now.
233
234 2018-02-18  Philippe Normand  <pnormand@igalia.com>
235
236         [GTK][WPE] Fullscreen video is broken
237         https://bugs.webkit.org/show_bug.cgi?id=182740
238
239         Reviewed by Michael Catanzaro.
240
241         * Source/cmake/WebKitFeatures.cmake: Enable the
242         VIDEO_USES_ELEMENT_FULLSCREEN feature on CMake ports.
243
244 2018-02-16  Dean Jackson  <dino@apple.com>
245
246         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
247         https://bugs.webkit.org/show_bug.cgi?id=182894
248
249         Reviewed by Tim Horton.
250
251         Rename OPENGL_ES_2 to OPENGL_ES.
252
253         * Source/cmake/OptionsGTK.cmake:
254         * Source/cmake/OptionsWPE.cmake:
255
256 2018-02-09  Ross Kirsling  <ross.kirsling@sony.com>
257
258         Simplify .gitignore's WebKitLibraries/win section.
259         https://bugs.webkit.org/show_bug.cgi?id=182618
260
261         Reviewed by Per Arne Vollan.
262
263         We need to update this section for WinCairoRequirements regardless, but
264         it never needed to be this longwinded in the first place.
265
266         * .gitignore:
267
268 2018-02-08  Fujii Hironori  <Hironori.Fujii@sony.com>
269
270         [Meta][Win] Support ICU 59.1+
271         https://bugs.webkit.org/show_bug.cgi?id=181004
272
273         Reviewed by Alex Christensen.
274
275         ICU 59 changed the type of UChar from wchar_t to char16_t on
276         Windows. We need a lot of conversions between UChar* and wchar_t*
277         to call Windows API because it takes string as wchar_t*.
278
279         Fortunately, ICU is configurable to define UChar as wchar_t as
280         well as the prior ICU.
281         <http://icu-project.org/apiref/icu4c/umachine_8h.html#a6bb9fad572d65b305324ef288165e2ac>
282
283         * Source/cmake/OptionsWin.cmake: Add a compile option -DUCHAR_TYPE=wchar_t.
284
285 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
286
287         Unreviewed, switch -pthread to -lpthread per recommendation from Adrian
288         https://bugs.webkit.org/show_bug.cgi?id=182400
289         <rdar://problem/37252242>
290
291         This is tested and works fine.
292
293         * Source/cmake/WebKitCompilerFlags.cmake:
294
295 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
296
297         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
298         https://bugs.webkit.org/show_bug.cgi?id=182478
299
300         Reviewed by Alex Christensen.
301
302         * Source/cmake/OptionsWinCairo.cmake: Added a ENABLE_WIN_CAIRO_WEBKIT option to build webkit for wincairo.
303
304 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
305
306         Unreviewed, fix build using the new ENABLE_ADDRESS_SANITIZER option
307         https://bugs.webkit.org/show_bug.cgi?id=182400
308         <rdar://problem/37252242>
309
310         I failed to properly test a last-minute change.
311
312         * Source/cmake/WebKitCompilerFlags.cmake:
313
314 2018-02-05  Michael Catanzaro  <mcatanzaro@igalia.com>
315
316         [CMake] Add ENABLE_ADDRESS_SANITIZER to make it easier to build with asan support
317         https://bugs.webkit.org/show_bug.cgi?id=182400
318
319         Reviewed by Konstantin Tokarev.
320
321         * Source/cmake/OptionsGTK.cmake:
322         * Source/cmake/WebKitCompilerFlags.cmake:
323
324 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
325
326         Update ReadMe.md
327         https://bugs.webkit.org/show_bug.cgi?id=182314
328
329         Reviewed by Alex Christensen.
330
331         Add download link for Epiphany Technology Preview. Improve build instructions for GTK. Add
332         build instructions for WPE. Add instructions to run MiniBrowser on Linux. Miscellaneous
333         typographical adjustments.
334
335         * ReadMe.md:
336
337 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
338
339         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
340         https://bugs.webkit.org/show_bug.cgi?id=182284
341
342         Reviewed by Michael Catanzaro.
343
344         Added private build options for USE_OPENVR.
345
346         * Source/cmake/OptionsGTK.cmake:
347         * Source/cmake/OptionsWPE.cmake:
348
349 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
350
351         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
352         https://bugs.webkit.org/show_bug.cgi?id=177202
353
354         Reviewed by Alex Christensen.
355
356         * Source/cmake/WebKitMacros.cmake:
357
358 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
359
360         [WebAuthN] Add a compile-time feature flag
361         https://bugs.webkit.org/show_bug.cgi?id=182211
362         <rdar://problem/36936365>
363
364         Reviewed by Brent Fulgham.
365
366         * Source/cmake/WebKitFeatures.cmake:
367         * Source/cmake/tools/vsprops/FeatureDefines.props:
368         * Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
369
370 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
371
372         [WebVR] Add OpenVR to the tree and to the build
373         https://bugs.webkit.org/show_bug.cgi?id=177298
374
375         Reviewed by Žan Doberšek.
376
377         * Source/CMakeLists.txt:
378         * Source/cmake/OptionsGTK.cmake: Enable USE_OPENVR.
379         * Source/cmake/OptionsWPE.cmake: Ditto.
380
381 2018-01-18  Dan Bernstein  <mitz@apple.com>
382
383         [Xcode] Shared schemes in the WebKit workspace still have build pre-actions that invoke copy-webkitlibraries-to-product-directory
384         https://bugs.webkit.org/show_bug.cgi?id=181784
385
386         Reviewed by Anders Carlsson.
387
388         * WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Remove the build pre-action.
389         * WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Ditto.
390
391 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
392
393         WEBKIT_FRAMEWORK should not modify file-global include directories
394         https://bugs.webkit.org/show_bug.cgi?id=181656
395
396         Reviewed by Konstantin Tokarev.
397
398         Only modify the system include directories of the target passed to WEBKIT_FRAMEWORK.
399
400         * Source/cmake/WebKitMacros.cmake:
401
402 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
403
404         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.6 release.
405
406         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
407
408 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
409
410         REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
411         https://bugs.webkit.org/show_bug.cgi?id=181438
412         <rdar://problem/36376724>
413
414         Reviewed by Carlos Garcia Campos.
415
416         Build JSC as a shared library.
417
418         Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
419         know how to fix.
420
421         * Source/cmake/OptionsGTK.cmake:
422         * Source/cmake/WebKitCompilerFlags.cmake:
423
424 2018-01-11  Keith Miller  <keith_miller@apple.com>
425
426         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
427         https://bugs.webkit.org/show_bug.cgi?id=181573
428
429         Reviewed by Simon Fraser.
430
431         * Source/cmake/WebKitFeatures.cmake:
432
433 2018-01-10  Per Arne Vollan  <pvollan@apple.com>
434
435         [Win] WebKitLegacy should be a dll, not a static library.
436         https://bugs.webkit.org/show_bug.cgi?id=181500
437
438         Reviewed by Alex Christensen.
439
440         Set WebKitLegacy library type to shared.
441
442         * Source/cmake/OptionsWin.cmake:
443
444 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
445
446         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.5 release.
447
448         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
449
450 2018-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
451
452         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.4 release.
453
454         * Source/cmake/OptionsGTK.cmake: Bump version numbers.
455
456 2018-01-05  Fujii Hironori  <Hironori.Fujii@sony.com>
457
458         REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
459         https://bugs.webkit.org/show_bug.cgi?id=181324
460
461         Reviewed by Konstantin Tokarev.
462
463         r226306 changed to use cmake -E copy to copy header files of
464         DerivedSources. This command copies files unconditionally, then
465         introduced unnecessary recompilations.
466
467         * Source/cmake/WebKitMacros.cmake: Use copy_if_different instead of copy.
468
469 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
470
471         Replace hard-coded paths in shebangs with #!/usr/bin/env
472         https://bugs.webkit.org/show_bug.cgi?id=181040
473
474         Reviewed by Alex Christensen.
475
476         * Source/cmake/tools/scripts/auto-version.pl:
477         * Source/cmake/tools/scripts/feature-defines.pl:
478         * Source/cmake/tools/scripts/version-stamp.pl:
479
480 == Rolled over to ChangeLog-2018-01-01 ==